From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1665747F2EE for ; Wed, 12 Aug 2026 17:56:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786557405; cv=none; b=Pdd1ZUUIpkc5kKAXXe3sVKlvXrisOuECH0tHs5oC5sGydGW/3uUobUcGuZFlhXQDnx91++efF2t7Ynpm2w28h/gp+R+HPacKZ2UhB0RV48d9uhhbjcxk+7DF3oiR7pYKA/APXGAv9u7d+zqtbLo/o5awUMXOzPAk+nN25vPaGRY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786557405; c=relaxed/simple; bh=Gp4TH8J2hlZSx7L5r/Nnct/d2wVRd7ZAb9se+pKxzz8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R4R6lQu110TrV4TSD0jhfVfg7LtKHc6Hl/bDmmxYRIVUXDFskeyl/KAO1pWzKdnu6pmajeU6cJm5BMd2U8ePQCW5zvKl+rhU2i6G4g7ikYThpvl4X9bINFG8tu3qisDbvu5V6nt1+NAKfp1WDwfR21nKazgD0dp4hpk7fEZSfwY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YnCOBEf4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hEzwIba8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YnCOBEf4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hEzwIba8" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CGqHR0111372 for ; Wed, 12 Aug 2026 17:56:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= H7aPqzXzK+bffdypT6w5RZHf4yVPPVyPFUZRNwHMo/0=; b=YnCOBEf4xA0Xt3w0 OiorpC7j/CjhdLOuryWiCjYc1KAtk3bOIOYW2zLjHPJIKK41LLThrTlgM/A7BdiR B9K1jcUq/bGeX/auKpbVM/RfZVzmBsXYEMYmu1jblrTz+g6Yhn8P9lGEg6cCwHMf 4ezn89XqFRkAUyjFQGhfP/Vt1zqeQe6KY0rjYrqjmAz81+xoXH2vK/XpWlasLxKE i5d7FxfmvFjWZegc42e7sq1SxVw4Swsz5HHVORl93ophCWOZjvuOeipTeXRpxWyp SRVEOB9wHIrLfApw5onUzfWAeq7sdxUcTZrn2HHHWdKJCV05iT02V6x71czSMSAw yLQY3A== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g0hj1kepm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 17:56:42 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cb4bd11ddf8so1394873a12.3 for ; Wed, 12 Aug 2026 10:56:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786557402; x=1787162202; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=H7aPqzXzK+bffdypT6w5RZHf4yVPPVyPFUZRNwHMo/0=; b=hEzwIba8auKrKhyR7tyen8nrBKoaSSxPsd0V75feE+IXPyuzm9oQfIs/6dRSgnqZPV s79GxyBVop84ZWY/0hG8RxGWRo+ZlnD+Ku0bqQUdq8ZuPCwxDQUFDnZZpjJeBzpy2iJC cQTyiW5PrS/f7bzdrPYco9GLVWVTjJvKl0Ng8mslQ5tM3buxN6y029NyguaqSWVBYG+M NZfQkPDKcrgQ6JDHRJ7tMEIEkPf3jbhYjCvN7gM9CwMQUAnqqLczuNum/cWudvTPM0Jr Ao3FVK10z4kaypmvAFVqpIFKOYrvF2atgbAj1/0Qak3uLgCKq/3oPFAbYbdklHUZM1Fo g1Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786557402; x=1787162202; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=H7aPqzXzK+bffdypT6w5RZHf4yVPPVyPFUZRNwHMo/0=; b=icY4fZ3c+xS6WvAq00383Qz++Z0wiooWIzYF67zrIxJK4phUcLRJe9cbTlmecDFjr/ RfZEVJJnvoyO71sGAQoSNHpYzbv7IAyWn2jDjllcj+M3TSLjy5PHzMzMg1GXGMD4qxwf G7oZ6p9c9JjbubnIdjuw5mAGW7WCwHsL80mTlRwJlG7PnUKkUdI0J5dDOBwElicTidun TsCus9oljU5vSvUAYmOpXSf8ulKI1qN52QMI+ulpiC86A7U5RFBwoglIjO4ZNXHmQFiF GlzM6ECWF1tUgv7fwrqerBnMvS7JM5euSslKAv/cT/ZL8dj+jo3KbljXccbLpJ99e1kF dUNg== X-Forwarded-Encrypted: i=1; AHgh+Rop3ME6YID+/o/QySHb30ABDOcLAO9Fmeao8E5TDWAGPOCQbNrI8iQKZ/PSw5HICguagWrRsqR18dfYm6U=@vger.kernel.org X-Gm-Message-State: AOJu0YxvkT96PCgDY2lRzc91NGvXoqxN7+XC6E+i6IpxEteZiBDUgd1z fUbtWq1ohF9srUV+dXG5isIgrGdzGUS7Mvz+GOixZ3MRhOcMpr0tz2QhUPuSyYfQjEGurjSmFsN B6nP9Re/q2dLspnbVFY5psnOyYs5uhiy08s4v1LdJ6sA483T9gzz9GvKkpP0h+kybsWc= X-Gm-Gg: AR+sD13M0HRlUPMBa9HMPAoBA93P0EekvMXS1K/DJjOAbFFVcVDipYkwkYSlkW6XCFP i9Vyn10xvRDRMZkueDPkxfbXTuW4jE0i5l+W7hTk82zKyApYLQmu112XLGOtiFS/h4XFH4pyEUu W1EGCG1FXpYv/hy36wxyEPOSLMWjG0LMCqgGdiCwoQRJ+Tnxqn+YpTOoz4VOp7F5r9lkc5VRqnx 4hOfXOrblnZ9RbaVVL40KBCLFf3EDEebCfDFG2pEF1c1L33bTXA5kDDOIsObAB2X7HAi0OLIgne gRRa/vnyAMMcHSAzmtYgIeYvelNRnnqA2AfcFbto01a3PgvCU8ECD95TY91NOybhkQNo3sCBgHx zdZ4jHlpoJE4XKYYWd52pc2XHgTwgurGr2Ck= X-Received: by 2002:a05:6a20:cd96:b0:3c0:b766:74f4 with SMTP id adf61e73a8af0-3cc553f71d1mr184953637.31.1786557401812; Wed, 12 Aug 2026 10:56:41 -0700 (PDT) X-Received: by 2002:a05:6a20:cd96:b0:3c0:b766:74f4 with SMTP id adf61e73a8af0-3cc553f71d1mr184894637.31.1786557401210; Wed, 12 Aug 2026 10:56:41 -0700 (PDT) Received: from [192.168.1.8] ([106.222.230.104]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cbef710cc24sm19799a12.20.2026.08.12.10.56.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Aug 2026 10:56:40 -0700 (PDT) Message-ID: Date: Wed, 12 Aug 2026 23:26:35 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] i2c: qcom-geni: add I2C frequency table for 32 MHz firmware-based SEs To: Kathiravan Thirumoorthy , Viken Dadhaniya , Andi Shyti , Manikanta Mylavarapu , Bjorn Andersson , Konrad Dybcio Cc: Mukesh Kumar Savaliya , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260812-ipq5424_i2c_scl_updates-v2-0-e09cd39d01d7@oss.qualcomm.com> <20260812-ipq5424_i2c_scl_updates-v2-2-e09cd39d01d7@oss.qualcomm.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: <20260812-ipq5424_i2c_scl_updates-v2-2-e09cd39d01d7@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: kMVruVuQIK2eJhQbqaeyUhqMRVtqKADD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDE0NCBTYWx0ZWRfX7guaIbA4uvNU 7qHGjjotBcvsLbPTN2I1l4MhfrKISEr9NkxnUvoY9ICLSp0gMJzGfi1HUUUjq8Dd6noh6RETqsr zVajn914oIt3GGX0uE3YwzkJJwWRlitVfLF4s7OW7Me0UL3t0DzOik916zylBKt2onGs6GtSm8z xPSkzg1W17C6uQ6+sfRHO7OExCy5/x0H6FcelpBfGeshtagtVrc003fucnW9KqWmX4Ao8hdDQlW ygzIlwGJGSPBtUb6ie+tCsVlnbrm2e14OkTV7dUOBE4CAGje34RLhv/YYZ2/nBDPKOaHnmd0JNI TJaLQrOZq7q5VCwklE4gKq1VYSbmy7dHliT8qdpAw64hF1ciZ92dkGNmABGqmu6pORc+ocP4fTj KZqyFgVrYTB0TjaZaI9o4K6idFWDI9VrO3sziQS5Xq8TCZmCaURGH8q1w49HT/Aj346De2e4hSs Wehe7UjBxBS/V9FPsgA== X-Authority-Analysis: v=2.4 cv=K6ES2SWI c=1 sm=1 tr=0 ts=6a7cb3db cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=hsRoOqe6K9Dtf6G3Ghy1+w==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=eXSzwYDvwnVE6XuJA1gA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-GUID: kMVruVuQIK2eJhQbqaeyUhqMRVtqKADD X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDE0NCBTYWx0ZWRfX5Bet+kjicNVR AJ+yu67cXoc/UP2hwakeGm4LT8OZ0niksPR/IY9eeu49fqoxeyvYR/+vQtF+PYnszJGqruL2Ndp dHSELT8K8jCtacCNXR9GXRTud1NVHM8= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 adultscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120144 On 8/12/2026 2:00 PM, Kathiravan Thirumoorthy wrote: > On IPQ5424, the I2C controller can operate on both RTL-hardened SEs > and firmware-based SEs. As documented in commit 506bb2ab0075 > ("i2c: qcom-geni: Support systems with 32MHz serial engine clock"), > in IPQ5424 SEs use a 32 MHz source clock. > > The existing frequency table does not provide the required SCL timing > parameters for firmware-based SEs. Add a dedicated frequency table > using the SCL counter values recommended by the hardware design team > and select it for firmware-based SEs to achieve the target bus > frequencies. > > Move geni_i2c_clk_map_idx() from geni_i2c_resources_init() to > geni_i2c_init() to ensure SE_HW_PARAM_2 is accessed only after the > required clocks have been enabled. > > Signed-off-by: Kathiravan Thirumoorthy > --- Reviewed-by: Mukesh Savaliya