From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939221AbdD0NYP (ORCPT ); Thu, 27 Apr 2017 09:24:15 -0400 Received: from mout.web.de ([212.227.15.3]:55019 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550AbdD0NYJ (ORCPT ); Thu, 27 Apr 2017 09:24:09 -0400 Subject: Re: hwmon-NCT: Fine-tuning for four function implementations To: Jean Delvare Cc: linux-hwmon@vger.kernel.org, =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= , LKML , kernel-janitors@vger.kernel.org References: <2f58a509-4aba-5c44-bc79-568b260ab692@users.sourceforge.net> <20170427145030.5507a32e@endymion> From: SF Markus Elfring Message-ID: Date: Thu, 27 Apr 2017 15:23:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <20170427145030.5507a32e@endymion> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:TEkx93kHZOVQej5nKwR72/Av9Eh5VuDrZg8bvW4Vs2t/it0thsJ zVvlwcXmoWXa/C38V9MfVoQ0xOrP925xZCdq4v/JxYiC3SaIVpwJ+8PTvXA/gq2nQKSYNkz PZGjN5ihNwsivwQTR6wMLJzxQ1H5qdfCvFgtbtyP6qitetCQyhQwA6Qa7KQHo6HFpICP/ot 1pADOxgskgLpCr8ERfLfA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Z03Z98QVEns=:AOrmw4xMTNYKruXNKfMqm/ 6iqChhx0uuldDvAg8ZOyAQE72e8t5ddrvj/6kBToaUyJ3vslvsJNAcxZpJzhFWc9a17QmctiU nbYX8WbxdR541gA6kJGwMu6xN7e8qvYG+2rbQOPiEJV91KNZpPA4FjDNIBxFRtHMvN6rC8MDe qx1CBGpkrB3Yr5YdhO4iWPJ/iiPEgYZQo0FUYz57EPszoyKp9X7HeCTPaTjHhLZ4O1u1Fl5L6 dBS/TZi0/yV6F5/xD9zwzM2kWFlSWSnN4q1RfH1SblySfa3cF6PUheKNPFYhUjHcQHKTMaFz1 XsfUfllEID9xb3SNNU+Ev9l3+Eezy+4XHCQYUmLxbtzfN2HLEair9m9rl30Nr5Dvuks8qjYzj 0ftvOcoSUMmw6R+GO4WAWTi+nZ73br9jGnJx1AKaCn6eaRgdOtlw9MSuHcXgxhsbMA5Vd2wWC OQ8FjpD172Dz/Szpsax0/WBaedt0Fu+RAsrUJQTSuPSZZ7DAEOTvuk3rYeiS6+KDeLronOtv+ SnG2eMUwkACbinoI74Njqa3W4f9TnLbFAf305zNOK0LYrMtW17zqxk/MqnmpDk8YEsZW+nSOu LtVW7M0p+iTLeBw34BG24Ca5tB7LxR7fvEdQDEdhKezp3UuXgHmugkuE+FoVRJZGyw5Ix1tW8 2MbWq1fuOffHiU6Y2YgyNO+lMWsBFxGSKugDOd0JJ9Wmie6X1L4NqVnD4owP4r3OWrzWrvPBc EZNvX+oq3LmIsnu7b3F/FUg0E7Jwxcr1LQG9w3Dbm3arQR0ZhvISpCusl8wleOdvrdZGRF/Zu UjZG8Im Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 27.04.2017 um 14:50 schrieb Jean Delvare: > On Thu, 27 Apr 2017 11:27:21 +0200, SF Markus Elfring wrote: >> From: Markus Elfring >> Date: Thu, 27 Apr 2017 11:18:22 +0200 >> >> A few update suggestions were taken into account >> from static source code analysis. >> >> Markus Elfring (4): >> Use devm_kcalloc() in nct6683_create_attr_group() >> Adjust five checks for null pointers >> Use devm_kcalloc() in nct6775_create_attr_group() >> Adjust seven checks for null pointers >> >> drivers/hwmon/nct6683.c | 15 +++++++-------- >> drivers/hwmon/nct6775.c | 19 +++++++++---------- >> 2 files changed, 16 insertions(+), 18 deletions(-) > > You have proven in the past on various lists that 1* you have no > understanding about the changes you are proposing You are right in the sense that my knowledge is still incomplete in some areas. > and 2* you have no skills to discuss any problem that could be found > in your patches. But I disagree to this view. My skills might not fit to your expectations at the moment. But I hope that there are further opportunities to resolve remaining software development concerns. Regards, Markus