From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.52 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794391356; b=n0T00gsk3pPW5oESN2Hk5yz+vV7TwDNkVcIC0Kz3h/oBEA8Fp27WGdfP4DV9U++7qC+s 1mwfYLERyQ+gTNabpIQ706Dy+ry2Lv2MejJjD2NiXYpaxRnnUpp/SWUq5WtVPKfoQK/oW 96lXukHl7pJGUXLNL2PU6keMpn0L1lYpP8/miiSE3axIX2Xu5JTXuFVuPucokJ2y8WDhl u8Laxd9O6dt1Cgp51MhSzD7cem5nBx2BPLPVgm/b7ioqoVEBESje8YMWi31EydmS8WH2U o4wG2LxaobRhntCtbUBeI+6OqKdeS3dLu7zG6+0ggfN5V1FDAufg3ZXIDuPDpUNkLNw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794391356; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:Message-ID:Date: MIME-Version:User-Agent:Subject:To:Cc:References:Content-Language: From:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=6Uf8NjTATLaSx0T6xJbOfk8n0GZJkRQt+2l2OmlV7/s=; b=Ad4vsbPFlvbtvzjHVZbeu5j1hs5o4/L/OosL2D/sIkpARtSRpTzQlQxCcoJ1EcVfq/tY 1PfhjJm7J8qNogiFbYmh8Rb6Oob+eMrsmzdT99LEKkZPp+I3Xq4HPkJJr1P8XLxGNcNMr dyUxrBZ1ZI9leeYQqGwxCLuJrw66xGvUKdcsDI8A8qdCoI8OFbrg7I4ljp77e3iPTZOFl XSRKMhqbBCUzXCvgAPfMvoNRsRLN65dDp8DCfmWSgmsl9+YW6349V0+iOEU6VV5XONoyJ 5bvYetxvJ38RTTdLw84+g4a6rc/aoNKlUZ+ahbg5xTRq6CVC2Pwo6LrFIAd/z/yO/QA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=h0U2KI9H; arc=none smtp.remote-ip=209.85.221.52 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 084B8606A33F for ; Wed, 11 Nov 2026 10:02:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 084B8606A33F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=h0U2KI9H Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-48b001cd92bso1572077f8f.2 for ; Wed, 11 Nov 2026 02:02:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1794391354; x=1794996154; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6Uf8NjTATLaSx0T6xJbOfk8n0GZJkRQt+2l2OmlV7/s=; b=h0U2KI9Ho3jaYsUkDK5Fn9tyFwbypvCXXUNlfq5rS+pYSn4ZWsgiwyV/pdkqvTjDA+ z6ZKvdaYbjQ17EYoNNC+EFELKj1jdE59psVlK6fnVag4qu+cTVc6XqNnmtFgh7Vy5Z7X QnwyOkRLsdL4Jc1XSO2j/x3bC7y820cojw8HTyVPpGZTFHQFG3cIdL3eKPfWolG22ZTT uFnol787+UL2MgjSwk6ipu8tWjxFiAh7ey2AtVznp1Q6dsl1U8qFxm1aLzHWt8Qi7DVt MuAgEQ+Md/6RetRneZV8tKuZd+0Ywx02jhUTmncLH4XCZC2HC1En7KBC5mEhZLsjKlEI Unjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794391354; x=1794996154; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6Uf8NjTATLaSx0T6xJbOfk8n0GZJkRQt+2l2OmlV7/s=; b=maVB/XPluj7301dHhXRkni3s0JOo8zpKSRBdN8eTStWPyyVEhjObij2Ht8D31gJW9e ZzL8ztG8feXzBqZo5bRKeQRDY0VebKh3hiDWVYMwiw6Xdd3xSMyp1CYwh3oBYgdx8Elt e5+p4P/N7TD7/7qx4RBZKRT16reitfJFmKWqsie8E9Y4eKeThe1dgp9U+UlTXuDm+ZNT WDHLlLKfMt/fRdZ1I/GnZ657zSiatNUfubOIsaEuNKixJYC77VsFQow4VCCf7PRkV56j 97K+95a7GpFMVr+fj5FTNMtFX8FxHQFMb1oP3V4OSd/9XLjq2l0MY2xmi0PIbw2WAYaK 0R8g== X-Gm-Message-State: APuU4Z+R9qE3wODjNe1kdBQRrp/0KAvOyITcJ+w1WrnTzvlJLnvWwnwl 3/7DfT0++nUmUwSTQJok4Irn2/U6CaiixRJ2GigZzyuf0Va6zjUdrCEwJaBRSe2ghfg= X-Gm-Gg: AYBFou3baJRIc0lfqVDRmQoAgJvxKGa9ECL3qVYncyo63o9d3w8US/+LB/QsJdAQrbY Zztr3lC9r6d2GIOHwmvuCGjNumA3ORXwD0xXTDo9Zz7QWz+h29f2H1sA87LyeuGMKwXPcSnsTK7 Oy9Ad/nKZZQ6Pmt35WKU9UIkv/tkngBuE7pTl3WFMi7Bd+VcejIEgEs65om6J63BLQKAnCwCte+ WsXTpjhscFDy83AWwc3tYQqa2Dm141kTXji2wkVlu4RJVgulTUSplFSPYJbvjtxuPvTBSt7Lpk0 u5qv5YABTq9PL8unxmrIJ0nS6bi+oVcWCRopIXfBLF94tu2JdEZF1fk8sNEXtJ50FuZebHtQXbm wlnmRpi2Ke1Nzac2/v4IwaLs3S50Zw4pF7sOBuDfTWot+JSquOMAB+UY2b4K+tHdcs+JgygC/hx zKtkBnkbaDkaWZ+fNCcHaWRwYMdZvGwoKBeCh0hZd704QdkoRQqdLeJAyI4Fz8jZ2Bygs8Jpcab +ZLr/gokx4RLaqeooV1Y558rfzgKJqBLZejp3IqIXXvESUcZhOsRlVhgAJptK7/bSsIIKMiqhPa 3qOs1qLb5+U3Enaw1Qw6WACBF0f+b449KdJvpTrSBSX2ZlOD4pPd2bMSXM/Vvg== X-Received: by 2002:a5d:64e3:0:b0:48d:ff71:dd9d with SMTP id ffacd0b85a97d-499c903d741mr3207711f8f.23.1794391354282; Wed, 11 Nov 2026 02:02:34 -0800 (PST) Received: from [10.11.12.111] ([79.115.63.240]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-499823761f5sm4941304f8f.2.2026.11.11.02.02.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Nov 2026 02:02:33 -0800 (PST) Message-ID: Date: Wed, 11 Nov 2026 12:02:31 +0200 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [thermal: thermal/linux-next] thermal/drivers/samsung: acpm-tmu: Rename platform driver to "exynos-acpm-tmu" To: Alexey Klimov , linux-pm@vger.kernel.org, Daniel Lezcano Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org References: <20261026-acpm-tmu-fixes-v1-11-0637431b7268@linaro.org> <179389375857.1009794.283716939057872036.tip-bot2@tip-bot2> Content-Language: en-US From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/11/26 2:42 AM, Alexey Klimov wrote: > On Thu Nov 5, 2026 at 3:49 PM GMT, thermal-bot for Tudor Ambarus wrote: >> The following commit has been merged into the thermal/linux-next branch of thermal: >> >> Commit-ID: ba446bdd27d4a2a6c0cb267f51a6ecc47cf19cf9 >> Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//ba446bdd27d4a2a6c0cb267f51a6ecc47cf19cf9 >> Author: Tudor Ambarus >> AuthorDate: Mon, 26 Oct 2026 16:01:28 >> Committer: Daniel Lezcano >> CommitterDate: Tue, 03 Nov 2026 19:51:51 +01:00 >> >> thermal/drivers/samsung: acpm-tmu: Rename platform driver to "exynos-acpm-tmu" > > Also, the fix for this problem was sent here earlier: > https://lore.kernel.org/linux-samsung-soc/20261020-acpm-thermal-drv-name-fix-v1-1-71f72280583b@linaro.org/ > > Why taking this one and ignoring the fix that was sent earlier -- this > should be at least explained. I guess it slipped through the cracks, as it did for me. > >> Rename the platform driver from "gs-tmu" to "exynos-acpm-tmu" to reflect >> that the ACPM TMU architecture is shared across Samsung Exynos SoCs >> (such as GS101, AutoV920, and Exynos850) rather than being specific to >> GS101, matching "exynos-acpm-protocol" in drivers/firmware/samsung/. >> >> Suggested-by: Alexey Klimov > > I don't recall suggesting this. Reporting -- yes, but not renaming to > "exynos-acpm-tmu". my apologies, it wasn't intended. If you have a strong opinion on the tag type, I guess Daniel can drop it. > > This was reported months ago and was never fixed in the updated > series for acpm-tmu.c. > >> Signed-off-by: Tudor Ambarus >> Signed-off-by: Daniel Lezcano >> Link: https://patch.msgid.link/20261026-acpm-tmu-fixes-v1-11-0637431b7268@linaro.org >> --- >> drivers/thermal/samsung/acpm-tmu.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/thermal/samsung/acpm-tmu.c b/drivers/thermal/samsung/acpm-tmu.c >> index 42b338d..2324efc 100644 >> --- a/drivers/thermal/samsung/acpm-tmu.c >> +++ b/drivers/thermal/samsung/acpm-tmu.c >> @@ -597,7 +597,7 @@ static const struct dev_pm_ops acpm_tmu_pm_ops = { >> >> static struct platform_driver acpm_tmu_driver = { >> .driver = { >> - .name = "gs-tmu", >> + .name = "exynos-acpm-tmu", > > It is minor but it potentially clashes with exynos-acpm-tmu firmware There's no driver name for the firmware tmu commands helpers but I see your point. > file name. All other names in file acpm-tmu.c are "acpm-tmu". I think "exynos-acpm-tmu" is fine, it aligns with "exynos-acpm-protocol" from drivers/firmware/samsung/exynos-acpm.c. I guess you may rename "acpm-clocks" (drivers/clk/samsung/clk-acpm.c) to "exynos-acpm-clocks", but I wouldn't bother too much. If you have a strong opinion on "acpm-tmu" send a patch on top please. Cheers, ta