From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08630C001E0 for ; Mon, 23 Oct 2023 10:01:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229654AbjJWKB6 (ORCPT ); Mon, 23 Oct 2023 06:01:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233134AbjJWJua (ORCPT ); Mon, 23 Oct 2023 05:50:30 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A16AD6B for ; Mon, 23 Oct 2023 02:50:27 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id BAC4D6606F51; Mon, 23 Oct 2023 10:50:24 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1698054625; bh=jGS4wjjKQT+jnkpy/yvPYn70Z9+yx4rAHIJ/2NeAlz4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Aqh47hyd/S0BF0/zcRu4GCSeAePAoEpctZeh9g60YdqSt63KwdcI0vNUEtGmjzazQ oIBC4wFm4988DN9q9cf8o5ml5uVfkS1ygKLhO1Rti2q7UkCIF896zt7Attj6dwsdaG eS9QE6BFDNKFczC5BD0sXUq7IWeC/ikLLnZtRQWURAjN889N73j8DYNGKctgKA/HTY 6RAvQMtlO3quQWOcCoGG0IwTwaGMN6xtsAtycrDHotzUxV8k3h588A9159nzBWLya1 LiNRRRK8YkzgVgrYbNnB2NGw+eL3dTsXWr4Q94FNwu8cqDzqgLzm8SB/q+rH6bvlmG q5uPF/OWocVsw== Message-ID: Date: Mon, 23 Oct 2023 11:50:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/9] soc: mailbox: Add cmdq_pkt_finalize_loop to support looping cmd with irq Content-Language: en-US To: "Jason-JH.Lin" , Jassi Brar , Chun-Kuang Hu , Rob Herring , Krzysztof Kozlowski Cc: Conor Dooley , Matthias Brugger , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com, Jeffrey Kardatzke , Jason-ch Chen , Johnson Wang , Singo Chang , Nancy Lin , Shawn Sung References: <20231023043751.17114-1-jason-jh.lin@mediatek.com> <20231023043751.17114-6-jason-jh.lin@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20231023043751.17114-6-jason-jh.lin@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 23/10/23 06:37, Jason-JH.Lin ha scritto: > Add cmdq_pkt_finalize_loop to CMDQ driver. > > cmdq_pkt_finalize_loop appends end of command(EOC) instruction and > jump to start of command buffer instruction to make the command > buffer loopable. > > GCE irq occurs when GCE executes to the EOC instruction. > CMDQ client can use a loop flag to mark the CMDQ packet as looping > packet. If the CMDQ packet is a loopping packet, GCE irq handler > won't delete the CMDQ task and disable the GCE thread. > > Signed-off-by: Jason-JH.Lin > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 11 +++++++++++ > drivers/soc/mediatek/mtk-cmdq-helper.c | 23 +++++++++++++++++++++++ > include/linux/mailbox/mtk-cmdq-mailbox.h | 1 + > include/linux/soc/mediatek/mtk-cmdq.h | 8 ++++++++ > 4 files changed, 43 insertions(+) > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c > index 4d62b07c1411..56fe01cd9731 100644 > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c It's true that without the changes in soc/mediatek this is not doing anything, but mailbox/mtk-cmdq-mailbox.c goes through a different maintainer... Please split the changes to drivers/mailbox/mtk-cmdq-mailbox.c and its header to a different commit. Hint: 1. soc: mediatek: cmdq: Add cmdq_pkt_finalize_loop for looping cmd with irq 2. mailbox: mtk-cmdq: Support GCE loop packets in interrupt handler Thanks, Angelo