From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6D46CE7A89 for ; Sat, 23 Sep 2023 17:41:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232085AbjIWRlr (ORCPT ); Sat, 23 Sep 2023 13:41:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231593AbjIWRlp (ORCPT ); Sat, 23 Sep 2023 13:41:45 -0400 Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0D3A100; Sat, 23 Sep 2023 10:41:38 -0700 (PDT) Received: from eig-obgw-6008a.ext.cloudfilter.net ([10.0.30.227]) by cmsmtp with ESMTP id jnFHqEypSez0Ck6czqCyML; Sat, 23 Sep 2023 17:41:13 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id k6dMqYsHUsKmik6dMqOQ7D; Sat, 23 Sep 2023 17:41:37 +0000 X-Authority-Analysis: v=2.4 cv=JOMoDuGb c=1 sm=1 tr=0 ts=650f2351 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=P7XfKmiOJ4/qXqHZrN7ymg==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=zNV7Rl7Rt7sA:10 a=wYkD_t78qR0A:10 a=NEAV23lmAAAA:8 a=VwQbUJbxAAAA:8 a=ag1SF4gXAAAA:8 a=Z4Rwk6OoAAAA:8 a=cm27Pg_UAAAA:8 a=HvF037n1xESchLcPDVoA:9 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 a=Yupwre4RP9_Eg_Bd0iYG:22 a=HkZW87K1Qel5hWWM3VKY:22 a=xmb-EsYY8bH0VWELuYED:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=++nWpQa97CCPvpYPRMBMXBNuReyoQn5UM5gamZgvfKA=; b=hiUjETCWBnOvOBAmo4j3aqv+Az ZC2FHST4P/vjIZumiA51c46rgJUfR+nRKsNwKFeI/lwVUQ5WqVx8lexT8dkGMekA5zYY/9tbtElmu hnzc+lmCnVnUJjsNSjXCf1WwxI0UvKM0BzB5J/rXMngV8aJ0nY9afKCx+hwpQyHJjvTE32FzqRzAU Lz4MwLXUiCdMbv4JH5fr77qx2KoND8icMOPR4RIyarRB+tCqhmDRB39Dq/V0wG3pYh/G6jLVwDzq1 u/+9Ks0lDFOI/2NtflfA99I7gIlUDAyjOUdtlMzASf8DpOf9OBtI0vXgHlzujEkQESaIzyKUY5H7o TRUwiQnQ==; Received: from [94.239.20.48] (port=38088 helo=[192.168.1.98]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1qjy2r-003aT7-0v; Sat, 23 Sep 2023 03:31:21 -0500 Message-ID: Date: Sat, 23 Sep 2023 10:32:26 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] virtio_console: Annotate struct port_buffer with __counted_by Content-Language: en-US To: Kees Cook , Amit Shah Cc: Arnd Bergmann , Greg Kroah-Hartman , virtualization@lists.linux-foundation.org, Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org References: <20230922175115.work.059-kees@kernel.org> From: "Gustavo A. R. Silva" In-Reply-To: <20230922175115.work.059-kees@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 94.239.20.48 X-Source-L: No X-Exim-ID: 1qjy2r-003aT7-0v X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.98]) [94.239.20.48]:38088 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 0 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfP2RDT/c5D9xhi3ND6CvD4Dn1Zq0Kxcz2CwhTiQqXpFyGFmo/l09Ywa6c76eIclKws3Jh1SvAXVv2v2ee04J8BLk3Y0lJU20jH6nr7ErjPUxgOBYccbu w7f+SeY8uZvbsMoFs091A5EQduU0xxevs09R/k2/2c27ftS6y+5pjvPOBhqywTJMBL/WPc5QHY4KYulrS8ZNhIFsYIGuS3bvyEF5l2DShcnpKZWFhYKSne6S HfJRmihBkAvHI3rIeOvJ9OYLykIo4HLL0MXAAucDeR8= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/22/23 11:51, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct port_buffer. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Amit Shah > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman > Cc: virtualization@lists.linux-foundation.org > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/char/virtio_console.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > index 680d1ef2a217..431e9e5bf9c1 100644 > --- a/drivers/char/virtio_console.c > +++ b/drivers/char/virtio_console.c > @@ -106,7 +106,7 @@ struct port_buffer { > unsigned int sgpages; > > /* sg is used if spages > 0. sg must be the last in is struct */ > - struct scatterlist sg[]; > + struct scatterlist sg[] __counted_by(sgpages); > }; > > /*