From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19AA2C00523 for ; Fri, 3 Jan 2020 21:47:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6EF2215A4 for ; Fri, 3 Jan 2020 21:46:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728741AbgACVq7 (ORCPT ); Fri, 3 Jan 2020 16:46:59 -0500 Received: from smtprelay0098.hostedemail.com ([216.40.44.98]:38454 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728549AbgACVq6 (ORCPT ); Fri, 3 Jan 2020 16:46:58 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id C64CE249C; Fri, 3 Jan 2020 21:46:56 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: bulb70_249ac3912826 X-Filterd-Recvd-Size: 2061 Received: from XPS-9350.home (unknown [47.151.135.224]) (Authenticated sender: joe@perches.com) by omf12.hostedemail.com (Postfix) with ESMTPA; Fri, 3 Jan 2020 21:46:55 +0000 (UTC) Message-ID: Subject: Re: [PATCH 3/3] lib/find_bit.c: uninline helper _find_next_bit() From: Joe Perches To: Yury Norov , Thomas Gleixner , Andrew Morton , Allison Randal , William Breathitt Gray , linux-kernel@vger.kernel.org Date: Fri, 03 Jan 2020 13:46:07 -0800 In-Reply-To: <20200103202846.21616-3-yury.norov@gmail.com> References: <20200103202846.21616-1-yury.norov@gmail.com> <20200103202846.21616-3-yury.norov@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-01-03 at 12:28 -0800, Yury Norov wrote: > It saves 25% of .text for arm64, and more for BE architectures. This seems a rather misleading code size reduction description. Please detail the specific code sizes using "size lib/find_bit.o" before and after this change. Also, _find_next_bit is used 3 times, perhaps any code size increase is appropriate given likely reduced run time. > Signed-off-by: Yury Norov > --- > lib/find_bit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/find_bit.c b/lib/find_bit.c > index c03cbecb2b1f6..0e4b2b90c9c02 100644 > --- a/lib/find_bit.c > +++ b/lib/find_bit.c > @@ -27,7 +27,7 @@ > * searching it for one bits. > * - The optional "addr2", which is anded with "addr1" if present. > */ > -static inline unsigned long _find_next_bit(const unsigned long *addr1, > +static unsigned long _find_next_bit(const unsigned long *addr1, > const unsigned long *addr2, unsigned long nbits, > unsigned long start, unsigned long invert, unsigned long le) > {