From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_RED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41EFCC433DB for ; Sat, 27 Feb 2021 01:05:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 073AB64E7A for ; Sat, 27 Feb 2021 01:05:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229990AbhB0BEm (ORCPT ); Fri, 26 Feb 2021 20:04:42 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:12585 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229618AbhB0BEh (ORCPT ); Fri, 26 Feb 2021 20:04:37 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DnSsV6l6bzMd8F; Sat, 27 Feb 2021 09:01:50 +0800 (CST) Received: from [10.174.177.244] (10.174.177.244) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.498.0; Sat, 27 Feb 2021 09:03:54 +0800 Subject: Re: [PATCH] RISC-V: Make NUMA depend on SMP To: Palmer Dabbelt , , CC: , Palmer Dabbelt , , Paul Walmsley , , References: <20210226202550.512012-1-palmer@dabbelt.com> From: Kefeng Wang Message-ID: Date: Sat, 27 Feb 2021 09:03:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20210226202550.512012-1-palmer@dabbelt.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.174.177.244] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/2/27 4:25, Palmer Dabbelt wrote: > From: Palmer Dabbelt > > In theory these are orthogonal, but in practice all NUMA systems are > SMP. NUMA && !SMP doesn't build, everyone else is coupling them, and I > don't really see any value in supporting that configuration. > > Fixes: 4f0e8eef772e ("riscv: Add numa support for riscv64 platform") > Suggested-by: Andrew Morton > Suggested-by: Atish Patra > Signed-off-by: Palmer Dabbelt Reported-and-Tested-by:  Kefeng Wang > --- > This is on fixes. > --- > arch/riscv/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index a998babc1237..85d626b8ce5e 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -314,6 +314,7 @@ endchoice > # Common NUMA Features > config NUMA > bool "NUMA Memory Allocation and Scheduler Support" > + depends on SMP > select GENERIC_ARCH_NUMA > select OF_NUMA > select ARCH_SUPPORTS_NUMA_BALANCING