mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: linmiaohe <linmiaohe@huawei.com>, "Li,Rongqing" <lirongqing@baidu.com>
Cc: Liran Alon <liran.alon@oracle.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"vkuznets@redhat.com" <vkuznets@redhat.com>
Subject: Re: [PATCH][resend] KVM: fix error handling in svm_cpu_init
Date: Fri, 21 Feb 2020 17:58:05 +0100	[thread overview]
Message-ID: <e77238c5-94a6-0695-b49a-6ce6f4ccab70@redhat.com> (raw)
In-Reply-To: <b7a41c2ec0e644119180ba61d10ab4b9@huawei.com>

On 20/02/20 09:40, linmiaohe wrote:
> Li,Rongqing <lirongqing@baidu.com> writes:
>>> Hi,
>>> Li RongQing <lirongqing@baidu.com> writes:
>>>>
>>>> sd->save_area should be freed in error path
>>> Oh, it's strange. This is already fixed in my previous patch : [PATCH v2] KVM:
>>> SVM: Fix potential memory leak in svm_cpu_init().
>>> And Vitaly and Liran gave me Reviewed-by tags and Paolo queued it one 
>>> month ago. But I can't found it in master or queue branch. There might 
>>> be something wrong. :(
>>
>> In fact, I send this patch 2019/02/, and get Reviewed-by,  but did not queue
>>
>> https://patchwork.kernel.org/patch/10853973/
>>
>> and resend it 2019/07
>>
>> https://patchwork.kernel.org/patch/11032081/
>>
> 
> Oh, it's really a pit. And in this case, we can get rid of the var r as '-ENOMEM' is actually the only possible outcome here, as
> suggested by Vitaly, which looks like this: https://lkml.org/lkml/2020/1/15/933

I queued your patch again, sorry to both of you.

Paolo


  reply	other threads:[~2020-02-21 16:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20  8:40 linmiaohe
2020-02-21 16:58 ` Paolo Bonzini [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-02-24  2:08 linmiaohe
2020-02-20  8:18 linmiaohe
2020-02-20  7:39 Li RongQing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e77238c5-94a6-0695-b49a-6ce6f4ccab70@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liran.alon@oracle.com \
    --cc=lirongqing@baidu.com \
    --cc=vkuznets@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®