From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755405AbdKNN1u (ORCPT ); Tue, 14 Nov 2017 08:27:50 -0500 Received: from foss.arm.com ([217.140.101.70]:56654 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755212AbdKNN1p (ORCPT ); Tue, 14 Nov 2017 08:27:45 -0500 Subject: Re: [PATCH] arm64: perf: remove duplicated and unsupported events for Cortex-A73 To: Xu YiPing , catalin.marinas@arm.com, mark.rutland@arm.com, will.deacon@arm.com, namhyung@kernel.org, jolsa@redhat.com, alexander.shishkin@linux.intel.com, acme@kernel.org, mingo@redhat.com, peterz@infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1510662479-9550-1-git-send-email-xuyiping@hisilicon.com> <20171114124913.np2rtiyhghxipzzx@ukko.fi.intel.com> From: Julien Thierry Message-ID: Date: Tue, 14 Nov 2017 13:27:41 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171114124913.np2rtiyhghxipzzx@ukko.fi.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 14/11/17 12:49, Alexander Shishkin wrote: > On Tue, Nov 14, 2017 at 08:27:59PM +0800, Xu YiPing wrote: >> bus access read/write events are not supported in A73, and the definition >> is duplicated, so delete it. > > In the changelog, it would be nice to mention the commit that added these: > > 5561b6c5e9813 ("arm64: perf: add support for Cortex-A73") > > Also it's not clear what is this new statement based on. The original > commit at least references a TRM document. > I re-checked the TRM for this core and Xu is right, the BUS_ACCESS events are not available on Cortex-A73. Plus those entries are duplicated, I think something went wrong when I rebased the patch. So I think this new patch is doing the right thing. Thanks for catching that. Cheers, -- Julien Thierry