From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BF253EBF39 for ; Thu, 26 Mar 2026 11:39:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774525205; cv=none; b=dHhaPvP+Fp9LgNraGNna2Si2t7wg2DdH3qE154ielQTxfMq61eTa7htvpTDPfqgqBZkEqKh0z68lCBSLlmI7AP4LXjjLZ843k2xlizf2tokvt/ecA6rK2+SKbIBjf8eE854WM31rYI5YJ8VR4cykhkj9OGYgZawxuLUWfR+BcQs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774525205; c=relaxed/simple; bh=65eoDA5aXZKiN86gCHpFmmdUEmkkKaAXVNwubjRij5I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IusdYzl/UXRivX4J6E4N7+PcTsf9b0YFKcYapha4vIkFczXv6jqHnaXhVpa1vPRy93wqFVyHjQqOQp1xRYEef9CBOyXcJVYRUt3IG2JHKcPHLruUaHMCrxhnrpJILenujiMDdxsB7/cmWARYUYX4eTuUlDAtIthxlPFAdGNPyp8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nY5PlCsU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GJ8NsJfu; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nY5PlCsU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GJ8NsJfu" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62Q6EeGx1965332 for ; Thu, 26 Mar 2026 11:39:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3sX8nCJoTG/mn6XePX6oysvzTyZ/0eyadLiabjS3doA=; b=nY5PlCsU7Q4oc7Gr o6E4xjYB6CqSMJRRVArxY34+zAlEXSBJFsXMXE7DweGbtEoRMFuLsznxS1Kfj1m3 tUlRmhF3jj3tr8xw48rHKRxnnAA6mhtRviSHEy0yM170OR4v5M//S8+Y6LA2L3yA vouAnDsWAc/LZCYJFr5dGDFZiyY8ZOHgu1bscUcszZbFvRqFrfOlygePLKPX3z9Z q4MMNdtlnnEaNS8O609DPVVRokQH3fnnM0P60gYt+ynPXiJbDo1YaynGeO/9HrZ7 GUGpvXVyC4TbY9aIRugD6p7RQpBZhcp2u+sIbXfNlU6jd+A3jYu0dHMJbiG2JS8B cqDaZA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d4pymjmhm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 26 Mar 2026 11:39:57 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50b86b756c4so2948191cf.1 for ; Thu, 26 Mar 2026 04:39:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774525196; x=1775129996; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3sX8nCJoTG/mn6XePX6oysvzTyZ/0eyadLiabjS3doA=; b=GJ8NsJfuumma3A3h75iA+VX5BBaHl6SN3yO7zAQmnOpU1Fh7cRPUe74qBN5i0UPGSP zWjBChpPZ4BCsreQSOddDmzlrLoggkSMxQ9p0KcRMaovLMryJLdOXtcvg+CLEYXah4cP iuuZbKTJkG2Ha8LEH9EHEipO+KbvMMaRgGWfYsC5GETjlfMppecTWVxFUkdT9P/rBBHG cv/4/GoWhgbbgnvduHzpQNgSUd8mDlj54mH8NdbeqA3MLJq3ares9unIjPuanWzUmTTy a74FirzG/UJxcE+F8q4yuwnzR43Y6/1cLrO6YhdcPqo/3onVOmeXcFNENi25kvebB6l1 FWXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774525196; x=1775129996; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3sX8nCJoTG/mn6XePX6oysvzTyZ/0eyadLiabjS3doA=; b=IwLRnXAnQ3WpEMBPNUdqHWZhpactfNdYO++WV1Dse1bCOEPFEO8MAIUBvcRDG8oEzQ nuw+BqrzELB2mB8bkOaY2ip0XOcuAAPAzy+TaZp/xwA0SF1G8pI7GmEqso/kRBEPASeL IWSv1UPZivnrIkZoF2+F9edXvAnOfx4GFm9o+5V1ll2mxAmjD2JhiUuvfIhrwg/obXKL apzFsd7QwSfimj0/3BmUUujpX3WvvFz8Z2wVrozapvcTd0dT0J3IlG1zC5+/qKkXa8xW TqSHFTmW3M2NbeNUWw9P5y2wIZZgc5iTnlcTaojhBEpe0z+gHDn9o+F8azGs440K9JLd 491A== X-Forwarded-Encrypted: i=1; AJvYcCXRdIy7ctGhzC4/Je6KaijUszXWm3EPSuYh5JjcZriameTT+xNHrQWv/1x2jztIC8wGWybjpFkTWcjOyPs=@vger.kernel.org X-Gm-Message-State: AOJu0YyotmwDYBImT092dDAP9SCpOyjf5Wb/ax6w67Rh0SZmJDvYjiM1 rAVrSeCy7DQgZ3JsRs/wlBaUY2Bl0c8gAuVJb/7WzdxDKSSwJV/rdKA+6EmS8e8Hv07WW6TPsCj 2BiFCD4KP055/2w4jgxpXHTuG33wcW+0Y99wfIAYZJVW+c++1yQyPXiFBXPiA6H1549k= X-Gm-Gg: ATEYQzx2eu3CQd004p8f7/ctJKGhOWmqHn8TayPSUMzuydgGYWETfKz1toQOuP+DwO+ zMeeQZHbZJ4iMEjseoS6novWuteD9bDBA25J/6iPMwmia3Z+uwzGHzo3dEwE8FswHlT9hPJYbb4 bybLT34+MkJViXbsqsztMuLDtU1ho6PURFAfeoFbZ6x7Gp1j2JlPZZ4WXgXT9nxfxCO36hugCTd 7itRYvj4r4dqPoHJS+CiUN9c1ZjR7JKc7Fj3BYnv4KAQG9XpZMkj6eo5lB/ORDVH4kR+4sxOhGt 8ihNCXarGJshiYqeNoDGGNGpVLmjvYqiVlnO6AO1/7PrlJlF5zGFt8rhW7OjM+QIg3XpW8C7470 xI7ebaKmPev52qkTun1LfGH28Q5+QumRWxFxCWFVkSP5ohmvjtyThV1tFXiuu+nkeRiR2NYS9ry HjyS0= X-Received: by 2002:a05:622a:4486:b0:509:882:9e7b with SMTP id d75a77b69052e-50b80f10b80mr46079951cf.8.1774525195980; Thu, 26 Mar 2026 04:39:55 -0700 (PDT) X-Received: by 2002:a05:622a:4486:b0:509:882:9e7b with SMTP id d75a77b69052e-50b80f10b80mr46079731cf.8.1774525195353; Thu, 26 Mar 2026 04:39:55 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9b203c2231sm108580566b.38.2026.03.26.04.39.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Mar 2026 04:39:54 -0700 (PDT) Message-ID: Date: Thu, 26 Mar 2026 12:39:52 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sdm845-shift-axolotl: Enable NFC To: David Heidelberg , Konrad Dybcio , Alexander Martinz Cc: Petr Hodina , biemster , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, Rob Herring , oe-linux-nfc@lists.linux.dev, Krzysztof Kozlowski , devicetree@vger.kernel.org, Conor Dooley , linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Bjorn Andersson References: <20260324-oneplus-nfc-v2-0-3eef052c9bc6@ixit.cz> <20260324-oneplus-nfc-v2-2-3eef052c9bc6@ixit.cz> <9d9ec994-c954-445d-97b2-772614d66f35@oss.qualcomm.com> <041766dd-422e-40e1-9e5d-c220580871f5@ixit.cz> <6638c874-8472-4383-bf83-21c5b632e73e@ixit.cz> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <6638c874-8472-4383-bf83-21c5b632e73e@ixit.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: _xd7711vtK69aHzhrfeVS7wmAsbv7Min X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI2MDA4MCBTYWx0ZWRfX3x4iKkf2U5wf VkaEamnarNQrkyfAjCLkUqYW9ZUflNiuS2g5e6PvTze85+bu4yUAXEG2WKogmIIQ78ZjSX8Og1h UIj9FWLgWpbRWhCFBQ6PUdeMAHOyQol0ZbJ+gokFEc2hJLiCjiBm57GN9Kb0ufVq9xup1C+Mv5W nnzp13cEaOPbL1ZxXaS2baIJbZIwvhl8HvV9sWJ9gnVz8MusEZpJU0hKIRdLqbZfEZ+CM9b6CPw CFmYD+MDSYoAg7MU2heogcrrARigx2gaU4tvydIjm7avlIUliInvMnPpmemUDbxEA+XdsFZICv4 F+tgLQ7VKgbn1lStYNFuoEHC5E5pb5dbwOIH2xIKxQIAuH9p19BS8X2+F3AYtET8n+A7bPyqD9Y MeZ1ncuFWgvI/RCwGNWdy1D83jnk94ef1COTxMhE/fL4HsdMNBxNxYNGTnXltqwzDZ0zWP3uJnR znaWPHvYaIqDNRWOErw== X-Authority-Analysis: v=2.4 cv=SvedKfO0 c=1 sm=1 tr=0 ts=69c51b0d cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=-PauhVP_RH9yc3VFBwAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: _xd7711vtK69aHzhrfeVS7wmAsbv7Min X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_02,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603260080 On 3/25/26 9:17 PM, David Heidelberg wrote: > On 25/03/2026 12:20, Konrad Dybcio wrote: >> On 3/24/26 7:08 PM, David Heidelberg wrote: >>> >>> >>> On 24/03/2026 14:12, Konrad Dybcio wrote: >>>> On 3/24/26 12:20 AM, David Heidelberg via B4 Relay wrote: >>>>> From: David Heidelberg >>>>> >>>>> Definition of the NFC. >>>> >>>> "meh" commit message >>>> >>>> [...] >>>> >>>>> +    nfc_enable_default: nfc-enable-default-state { >>>>> +        pins = "gpio12", "gpio62"; >>>>> +        function = "gpio"; >>>>> +        drive-strength = <2>; >>>>> +        bias-pull-up; > >               bias-disable; >>>> >>>> Are you sure about pulling up an active-high pin? >>> >>> I'm not sure, but downstream does it (and "works for me"). Maybe Alexander would know more details here. >> >> Would changing it to bias-disable also "work for you"? > > Yeah, works for me. Should OnePlus 6 do the same? > > Looking at OP6 datasheet, there is no pull-up/down on 12,62,nor IRQ 63. Generally the internal bias would be used to counteract random noise posing as signal, to ensure the line is kept in the "inactive" state when not actively driven I can see that the driver initially requests both to LOW and then sets it to high based on the desired mode in nxp_nci_i2c_set_mode(), so pulling up is perhaps never really desired. Konrad