From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 083A730AACD for ; Thu, 4 Dec 2025 07:55:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764834922; cv=none; b=Dio5s0KwY2HgvGhAuQcupNGHne++aQvyYtWhFid/SOzGWMrP6fDjGFcbDi+RUxSe0tgB3/vUP2X798YYEn467LJ2GUc4mQGREnAwO5gkor5UfSjQdyMT0ErIdGpUQOCg4axRi4LOVS1wtPux6ENHeje69x+tc86epF11wXU5eUE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764834922; c=relaxed/simple; bh=Nr65EzR7vyW922umpMnQt38AWJf6EqfIjLJkIOHxt7U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nBzqdRH2SarpwV79+xydXS/jg0vGZIFLpcjBae3hEj63Z1wXs52kArVXmjX0rgXh8bFUlDMzIHR4BPMMDHJBSGbkVD35PQQMzBvfTMXzkTwGWxRcV2EU6IJME3vaEasPy/UYx8bbAXYfGCohwkNS6Z/aKMk5drAuUQayv8ks08o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=bt85l26Z; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="bt85l26Z" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-477bf34f5f5so4539385e9.0 for ; Wed, 03 Dec 2025 23:55:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1764834918; x=1765439718; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aNqWmaRIUahG7eokd7tz3AyijC2RFWL/z3RSgG90az0=; b=bt85l26Z1r/wQV9J/BA1WaVoAWvU1eh2TxpLFkqAUw/lchMfNdvDmGaVXscyFwiYOm 5ZZGvcCgiPinT5TTe/5kOuJMc7y/LCJcXO8odUTyv+73q/dYyuji18XuM/+NcNlFXNTt 9li6LT/KtTCCv1b8oc4ha/51Z//nUbNbX+lntrNNYb0KrZysrRb/PzZ8ysuAA/HuTh2D a9GNOkWBfE+TDkSr+QPwY74H9cAp2Kj1btgYcrSkcftuXGhK4HcKazdckB00a/Y/2Vov GRvJNWlwv2Pa/QzuCkxajM8MuCjonAZeeDQjwrkhcA+6u2MQc5aEffjTEUBLCEdyNnZX qT7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764834918; x=1765439718; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aNqWmaRIUahG7eokd7tz3AyijC2RFWL/z3RSgG90az0=; b=clWLfQb6jSrdVp+Wl73Q9CUPOZHEVGsKAflqQu7+a2Te2x/5+aUWPTqZISUZL5OEgd 8+kvR/B3YwIh9QmEoL92Ki9L5fDnXT8u4BBtVvC47/MHo04qn+DYhWajYmzaFcSgw3BB h9uEEBtM1Pc28dTDmHOWPzaKPt++u+Ue8EaIxiq5FWviLa1uTrtpZKtHvqUZ687qBFmS f2iHdMfgs+c2pHiNvagtZnPZ5N2145Kj/+NzEdxJIyByaJbplyjLO+EHC3IzQ1zxj1aP /VNaDuSf+TT32ERT46XcstAPiBkKW6+cSvyryJJK0biGzD/KRJ0COIuPF+maUqPUmrTF rxyQ== X-Forwarded-Encrypted: i=1; AJvYcCX3YuR89Ab923fDMzzl/u3fPX7xyjcRhzPRN4V2IXNquOg5MKmmnMiFWjsoRAzqgly6qLAmCwQKWMqauo0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/4jCf+xNVF6xO33x7gXKfOKmm8hKgwtLr/0JZVYeH/9IlPxoE nXQW9B8aGhNhOAGS7ropsBpmmXnj01vHdrju4V9p+XCQGJvJw2lOauB0vbO/xqUDENk= X-Gm-Gg: ASbGncs/60MQ3xDaFJ1BYLFzjXjhGEQL7uJVj8IKnjBXZ210N5eyE1wLctp2tqjzPNm THl//BeTp/O6wetSqpameiGKxh9fxQgqSHxPaUU83fjEIJwlisxsPJag5RNRZ1tBi/U8O/FeP3/ o6IXz4LMIQFrZlOEJ8lqnV2YRz4srbNL5gEzmDygbIiZB2eBZD668Oq3sdAf40nmWkOLZNuSMKs KAZ3sM8YEY93jKzmI3qeqL7UAhsXJR/g//wZ6JBZjUpRYD7vIJF8WYuPobvu7fpPILy4xbhhF5d fO/ikYyL6VxrCNkdKQUCkv+WHKIJlIpeAOnqJAzsufJ7AxvIUhuhaWg0+jjgk7V1bwI/GiLGb8H ygcFakECvNV7XkksdDGdZJ/5PG3KDuNeXtsd/Pf7Sd2cy80OJ2T075XsTkZdamG7b37pagqDnsl CW6YBi8Ud/aFF7hd6K0/EEMIODkGqEjX5g4/ncRC3aQ3//CRW6 X-Google-Smtp-Source: AGHT+IE3fLkRdBTP31CtaOocc2Iq10kuLI2Dan4rlMES+LVg28qoLNgDZsK5s8Q1I964TqWRpM6IbQ== X-Received: by 2002:a05:600c:b8d:b0:477:6d96:b3e5 with SMTP id 5b1f17b1804b1-4792f244cdamr17960795e9.7.1764834918243; Wed, 03 Dec 2025 23:55:18 -0800 (PST) Received: from ?IPV6:2001:a61:2bb0:d301:fe89:8fc1:2b97:d5b8? ([2001:a61:2bb0:d301:fe89:8fc1:2b97:d5b8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4792b05ce9bsm32850545e9.8.2025.12.03.23.55.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Dec 2025 23:55:17 -0800 (PST) Message-ID: Date: Thu, 4 Dec 2025 08:55:16 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/1] scsi: core: Fix error handler encryption support To: Bart Van Assche , Christoph Hellwig , Po-Wen Kao Cc: "James E.J. Bottomley" , "Martin K. Petersen" , "open list:SCSI SUBSYSTEM" , open list References: <20251203073310.2248956-1-powenkao@google.com> <34848777-b370-4a63-8b08-c3246d214167@suse.com> <88900700-7f37-4c3e-878e-cf5f68f006cc@acm.org> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <88900700-7f37-4c3e-878e-cf5f68f006cc@acm.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/3/25 16:55, Bart Van Assche wrote: > On 12/2/25 10:42 PM, Hannes Reinecke wrote: >> There had been an intersection with the reserved command stuff, but >> now that Bart has dusted things off there I guess I should give it >> another go. > > Does that patch series perhaps involve allocating a reserved command > from inside the SCSI error handler? Won't that break SCSI LLDs that > restrict the queue depth to one? I think that the following SCSI LLDs > only support one command (.can_queue = 1): reserved commands are only implemented for adapters which require an LLD specific 'tag' to send TMFs (eg fnic, aacraid, or hpsa). Most HBAs (especially the older ones) are not that elaborate, and there TMFs are not commands per se but rather operations on the HBA. EG fdomain host_reset is just settings some bits in some registers, no command allocation needed at all. So for those we don't need to allocate _any_ commands for TMFs, consequently we don't need to implement reserved commands and hence TMFs are not guarded by .can_queue at all. > * drivers/scsi/fdomain.c > * drivers/scsi/mac53c94.c > * drivers/scsi/ppa.c > * drivers/scsi/imm.c > * drivers/scsi/aha152x.c > Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.com +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich