From: Stefan Schweizer <sschweizer@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] Fix for ALSA AC'97 Init not working in post 2.6.7 mm-kernels
Date: Wed, 11 Aug 2004 20:16:44 +0200 [thread overview]
Message-ID: <e7963922040811111655dc228e@mail.gmail.com> (raw)
Hi,
I noticed that my soundcad stopped working in the mm-kernels after 2.6.7.
The kernel log produces this message:
AC'97 0 does not respond - RESET
I grepped for it in the mm-patch and reverted the mm-changes there,
that fixed it for me.
I do not know what the change in the code is useful for but it breaks
my soundcard
Intel Corp. 82801BA/BAM AC'97 Audio (rev 05)
driver snd-intel8x0
My Revert-fix-patch:
--- linux-2.6.8-rc4-mm1/sound/pci/ac97/ac97_codec.c.orig
2004-08-11 20:07:12.359531728 +0200
+++ linux-2.6.8-rc4-mm1/sound/pci/ac97/ac97_codec.c 2004-08-11
20:07:24.743649056 +0200
@@ -1891,14 +1891,8 @@
bus->ops->wait(ac97);
else {
udelay(50);
- if (ac97->scaps & AC97_SCAP_SKIP_AUDIO)
- err = ac97_reset_wait(ac97, HZ/2, 1);
- else {
- err = ac97_reset_wait(ac97, HZ/2, 0);
- if (err < 0)
- err = ac97_reset_wait(ac97, 0, 1);
- }
- if (err < 0) {
+ if (ac97_reset_wait(ac97, HZ/2, 0) < 0 &&
+ ac97_reset_wait(ac97, HZ/2, 1) < 0) {
snd_printk(KERN_WARNING "AC'97 %d does not
respond - RESET\n", ac97->num);
/* proceed anyway - it's often non-critical */
}
next reply other threads:[~2004-08-11 18:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-11 18:16 Stefan Schweizer [this message]
2004-08-11 18:42 ` Jaroslav Kysela
[not found] ` <e796392204081112164423ea96@mail.gmail.com>
2004-08-11 19:16 ` Stefan Schweizer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7963922040811111655dc228e@mail.gmail.com \
--to=sschweizer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®