From: Yunlong Song <yunlong.song@huawei.com>
To: <jaegeuk@kernel.org>, <chao@kernel.org>, <yuchao0@huawei.com>,
<yunlong.song@icloud.com>
Cc: <miaoxie@huawei.com>, <bintian.wang@huawei.com>,
<linux-fsdevel@vger.kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] f2fs: collect prefree segments to avoild write checkpoint fail
Date: Tue, 31 Oct 2017 09:33:54 +0800 [thread overview]
Message-ID: <e7966d00-c63c-060b-2b1d-c9a9cb134b3b@huawei.com> (raw)
In-Reply-To: <1504267219-76575-1-git-send-email-yunlong.song@huawei.com>
ping...
On 2017/9/1 20:00, Yunlong Song wrote:
> In come corner case, the reserved segments are used to do gc, and there are
> not enough free segments for write checkpoint to finish its job, then the
> gc process will fail to change the prefree segments to free segments.
>
> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
> ---
> fs/f2fs/gc.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index cd147e7..6552b04 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -1056,6 +1056,16 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync,
> if (!sync) {
> if (has_not_enough_free_secs(sbi, sec_freed, 0)) {
> segno = NULL_SEGNO;
> +#ifndef CONFIG_F2FS_CHECK_FS
> + if (prefree_segments(sbi) &&
> + has_not_enough_free_secs(sbi,
> + reserved_sections(sbi), 0)) {
> + ret = write_checkpoint(sbi, &cpc);
> + if (ret)
> + goto stop;
> + sec_freed = 0;
> + }
> +#endif
> goto gc_more;
> }
>
--
Thanks,
Yunlong Song
next prev parent reply other threads:[~2017-10-31 1:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-26 11:46 [PATCH] " Yunlong Song
2017-08-28 9:52 ` Chao Yu
2017-09-01 12:00 ` [PATCH v2] " Yunlong Song
2017-10-31 1:33 ` Yunlong Song [this message]
2017-10-31 1:59 ` Chao Yu
2017-10-31 2:05 ` Yunlong Song
2017-10-31 2:56 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7966d00-c63c-060b-2b1d-c9a9cb134b3b@huawei.com \
--to=yunlong.song@huawei.com \
--cc=bintian.wang@huawei.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=yuchao0@huawei.com \
--cc=yunlong.song@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®