From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 779BDC67790 for ; Fri, 27 Jul 2018 14:14:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 37D05208AC for ; Fri, 27 Jul 2018 14:14:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37D05208AC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amlogic.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388554AbeG0Pgm (ORCPT ); Fri, 27 Jul 2018 11:36:42 -0400 Received: from mail-sh2.amlogic.com ([58.32.228.45]:45949 "EHLO mail-sh2.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730395AbeG0Pgm (ORCPT ); Fri, 27 Jul 2018 11:36:42 -0400 Received: from [192.168.90.67] (61.170.236.39) by mail-sh2.amlogic.com (10.18.11.6) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Fri, 27 Jul 2018 22:14:38 +0800 Subject: Re: [PATCH v3 1/2] clk: meson: add DT documentation for emmc clock controller To: Rob Herring References: <20180712211244.11428-1-yixun.lan@amlogic.com> <20180712211244.11428-2-yixun.lan@amlogic.com> <20180724232917.GA27041@rob-hp-laptop> CC: , Jerome Brunet , Neil Armstrong , Kevin Hilman , Carlo Caione , Michael Turquette , Stephen Boyd , Miquel Raynal , Boris Brezillon , Martin Blumenstingl , Liang Yang , Qiufang Dai , Jian Hu , , , , , From: Yixun Lan Message-ID: Date: Fri, 27 Jul 2018 22:14:28 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20180724232917.GA27041@rob-hp-laptop> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [61.170.236.39] X-ClientProxiedBy: mail-sh2.amlogic.com (10.18.11.6) To mail-sh2.amlogic.com (10.18.11.6) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org HI Rob On 07/25/2018 07:29 AM, Rob Herring wrote: > On Thu, Jul 12, 2018 at 09:12:43PM +0000, Yixun Lan wrote: >> Document the MMC sub clock controller driver, the potential consumer >> of this driver is MMC or NAND. Also add three clock bindings IDs which >> provided by this driver. >> >> Signed-off-by: Yixun Lan >> --- >> .../bindings/clock/amlogic,mmc-clkc.txt | 31 +++++++++++++++++++ >> .../clock/amlogic,meson-mmc-clkc.h | 16 ++++++++++ >> 2 files changed, 47 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt >> create mode 100644 include/dt-bindings/clock/amlogic,meson-mmc-clkc.h > > Reviewed-by: Rob Herring > Thanks for the review! There is a discussion about dropping "meson-" prefix in the compatible string[1] So, I will send another version with the new compatible name adjusted from "amlogic,meson-axg-mmc-clkc" to "amlogic,axg-mmc-clkc".. probably also rename the dt-bindings header file to amlogc,mmc-clkc.h [1] https://lkml.kernel.org/r/7hk1prmg4w.fsf@baylibre.com Yixun