From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753366AbdIDIRK (ORCPT ); Mon, 4 Sep 2017 04:17:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:51132 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753303AbdIDIRJ (ORCPT ); Mon, 4 Sep 2017 04:17:09 -0400 Subject: Re: [PATCH 1/1] x86/xen: fix section of xen_init_time_ops() in header To: Nicolas Iooss , Boris Ostrovsky Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20170903083857.1336-1-nicolas.iooss_linux@m4x.org> From: Juergen Gross Message-ID: Date: Mon, 4 Sep 2017 10:17:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170903083857.1336-1-nicolas.iooss_linux@m4x.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/09/17 10:38, Nicolas Iooss wrote: > Commit d162809f85b4 ("xen/x86: Do not call xen_init_time_ops() until > shared_info is initialized") moved xen_init_time_ops() from __init to > __ref without updating xen-ops.h accordingly. Fix this. > > Fixes: d162809f85b4 ("xen/x86: Do not call xen_init_time_ops() until > shared_info is initialized") > Signed-off-by: Nicolas Iooss > --- > arch/x86/xen/xen-ops.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/xen/xen-ops.h b/arch/x86/xen/xen-ops.h > index 0d5004477db6..b2a5d48a2c2a 100644 > --- a/arch/x86/xen/xen-ops.h > +++ b/arch/x86/xen/xen-ops.h > @@ -69,7 +69,7 @@ void xen_setup_runstate_info(int cpu); > void xen_teardown_timer(int cpu); > u64 xen_clocksource_read(void); > void xen_setup_cpu_clockevents(void); > -void __init xen_init_time_ops(void); > +void __ref xen_init_time_ops(void); > void __init xen_hvm_init_time_ops(void); When correcting this could you please modify the prototypes to comply to the intended form as noted in include/linux/init.h (the __ref or __init annotations should be just before the ending semicolon)? Juergen