Re: [PATCH 1/2] jiffies: Define secs_to_jiffies()

[Easwar Hariharan <eahariha@linux.microsoft.com>]

On 10/23/2024 5:36 AM, Anna-Maria Behnsen wrote:
> Easwar Hariharan <eahariha@linux.microsoft.com> writes:
> 
>> There are ~500 usages of msecs_to_jiffies() that either use a multiplier
>> value of 1000 or equivalently MSEC_PER_SEC. Define secs_to_jiffies() to
>> allow such code to be less clunky.
> 
> Can you please provide a proper cover letter for a series (also if it is
> a series with only 2 patches)?

Yes, apologies, this isn't my usual mode of operations.

> 
> Regarding your commit message: secs_to_jiffies() is defined in hci_event
> and cannot be reused by other callsites and this is why it's valuable to
> move it into core code. Especially because there are ~500 users which do
> the multiplier thing and there are also several users which use (secs *
> HZ).
> 
> What do you think about converting the other users e.g. using
> Coccinelle?
> 

I intended to follow up this series with such. I'm not super familiar
with Coccinelle and am occupied by commercial work, so that may take longer.

>> Suggested-by: Michael Kelley <mhklinux@outlook.com>
>> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>
>> ---
>>  include/linux/jiffies.h   | 2 ++
>>  net/bluetooth/hci_event.c | 2 --
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h
>> index 1220f0fbe5bf..50dba516fd2f 100644
>> --- a/include/linux/jiffies.h
>> +++ b/include/linux/jiffies.h
>> @@ -526,6 +526,8 @@ static __always_inline unsigned long msecs_to_jiffies(const unsigned int m)
>>  	}
>>  }
>>  
>> +#define secs_to_jiffies(_secs) msecs_to_jiffies((_secs) * MSEC_PER_SEC)
>> +
> 
> Why not only doing
> 
> #define secs_to_jiffies(s) (s * HZ)

Yes, fair enough, I can change accordingly.

Thanks,
Easwar