From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96D1D30AD0A for ; Mon, 6 Apr 2026 16:14:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775492078; cv=none; b=Zpu0bnNKXzbS/RkDUwpU05sFU+8rXNxIlx8g+5c21pR7fMxUU1eCDWCL7U0Tr3adBTYlTxxgmjbd+6mDuW79V0Z4yt6UV8ZLDgAbS6oIgOcjLzQTR5ar0JIT/MshZhx7X7+JcKauSRTy53pNDvQ4+2vj2RrQ/78nfMmGGb9myyE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775492078; c=relaxed/simple; bh=18E6fSs0FEgBgnzqYyrmUYLs0X/3n6wGNsTR2UGdEm0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XUD5PHhUE6y6FSsQMqQZ4Qzao8YhZaJ/ayQ93FZA2EgBLhKqdzql2puvYgsenWRka1mfuDq4MD2e/G0a8IKIb2Ud/hQHB3ir/QosNdXHfRqxvsA4BLhP/sE5TAD9q2FRvQ5egAEN1+EdQ6o0czLVJW02sCLOYX7NA+Z18SWBmtk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=gd9VQ6wv; arc=none smtp.client-ip=209.85.167.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="gd9VQ6wv" Received: by mail-oi1-f182.google.com with SMTP id 5614622812f47-470145d7df5so1630848b6e.0 for ; Mon, 06 Apr 2026 09:14:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1775492074; x=1776096874; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ung52b5S8P+Lmm+irkc4wPnYl9jZuN15tG6M+cbGeg0=; b=gd9VQ6wvmt02UKVjta7xktvbf12UOEbaQcb24u5KyV94RhdknhxlxMlwQhlAVTpMur LwbkOOWQyORldmcKSaCdSZFsJDRAOXdF+e2WD4sMuP6Ec7i6MKXIyS8UHrkf5nWDKw+g tSuGbpZ6yjTJHbURBptjBlXfVH56OzEbrsiMGq+nmKUTV75MiYg3tAb/L6QC/sn1Qtf0 hdbtd1peP/0NiYc9PXWYKeE6TXuWtPqWKuW36yYfq0HV33Cw8C4nVsuQVTSnew3opfcu JIhsk4K38M/i0s6Qo2IQVdAXI5yVYorOYmls4m0wvXKfpwQb3dxx/aQWw3jdpHg+XJ0x 6xWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775492074; x=1776096874; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ung52b5S8P+Lmm+irkc4wPnYl9jZuN15tG6M+cbGeg0=; b=rlmLn7WFV2LB7wwIQyW91jbdVntQg56zv13G+YInug3TNxI+QbjtH4goYp3kJnqjcO WoBleKtqPI4DFuGp0QVVyR13ApwXUrZnzlptJxlPQlOt4Rfmp74dBMRkTYJPVg6JmpT2 MLf6HGU24R3k/lKmT5gkMmRT+tswHFEA1zKtJbwLgneITI+kAXcLrpyt2ImX0I0CFtE9 pK9Ai6fwfhZwLsxVEbgLQznzrXGIpMc9kFGxOZ9WKAQ0hOnmMaVRYhzgKpVr923nOzhe Yoo+iRDjqtWCRdykbj5UNPodZ2MZX9am8d5B6izAcJlfWJHyvP9IaOOGaArclpMYwyfW zY3A== X-Forwarded-Encrypted: i=1; AJvYcCXSaZiU6wwjjj21znamiCDn2Hr0VSkf6b+tW/TkIyIf1PoWnbKrRfB0Z/WcvC6bS7O6H8XKyOA9PdoTfUI=@vger.kernel.org X-Gm-Message-State: AOJu0YzOeNdtxJyhfyJ7qYgv3r0zykz9QaFy94dtEtLfA+haVRIi3yOw zhiTwG54m589JodsWECdFD4cqzDHfYBRoOisvyxGx/YomqUNtd79ZrolZdC2gpicFaI= X-Gm-Gg: AeBDieuAjWLPYv46dzqRRibdQFt0JtiJtkAX6pUN09IqkoeDnJgNCmpz+xg5aHdKm5z g6EYmBzd0vMckaZTznblPIljRSzI1xhNUjmBh5shPZ/khVDgwUry8JNHm9/Bz7Qq1fg1oNcS1WM FmvmLFmvjNGe9gkxbidbigLi5RPvrnIgtYB5uZQ67eaG7DI+ReYR+WL8PyN04es+akLji9vw+oX LMCnreZe9/u38pTgppgAz+wGxgDmuyvJnlLsvNuSQ6544DWFO64KJf7dEUIi1UOO3nVpL5WBz3y ms1XVYAeahko137gXq6NlKETjdzNHE+2I5b+EereWhBUeRGjpVJECZCjaZwuaB0U9KTfx46hPP9 VKK9ZAis9przGZE3zO0Co078CAzdf99iQnIS3KvEStqmiu6bikQ9o+pVMtzzvMjuR77v2E6jyOP 0YSOdtGBZRSAnWqj7BeUFT59X8BjOF0k4IENy4e+LXulKuN8t48Pq2jKhzpQIRD1y+VXhKUu4= X-Received: by 2002:a05:6808:c1e9:b0:467:27d2:96a7 with SMTP id 5614622812f47-46ef904d90cmr6699038b6e.15.1775492074540; Mon, 06 Apr 2026 09:14:34 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:90d7:b13f:c53:8ca3? ([2600:8803:e7e4:500:90d7:b13f:c53:8ca3]) by smtp.gmail.com with ESMTPSA id 5614622812f47-46ff2f94b71sm5445356b6e.5.2026.04.06.09.14.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Apr 2026 09:14:34 -0700 (PDT) Message-ID: Date: Mon, 6 Apr 2026 11:14:33 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 4/5] iio: ssp_sensors: use devm APIs for mutex and IRQ resources To: Sanjay Chitroda , jic23@kernel.org, nuno.sa@analog.com, andy@kernel.org Cc: kees@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260406080852.2727453-1-sanjayembedded@gmail.com> <20260406080852.2727453-5-sanjayembedded@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260406080852.2727453-5-sanjayembedded@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/6/26 3:08 AM, Sanjay Chitroda wrote: > From: Sanjay Chitroda > > Convert mutex initialization and IRQ registration to use devm-managed > helpers, tying their lifetime to the device. > > This removes the need for explicit cleanup in the error and remove > paths, as the resources are automatically released on probe failure > or device unbind. > > Signed-off-by: Sanjay Chitroda > --- > drivers/iio/common/ssp_sensors/ssp_dev.c | 36 +++++++++++------------- > 1 file changed, 17 insertions(+), 19 deletions(-) > > diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c > index da09c9f3ceb6..f4fc869fc770 100644 > --- a/drivers/iio/common/ssp_sensors/ssp_dev.c > +++ b/drivers/iio/common/ssp_sensors/ssp_dev.c > @@ -510,7 +510,11 @@ static int ssp_probe(struct spi_device *spi) > data->spi = spi; > spi_set_drvdata(spi, data); > > - mutex_init(&data->comm_lock); > + ret = devm_mutex_init(&spi->dev, &data->comm_lock); > + if (ret < 0) { > + dev_err(&spi->dev, "Failed to init comm_lock mutex\n"); > + goto err_setup_spi; > + } > > for (i = 0; i < SSP_SENSOR_MAX; ++i) { > data->delay_buf[i] = SSP_DEFAULT_POLLING_DELAY; > @@ -523,7 +527,11 @@ static int ssp_probe(struct spi_device *spi) > > data->time_syncing = true; > > - mutex_init(&data->pending_lock); > + ret = devm_mutex_init(&spi->dev, &data->pending_lock); > + if (ret < 0) { > + dev_err(&spi->dev, "Failed to init pending_lock mutex\n"); > + goto err_setup_spi; > + } > INIT_LIST_HEAD(&data->pending_list); > > atomic_set(&data->enable_refcount, 0); > @@ -533,13 +541,13 @@ static int ssp_probe(struct spi_device *spi) > > timer_setup(&data->wdt_timer, ssp_wdt_timer_func, 0); > > - ret = request_threaded_irq(data->spi->irq, NULL, > - ssp_irq_thread_fn, > - IRQF_TRIGGER_FALLING | IRQF_ONESHOT, > - "SSP_Int", data); > + ret = devm_request_threaded_irq(&spi->dev, data->spi->irq, NULL, > + ssp_irq_thread_fn, > + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, > + "SSP_Int", data); > if (ret < 0) { > dev_err(&spi->dev, "Irq request fail\n"); > - goto err_setup_irq; > + goto err_setup_spi; > } > > /* Let's start with enabled one so irq balance could be ok */ > @@ -553,21 +561,16 @@ static int ssp_probe(struct spi_device *spi) > ret = ssp_initialize_mcu(data); > if (ret < 0) { > dev_err(&spi->dev, "Initialize_mcu failed\n"); > - goto err_read_reg; > + goto err_setup_spi; > } > } else { > dev_err(&spi->dev, "Firmware version not supported\n"); > ret = -EPERM; > - goto err_read_reg; > + goto err_setup_spi; > } > > return 0; > > -err_read_reg: > - free_irq(data->spi->irq, data); > -err_setup_irq: > - mutex_destroy(&data->pending_lock); > - mutex_destroy(&data->comm_lock); > err_setup_spi: > mfd_remove_devices(&spi->dev); > > @@ -589,14 +592,9 @@ static void ssp_remove(struct spi_device *spi) > > ssp_clean_pending_list(data); > > - free_irq(data->spi->irq, data); Do we need to replace this with an irq_disable() so make sure no more timers/work is scheduled after we delete them below? If it is safe the way it is, add an explanation to the commit message. Alternative would be to use devm_add_action_or_reset() to handle all of the other cleanup functions in the correct order still and get rid of the remove function entirely. > - > timer_delete_sync(&data->wdt_timer); > cancel_work_sync(&data->work_wdt); > > - mutex_destroy(&data->comm_lock); > - mutex_destroy(&data->pending_lock); > - > mfd_remove_devices(&spi->dev); > } >