From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4090F2D23A9 for ; Tue, 9 Sep 2025 10:09:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757412597; cv=none; b=fUn18FXhf2LWv+GlWCRn5fZC4KxhTNyU7xyl9kKPqRzuyoijFrMqg9Ik3nqfpcWYNVzVJ3JGGZ+4TaZUnvAz/5gn+5EYaEZSahBtPqcNLX8E1bzyGTyLeii9vYlK9xZ6TDgZP3xV4xGNgZNzYk0s/saLcJ4tf4n3dgslmHi9tmQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757412597; c=relaxed/simple; bh=A/DNmPamxtdjaA8E0kvZI/oJGheRH/RzPWVdeP04pLc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fwhSxFrA75kFRUBMhXcYgZSb4zluMQIC3ipwVZoVoe6QeTJ01AeTGgMsqD50F7xRFlU+8gSucJ9YooBhDWDD1OX61RTncMH0VmVIjsUrwWt72WTXI/7QlfUsDmW1UXor/zN05ze9VUnECiWmpB4XzbRoCu2E20h4y3Xpt2izqqM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EIH2P8zI; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EIH2P8zI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757412594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LqU+WGzmfGncFG5qyai0jHYVSP7TCxKOV9AhHT2zCnc=; b=EIH2P8zIcZYkDaCMrxLDGWHfPHP777hlvuk4rjzrd3EWHy82xAVFawnQA0eQ11KfPTUQIw mfMilZyTB/IPyohu6Inx1nvoomsXwhxl1TwV8jO+qcFWtUu16n9q54WBAzd+YUCW37T5WO MDo4/NDu6ELr7/8Lah8RGtOioePKBS0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-106-5XApV-m8M3mB0kew_Z5gVA-1; Tue, 09 Sep 2025 06:09:53 -0400 X-MC-Unique: 5XApV-m8M3mB0kew_Z5gVA-1 X-Mimecast-MFC-AGG-ID: 5XApV-m8M3mB0kew_Z5gVA_1757412592 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3e403b84456so2723060f8f.0 for ; Tue, 09 Sep 2025 03:09:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757412592; x=1758017392; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LqU+WGzmfGncFG5qyai0jHYVSP7TCxKOV9AhHT2zCnc=; b=IRTIfu1PBfKovvtvw6FTrfbXnOskXWW3lRf2Py6TV5asmz8bnT1DKU1qUDtCYs9rOP /DsBdH7gVNpvGoCTxMxOCzkhrAN4nbJ/YHvLzOikG/opUz54kzrpMAkJH8LkLaf1XZ99 QAkiv5BpDFA6zszbjNhtiZ6jdHscYjK3OCsIU+8XKMcb2qT/j533jaPh9GTV7CTvyf78 8Xi8icN1KIy5/fisJwOvi3NTB57jBucJewLkWusjfulPX/evuUg9MRY1HbaiKQJDYoV2 CpTXbnmaoLWG/kbtMQY+MTLSAGyd4DK4TGzAv48oG9mdvQVqLy5phBWToUfN9IxgFH3m 0fpQ== X-Forwarded-Encrypted: i=1; AJvYcCXXvZ6kqNo9Sb57ydNwMkWkr4cVjOrs6yRMwUl7Qz2GfeJxTwM+s+AvAoHTAwlUKoOUZx7X0guKLgFgGec=@vger.kernel.org X-Gm-Message-State: AOJu0YzHRTN+GXvPcSv9/JhVpTduh66Jtxl43BwS1izMzolWCm1ZfGqL 2daz5chB11SqV50XJsmfjde2Ygr8Q6g7l0atMyUJ6oC09j5KYZLcezku7UvGxyZZyxTZrbMdmU4 X38vbs3TNS7kjH1+2R1/+cZ8ZUAJrjcoQ142dZQ+3iwK5IdC2d5rlmZRWVS8p+rlrOw== X-Gm-Gg: ASbGncsHS1kpY5sGtnpcix6YnArLtdFWikJ5loHC63oKtx/MaRNZQ8ehDM96ILyUK8s bEGm9qjU2wbCjcQJrgSanc5thxw709Izkjk8HYQ2cFnh6Fkj6go8O8HLgVkKFRv7euSzB2+5DIl Pf34dPpIf92sE/28nGo3ZWtqljbU9ageXGJ8XXxkszbZdRtUZMPKYvUBzke/HeuafbkHbQ6EUR4 voPM+aaXIC4bn5dkztVN6ErzEDeEC7uuYdMnzVRnVRYI9ZYSh02ARMzlE5jZ7BbxaU/kKeOPPmR T4IZNLRvJ5kk/w4RlVX3d5UTvG4wJW6D9CD8DuKtuuaCoQA5q92bzIKbaMVuIeaz34QIDAzEcMa QKKl0gXkpM5sHo6OE6ArzF/FrIhNH1wRMFSSO5KHLyiwRDn5a99jOsddr6jZCZb6+kWs= X-Received: by 2002:adf:8b1b:0:b0:3e6:b06c:5b2b with SMTP id ffacd0b85a97d-3e6b06c5fe0mr6424799f8f.10.1757412591664; Tue, 09 Sep 2025 03:09:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE+6kYqxQMhMlrUNgHhh5IEpwCukAjnB2iBRVYizcIa9qqydeyLJ0L3jlngBNKljI3RpH7CHw== X-Received: by 2002:adf:8b1b:0:b0:3e6:b06c:5b2b with SMTP id ffacd0b85a97d-3e6b06c5fe0mr6424776f8f.10.1757412591141; Tue, 09 Sep 2025 03:09:51 -0700 (PDT) Received: from ?IPV6:2003:d8:2f23:9c00:d1f6:f7fe:8f14:7e34? (p200300d82f239c00d1f6f7fe8f147e34.dip0.t-ipconnect.de. [2003:d8:2f23:9c00:d1f6:f7fe:8f14:7e34]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e7522562d1sm1945921f8f.63.2025.09.09.03.09.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Sep 2025 03:09:50 -0700 (PDT) Message-ID: Date: Tue, 9 Sep 2025 12:09:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/7] mm: introduce local state for lazy_mmu sections To: Alexander Gordeev Cc: Kevin Brodsky , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andreas Larsson , Andrew Morton , Boris Ostrovsky , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dave Hansen , "David S. Miller" , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Juergen Gross , "Liam R. Howlett" , Lorenzo Stoakes , Madhavan Srinivasan , Michael Ellerman , Michal Hocko , Mike Rapoport , Nicholas Piggin , Peter Zijlstra , Ryan Roberts , Suren Baghdasaryan , Thomas Gleixner , Vlastimil Babka , Will Deacon , Yeoreum Yun , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org References: <20250908073931.4159362-1-kevin.brodsky@arm.com> <20250908073931.4159362-3-kevin.brodsky@arm.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09.09.25 11:40, Alexander Gordeev wrote: > On Tue, Sep 09, 2025 at 11:07:36AM +0200, David Hildenbrand wrote: >> On 08.09.25 09:39, Kevin Brodsky wrote: >>> arch_{enter,leave}_lazy_mmu_mode() currently have a stateless API >>> (taking and returning no value). This is proving problematic in >>> situations where leave() needs to restore some context back to its >>> original state (before enter() was called). In particular, this >>> makes it difficult to support the nesting of lazy_mmu sections - >>> leave() does not know whether the matching enter() call occurred >>> while lazy_mmu was already enabled, and whether to disable it or >>> not. >>> >>> This patch gives all architectures the chance to store local state >>> while inside a lazy_mmu section by making enter() return some value, >>> storing it in a local variable, and having leave() take that value. >>> That value is typed lazy_mmu_state_t - each architecture defining >>> __HAVE_ARCH_ENTER_LAZY_MMU_MODE is free to define it as it sees fit. >>> For now we define it as int everywhere, which is sufficient to >>> support nesting. > ... >>> { >>> + lazy_mmu_state_t lazy_mmu_state; >>> ... >>> - arch_enter_lazy_mmu_mode(); >>> + lazy_mmu_state = arch_enter_lazy_mmu_mode(); >>> ... >>> - arch_leave_lazy_mmu_mode(); >>> + arch_leave_lazy_mmu_mode(lazy_mmu_state); >>> ... >>> } >>> >>> * In a few cases (e.g. xen_flush_lazy_mmu()), a function knows that >>> lazy_mmu is already enabled, and it temporarily disables it by >>> calling leave() and then enter() again. Here we want to ensure >>> that any operation between the leave() and enter() calls is >>> completed immediately; for that reason we pass LAZY_MMU_DEFAULT to >>> leave() to fully disable lazy_mmu. enter() will then re-enable it >>> - this achieves the expected behaviour, whether nesting occurred >>> before that function was called or not. >>> >>> Note: it is difficult to provide a default definition of >>> lazy_mmu_state_t for architectures implementing lazy_mmu, because >>> that definition would need to be available in >>> arch/x86/include/asm/paravirt_types.h and adding a new generic >>> #include there is very tricky due to the existing header soup. >> >> Yeah, I was wondering about exactly that. >> >> In particular because LAZY_MMU_DEFAULT etc resides somewehere compeltely >> different. >> >> Which raises the question: is using a new type really of any benefit here? >> >> Can't we just use an "enum lazy_mmu_state" and call it a day? > > I could envision something completely different for this type on s390, > e.g. a pointer to a per-cpu structure. So I would really ask to stick > with the current approach. Would that integrate well with LAZY_MMU_DEFAULT etc? -- Cheers David / dhildenb