From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 474CFC33CAF for ; Mon, 20 Jan 2020 02:38:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 23D2120678 for ; Mon, 20 Jan 2020 02:38:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729078AbgATCin (ORCPT ); Sun, 19 Jan 2020 21:38:43 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:56460 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728874AbgATCin (ORCPT ); Sun, 19 Jan 2020 21:38:43 -0500 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 46703BD5F194AA73C08D; Mon, 20 Jan 2020 10:38:41 +0800 (CST) Received: from [127.0.0.1] (10.177.131.64) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.439.0; Mon, 20 Jan 2020 10:38:31 +0800 Subject: Re: [PATCH -next] net: hns3: replace snprintf with scnprintf in hns3_update_strings To: tanhuazhong , , , References: <20200119124053.30262-1-chenzhou10@huawei.com> <3762cced-2a4a-7d54-787f-751c6fde2148@huawei.com> CC: , From: Chen Zhou Message-ID: Date: Mon, 20 Jan 2020 10:38:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <3762cced-2a4a-7d54-787f-751c6fde2148@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.131.64] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/1/20 9:27, tanhuazhong wrote: > > > On 2020/1/19 20:40, Chen Zhou wrote: >> snprintf returns the number of bytes that would be written, which may be >> greater than the the actual length to be written. Here use extra code to >> handle this. >> >> scnprintf returns the number of bytes that was actually written, just use >> scnprintf to simplify the code. >> >> Signed-off-by: Chen Zhou >> --- >> drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c >> index 6e0212b..fa01888 100644 >> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c >> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c >> @@ -423,9 +423,8 @@ static void *hns3_update_strings(u8 *data, const struct hns3_stats *stats, >> data[ETH_GSTRING_LEN - 1] = '\0'; >> /* first, prepend the prefix string */ >> - n1 = snprintf(data, MAX_PREFIX_SIZE, "%s%d_", >> + n1 = scnprintf(data, MAX_PREFIX_SIZE, "%s%d_", >> prefix, i); > > not align? Ok, I will fix it in next version. Thanks, Chen Zhou > >> - n1 = min_t(uint, n1, MAX_PREFIX_SIZE - 1); >> size_left = (ETH_GSTRING_LEN - 1) - n1; >> /* now, concatenate the stats string to it */ >> > > > . >