mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Gordeev <agordeev@linux.ibm.com>
To: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
Cc: Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	David Hildenbrand <david@kernel.org>,
	Sven Schnelle <svens@linux.ibm.com>,
	Vlastimil Babka <vbabka@kernel.org>,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH v2 00/14] s390/sclp: replace page allocator calls with k[mz]alloc()
Date: Thu, 19 Nov 2026 20:54:48 +0100	[thread overview]
Message-ID: <e7aece4e-7dc5-455b-a631-721ab99e2546-agordeev@linux.ibm.com> (raw)
In-Reply-To: <20261117-s390-sclp-ready-v2-0-e518c99622c6@kernel.org>

On Tue, Nov 17, 2026 at 03:06:52PM +0200, Mike Rapoport (Microsoft) wrote:
> This the next episode of conversion of page allocator calls to kmalloc
> family :)
> 
> This series covers SCLP buffer allocations.
> 
> = tl;dr cover letter copied from the previous posts:
> 
> This is a (small) part of larger work of replacing page allocator calls
> with kmalloc.
> 
> My initial intention a few month ago was to remove ugly casts [1], but then
> willy pointed out that Linus objected to something like this [2] and it
> looks like more than a decade old technical debt.
> 
> Largely, anything that doesn't need struct page (or a memdesc in the
> future) should just use kmalloc() or kvmalloc() to allocate memory.
> kmalloc() guarantees alignment, physical contiguity and working
> virt_to_phys() and beside nicer API that returns void * on alloc and
> doesn't require to know the allocation size on free, kmalloc() provides
> better debugging capabilities than page allocator.
> 
> Another thing is that touching these allocation sites gives the reviewers
> opportunity to see if a PAGE_SIZE buffer is actually needed or maybe
> another size is appropriate.
> 
> For larger allocations that don't need physically contiguous memory
> kvmalloc() can be a better option that __get_free_pages() because under
> memory pressure it's is easier to allocate several order-0 pages than a
> physically contiguous chunk with the same number of pages.
> 
> And last, but not least, removing needless calls to page allocator should
> help with memdesc (aka project folio) conversion. There will be way less
> places to audit to see if the user was actually using struct page.
> 
> The patches are deliberately kept small, so that every conversion can be
> reviewed, and if needed reverted, on its own.
> 
> Also in git:
> https://git.kernel.org/pub/scm/linux/kernel/git/rppt/linux.git gfp-to-kmalloc/s390-sclp
> 
> [1] https://lore.kernel.org/all/20251018093002.3660549-1-rppt@kernel.org/
> [2] https://lore.kernel.org/all/CA+55aFwp4iy4rtX2gE2WjBGFL=NxMVnoFeHqYa2j1dYOMMGqxg@mail.gmail.com/
...
>  drivers/s390/char/sclp.c         |  9 +++++----
>  drivers/s390/char/sclp_ap.c      |  4 ++--
>  drivers/s390/char/sclp_cmd.c     | 13 +++++++------
>  drivers/s390/char/sclp_con.c     |  5 +++--
>  drivers/s390/char/sclp_config.c  |  4 ++--
>  drivers/s390/char/sclp_cpi_sys.c |  4 ++--
>  drivers/s390/char/sclp_ctl.c     |  5 +++--
>  drivers/s390/char/sclp_ftp.c     | 14 ++++++--------
>  drivers/s390/char/sclp_mem.c     | 12 ++++++------
>  drivers/s390/char/sclp_pci.c     |  8 ++++----
>  drivers/s390/char/sclp_sd.c      | 20 ++++++++++----------
>  drivers/s390/char/sclp_sdias.c   |  5 +++--
>  drivers/s390/char/sclp_tty.c     |  5 +++--
>  drivers/s390/char/sclp_vt220.c   |  4 ++--
>  14 files changed, 58 insertions(+), 54 deletions(-)
> ---
> base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
> change-id: 20260907-s390-sclp-ready-05ebba1ea5e9

Applied, thanks!

> --
> Sincerely yours,
> Mike.

      parent reply	other threads:[~2026-11-19 19:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 13:06 Mike Rapoport (Microsoft)
2026-11-17 13:06 ` [PATCH v2 01/14] s390/sclp_vt220: Replace get_zeroed_page() with kzalloc() Mike Rapoport (Microsoft)
2026-11-17 13:06 ` [PATCH v2 02/14] s390/sclp_config: " Mike Rapoport (Microsoft)
2026-11-17 13:06 ` [PATCH v2 03/14] s390/sclp_pci: " Mike Rapoport (Microsoft)
2026-11-17 13:06 ` [PATCH v2 04/14] s390/sclp_ctl: " Mike Rapoport (Microsoft)
2026-11-17 13:06 ` [PATCH v2 05/14] s390/sclp_con: " Mike Rapoport (Microsoft)
2026-11-17 13:06 ` [PATCH v2 06/14] s390/sclp_tty: " Mike Rapoport (Microsoft)
2026-11-17 13:06 ` [PATCH v2 07/14] s390/sclp: Replace __get_free_page() with kmalloc() Mike Rapoport (Microsoft)
2026-11-17 13:07 ` [PATCH v2 08/14] s390/sclp_sdias: " Mike Rapoport (Microsoft)
2026-11-17 13:07 ` [PATCH v2 09/14] s390/sclp_sd: " Mike Rapoport (Microsoft)
2026-11-17 13:07 ` [PATCH v2 10/14] s390/sclp_cmd: Replace page allocator calls with kzalloc() Mike Rapoport (Microsoft)
2026-11-17 15:33   ` Heiko Carstens
2026-11-17 13:07 ` [PATCH v2 11/14] s390/sclp_cpi: Replace get_zeroed_page() " Mike Rapoport (Microsoft)
2026-11-17 13:07 ` [PATCH v2 12/14] s390/sclp_ftp: " Mike Rapoport (Microsoft)
2026-11-17 15:34   ` Heiko Carstens
2026-11-17 13:07 ` [PATCH v2 13/14] s390/sclp_mem: Replace page allocator calls with k[mz]alloc() Mike Rapoport (Microsoft)
2026-11-17 13:07 ` [PATCH v2 14/14] s390/sclp_ap: Replace get_zeroed_page() with kzalloc() Mike Rapoport (Microsoft)
2026-11-19 19:54 ` Alexander Gordeev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7aece4e-7dc5-455b-a631-721ab99e2546-agordeev@linux.ibm.com \
    --to=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=david@kernel.org \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=rppt@kernel.org \
    --cc=svens@linux.ibm.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®