From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7091C76186 for ; Wed, 17 Jul 2019 03:58:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9163A20818 for ; Wed, 17 Jul 2019 03:58:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aj.id.au header.i=@aj.id.au header.b="DhsuuKEx"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="HTsZBQ5Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729406AbfGQD6S (ORCPT ); Tue, 16 Jul 2019 23:58:18 -0400 Received: from new3-smtp.messagingengine.com ([66.111.4.229]:55753 "EHLO new3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726069AbfGQD6S (ORCPT ); Tue, 16 Jul 2019 23:58:18 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id CFD5721F1; Tue, 16 Jul 2019 23:58:16 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute4.internal (MEProxy); Tue, 16 Jul 2019 23:58:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm3; bh=7Kdhi4X59fRaX9BlrrSVCJVURd/WfMF FykQ50ZgZyNs=; b=DhsuuKExeeTQFKi0vfZAjumQFLgV8B2f7odFp/bnfPE03M/ 6ZtJRE4TYCdrPEztEzQtcrBwfWixCOJO/20E3kEhYzg/xIeMFnwI93X98zqH6DRm pbWVkUK85zkzLAR2lL0inZ0Q1WcODlhrfvPEPJzsa4UUNLwfBqHSu40se5KFD5qv vkB0DYhuprc8RwKmTTUFz7eyM4FKBwcrZS2uBo2L6jFAAmEtNIyj26Yz0hmHuM2S qfCdKPVLAB7hu2s9B1guhDP8ZCBlQeCDy0KXPw5L9zQFBEOPf+//F6qmWws69AEF eo17oubYBHvjuX+H71vhhx/xF9iUYvnVnAS8Xrw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=7Kdhi4 X59fRaX9BlrrSVCJVURd/WfMFFykQ50ZgZyNs=; b=HTsZBQ5Q15RDtChXdnGRqb cndQnVjFvbB6k4zmY0r6J/Y/EKh2FkdZ30MEkNTd/rNdnd1HsTYPBj8U+Ux+Kyl2 Dt2rLSwbVBMntmHyi3iKknjIN0wM9LPC+2M04qEdBihkS/v1QjP5/JKFz+5Ah3uf YqQLFu/EvyCIWKmYzhCGttLEDBiI/UtxecX6axrKdcPybuXf+XDA80YfxBLAkS/v 9tT7xX/q3N1Upmil2XLO9ahkbbO+PIg4SPA4zQ5RzEzlnjdB9Ob9i7CUCrzstCYv 165p0YgmCNzVPZg4wNedNnnWZrwYEKHWZiRAe2J5hJDhnSOFFoPST0eUn5DL9r6A == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddriedugdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedftehnughr vgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucffohhmrg hinhepuggvvhhitggvthhrvggvrdhorhhgpdifrhhithhinhhgqdhstghhvghmrgdrmhgu necurfgrrhgrmhepmhgrihhlfhhrohhmpegrnhgurhgvfiesrghjrdhiugdrrghunecuve hluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 5AAA3E00CC; Tue, 16 Jul 2019 23:58:13 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.6-731-g19d3b16-fmstable-20190627v1 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20190712033214.24713-1-andrew@aj.id.au> <20190712033214.24713-2-andrew@aj.id.au> <3fe55ea9-b949-48a0-9eab-90ad3bc1ee2a@www.fastmail.com> Date: Wed, 17 Jul 2019 13:27:59 +0930 From: "Andrew Jeffery" To: "Rob Herring" Cc: linux-mmc , "Ulf Hansson" , "Mark Rutland" , "Joel Stanley" , "Adrian Hunter" , devicetree@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-aspeed@lists.ozlabs.org, "linux-kernel@vger.kernel.org" , "Ryan Chen" Subject: Re: [PATCH v2 1/2] dt-bindings: mmc: Document Aspeed SD controller Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Jul 2019, at 00:27, Rob Herring wrote: > On Mon, Jul 15, 2019 at 6:36 PM Andrew Jeffery wrote: > > > > > > > > On Tue, 16 Jul 2019, at 07:47, Rob Herring wrote: > > > On Thu, Jul 11, 2019 at 9:32 PM Andrew Jeffery wrote: > > > > > > > > The ASPEED SD/SDIO/eMMC controller exposes two slots implementing the > > > > SDIO Host Specification v2.00, with 1 or 4 bit data buses, or an 8 bit > > > > data bus if only a single slot is enabled. > > > > > > > > Signed-off-by: Andrew Jeffery > > > > --- > > > > In v2: > > > > > > > > * Rename to aspeed,sdhci.yaml > > > > * Rename sd-controller compatible > > > > * Add `maxItems: 1` for reg properties > > > > * Move sdhci subnode description to patternProperties > > > > * Drop sdhci compatible requirement > > > > * #address-cells and #size-cells are required > > > > * Prevent additional properties > > > > * Implement explicit ranges in example > > > > * Remove slot property > > > > > > > > .../devicetree/bindings/mmc/aspeed,sdhci.yaml | 90 +++++++++++++++++++ > > > > 1 file changed, 90 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > > > > > > > diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > > > new file mode 100644 > > > > index 000000000000..67a691c3348c > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > > > @@ -0,0 +1,90 @@ > > > > +# SPDX-License-Identifier: GPL-2.0-or-later > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/mmc/aspeed,sdhci.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: ASPEED SD/SDIO/eMMC Controller > > > > + > > > > +maintainers: > > > > + - Andrew Jeffery > > > > + - Ryan Chen > > > > + > > > > +description: |+ > > > > + The ASPEED SD/SDIO/eMMC controller exposes two slots implementing the SDIO > > > > + Host Specification v2.00, with 1 or 4 bit data buses, or an 8 bit data bus if > > > > + only a single slot is enabled. > > > > + > > > > + The two slots are supported by a common configuration area. As the SDHCIs for > > > > + the slots are dependent on the common configuration area, they are described > > > > + as child nodes. > > > > + > > > > +properties: > > > > + compatible: > > > > + enum: [ aspeed,ast2400-sd-controller, aspeed,ast2500-sd-controller ] > > > > > > This is actually a list of 4 strings. Please reformat to 1 per line. > > > > On reflection that's obvious, but also a somewhat subtle interaction with the > > preference for no quotes (the obvious caveat being "except where required"). > > It wasn't something I'd run into before. I'm working on a check, but > unfortunately we can only check for quotes not needed and can't check > for missing quotes. > > > Thanks for pointing it out. > > > > I have been running `make dt_binding_check` and `make dtbs_check` over > > these, looks like I need to up my game a bit though. Do you do additional things > > in your workflow? > > That should have thrown the warnings. If you aren't seeing those, do > you have dtschema package installed (see > Documentation/devicetree/writing-schema.md)? I do have it installed, but as mentioned previously there's a fair few warnings emitted currently by the Aspeed devicetrees, so it might have got lost in the noise. I've started to clean that up, though probably need some direction there too. Separately I'm currently trying to track down an issue where I get errors on the Aspeed dts cpu nodes about failing to match the riscv CPU compatibles, it seems dt-validate isn't finding the ARM CPU compatible strings. It feels more annoying to track down that I'd like. > Or it could be erroring > out on something else first. There's a few breakages that I'm trying > to fix. Okay. I'll keep an eye on the dt-schema repo. Cheers, Andrew