From: Andrew Lunn <andrew@lunn.ch>
To: Patryk Biel <pbiel7@gmail.com>
Cc: Ioana Ciornei <ioana.ciornei@nxp.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH] net: pcs: enable autonegotiation for 10g-usxgmii
Date: Thu, 20 Aug 2026 20:24:45 +0200 [thread overview]
Message-ID: <e7b87ff9-1ea2-412e-8418-89141b2a106a@lunn.ch> (raw)
In-Reply-To: <20260820-b4-fix-pcs-lynx-an-v1-1-62d66391eaff@gmail.com>
> @@ -154,6 +157,7 @@ static int lynx_pcs_config_usxgmii(struct mdio_device *pcs,
> const unsigned long *advertising,
> unsigned int neg_mode)
> {
> + int ret;
> struct mii_bus *bus = pcs->bus;
> int addr = pcs->addr;
Reverse Christmas tree. Please sort the lines longest to shortest.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2026-08-20 18:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 17:41 Patryk Biel
2026-08-20 18:24 ` Andrew Lunn [this message]
2026-08-21 10:00 ` Ioana Ciornei
2026-08-24 12:54 ` Patryk Biel
2026-08-26 20:19 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7b87ff9-1ea2-412e-8418-89141b2a106a@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pbiel7@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®