mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Seyfried <stefan.seyfried@googlemail.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Cc: Stefan Seyfried <seife+kernel@b1-systems.com>
Subject: Re: [PATCH] cfg80211: fix wext-compat memory leak
Date: Mon, 1 Oct 2018 10:55:34 +0200	[thread overview]
Message-ID: <e7bb48f5-3933-6d0b-160f-8d0801e3c1a7@message-id.googlemail.com> (raw)
In-Reply-To: <1538377946.3126.0.camel@sipsolutions.net>

Hi Johannes,

Am 01.10.18 um 09:12 schrieb Johannes Berg:
> Hi Stefan,
> 
> Thanks for the investigation & fix. I've changed the fix to use
> cfg80211_sinfo_release_content(),

Being totally unfamiliar with the code, I was not sure about that :-)

> take care of the error path in
> cfg80211_wext_giwrate() and added a Fixes tag :-)

That's certainly much better.

Thanks!

(kudos to Vlastimil Babka who pointed out trace-cmd to me on the
 opensuse-kernel malinglist, which made the investigation quite easy)
-- 
Stefan Seyfried

"For a successful technology, reality must take precedence over
 public relations, for nature cannot be fooled." -- Richard Feynman

      reply	other threads:[~2018-10-01  8:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-30 10:53 stefan.seyfried
2018-10-01  7:12 ` Johannes Berg
2018-10-01  8:55   ` Stefan Seyfried [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7bb48f5-3933-6d0b-160f-8d0801e3c1a7@message-id.googlemail.com \
    --to=stefan.seyfried@googlemail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=seife+kernel@b1-systems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®