From: Juergen Gross <jgross@suse.com>
To: "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, x86@kernel.org
Cc: sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de
Subject: Re: [PATCH] x86/boot: clear rsdp address in boot_params for broken loaders
Date: Tue, 4 Dec 2018 07:03:58 +0100 [thread overview]
Message-ID: <e7ca96fe-5bd5-d051-3bf4-abcca52e73a9@suse.com> (raw)
In-Reply-To: <0917d755-3311-92a9-8fb4-c0f408633f5c@zytor.com>
On 04/12/2018 06:49, H. Peter Anvin wrote:
> On 12/3/18 9:32 PM, Juergen Gross wrote:
>>
>> I'd like to send a followup patch doing that. And I'd like to not only
>> test sentinel for being non-zero, but all padding fields as well. This
>> should be 4.21 material, though.
>>
>
> No, you can't do that. That breaks backwards compatibility.
So you are speaking about paddings which are at places where there used
to be some information? Shouldn't those be named "_res*"?
Recycling such paddings with some useful information seems to be rather
dangerous then.
I'd like to have at least some idea which boot loader is not passing a
clean struct boot_params. So I think we should at least have some debug
or info messages telling us which paddings are not zero initially to be
able to either fix the boot loader or switch from _pad* to _res* naming.
Juergen
prev parent reply other threads:[~2018-12-04 6:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 10:38 Juergen Gross
2018-12-03 15:54 ` [tip:x86/urgent] x86/boot: Clear RSDP " tip-bot for Juergen Gross
2018-12-03 23:07 ` [PATCH] x86/boot: clear rsdp " hpa
2018-12-04 5:32 ` Juergen Gross
2018-12-04 5:49 ` H. Peter Anvin
2018-12-04 6:03 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7ca96fe-5bd5-d051-3bf4-abcca52e73a9@suse.com \
--to=jgross@suse.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®