mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Samudrala, Sridhar" <sridhar.samudrala@intel.com>
To: Naveen Mamindlapalli <naveenm@marvell.com>, <davem@davemloft.net>,
	<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<sgoutham@marvell.com>
Cc: Nithin Dabilpuram <ndabilpuram@marvell.com>
Subject: Re: [net PATCH 2/2] octeontx2-af: fix lbk link credits on cn10k
Date: Thu, 8 Jun 2023 16:48:45 -0700	[thread overview]
Message-ID: <e7d42dab-ca13-13f3-4b58-b7c95f9e6afd@intel.com> (raw)
In-Reply-To: <20230608114201.31112-3-naveenm@marvell.com>



On 6/8/2023 4:42 AM, Naveen Mamindlapalli wrote:
> From: Nithin Dabilpuram <ndabilpuram@marvell.com>
> 
> Fix LBK link credits on CN10K to be same as CN9K i.e
> 16 * MAX_LBK_DATA_RATE instead of current scheme of
> calculation based on LBK buf length / FIFO size.
> 
> Fixes: 6e54e1c5399a ("octeontx2-af: cn10K: Add MTU configuration")
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> Signed-off-by: Naveen Mamindlapalli <naveenm@marvell.com>

Reviewed-by: Sridhar Samudrala <sridhar.samudrala@intel.com>

> ---
>   drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
> index 967370c0a649..cbb6d7e62d90 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
> @@ -4067,10 +4067,6 @@ int rvu_mbox_handler_nix_set_rx_cfg(struct rvu *rvu, struct nix_rx_cfg *req,
>   
>   static u64 rvu_get_lbk_link_credits(struct rvu *rvu, u16 lbk_max_frs)
>   {
> -	/* CN10k supports 72KB FIFO size and max packet size of 64k */
> -	if (rvu->hw->lbk_bufsize == 0x12000)
> -		return (rvu->hw->lbk_bufsize - lbk_max_frs) / 16;
> -
>   	return 1600; /* 16 * max LBK datarate = 16 * 100Gbps */
>   }
>   

  reply	other threads:[~2023-06-08 23:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-08 11:41 [net PATCH 0/2] RVU NIX AF driver fixes Naveen Mamindlapalli
2023-06-08 11:42 ` [net PATCH 1/2] octeontx2-af: fixed resource availability check Naveen Mamindlapalli
2023-06-08 23:47   ` Samudrala, Sridhar
2023-06-08 11:42 ` [net PATCH 2/2] octeontx2-af: fix lbk link credits on cn10k Naveen Mamindlapalli
2023-06-08 23:48   ` Samudrala, Sridhar [this message]
2023-06-10 19:02 ` [net PATCH 0/2] RVU NIX AF driver fixes patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7d42dab-ca13-13f3-4b58-b7c95f9e6afd@intel.com \
    --to=sridhar.samudrala@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=naveenm@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sgoutham@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®