mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Kai Bankett" <chaosman@ontika.net>
To: "Dan Carpenter" <dan.carpenter@oracle.com>
Cc: "Al Viro" <viro@zeniv.linux.org.uk>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] qnx6fs: silence a Sparse warning
Date: Mon, 12 Mar 2012 11:47:56 +0100	[thread overview]
Message-ID: <e7d66e1ec32441e07e70f73581288dfd.squirrel@www.ontika.net> (raw)
In-Reply-To: <20120308072551.GA27713@elgon.mountain>

Hi Dan,

thank you very much for the provided fix.
I've successfully applied and tested it. (well, did not expect much to
happen, but just to be on the safe side)
I will include it in my next version.

Thanks,

Kai

> Add a  __force to silence a sparse warning:
> 	fs/qnx6/inode.c:88:22: warning: cast to restricted __fs32
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/fs/qnx6/inode.c b/fs/qnx6/inode.c
> index e44012d..acf9241 100644
> --- a/fs/qnx6/inode.c
> +++ b/fs/qnx6/inode.c
> @@ -85,7 +85,7 @@ static int qnx6_get_block(struct inode *inode, sector_t
> iblock,
>
>  static int qnx6_check_blockptr(__fs32 ptr)
>  {
> -	if (ptr == ~(__fs32)0) {
> +	if (ptr == ~(__force __fs32)0) {
>  		printk(KERN_ERR "qnx6: hit unused blockpointer.\n");
>  		return 0;
>  	}
>



      reply	other threads:[~2012-03-12 10:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-08  7:25 Dan Carpenter
2012-03-12 10:47 ` Kai Bankett [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7d66e1ec32441e07e70f73581288dfd.squirrel@www.ontika.net \
    --to=chaosman@ontika.net \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®