From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FCB3849C; Mon, 9 Dec 2024 20:19:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733775549; cv=none; b=r/bH8a3vcaGsGOf3V09DseKqNid21gamMcFDq46PfrFiAcTjWN49a342PvEo+ap4AoSqJ4Qs5B/lI8gZ0qJQ9sORRj0t91/nsjOYcc02e3WzkxXGK5upgmjaiJXnNAQKIiL3pZmBkkCIyFRF3QvXwY8UqtFGYnob6ePfLMrhBZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733775549; c=relaxed/simple; bh=uz+K+SAXiw7B9fmpjgpXZQAhhDopnh3fXndnk8ms4uo=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=LkkS2YtMxSWnc2dTFZooDVe8jrfPvZlQYaRYd9cujnfBMvVXC4D/U/HhDk4QyZZKd3bpagx9YD/0N8HP6Zowh2bO9soECe8C+OadBx8CuwrEqPmbw+2LAUiwlBtMemQDKLGBTRCKJbJ88wo6kYCorsTpffu136xgfsd8OkOICQs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=dQoCNGGH; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="dQoCNGGH" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4B9E6kHS006931; Mon, 9 Dec 2024 20:18:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EbMyNtDxooo6rHnhUiB7v/jMrrTSDUYZJmIjsmUNZGk=; b=dQoCNGGHmCG1pQAq NyaEq4eQIleCYk9XFq8aPxgpmqDNkhDrYwxqALjLxGEhB27VTNQa/jqPDKDQhTOK C/Vyh/IoVwc+8LbsyVohkVTvc+ky+Sevsz8bFyyU0oatonl9rFd2dmHTubUhpwav vhzp9lr5lse6WVXhnFYGXr6rUBkvfaA1DTwymH6o+k4B5Lq6YXr3FxCF32yymDJX 6wZISGXoastZ4HMPYKFTvgSebSyBAjRJN5VU6VOS4mMmUeJ3nkYdfw6AtfDfS7jJ JdLBb0fZUJq6YqtHOkrj1sBbR8S1jKENlTw7PsRbeZJhJiHuLaVDg9rL2MPD2dVb YVx9XQ== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43e21bh2jn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 09 Dec 2024 20:18:47 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4B9KIlGm024851 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 9 Dec 2024 20:18:47 GMT Received: from [10.134.71.247] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 9 Dec 2024 12:18:43 -0800 Message-ID: Date: Mon, 9 Dec 2024 12:18:42 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/8] drm/msm/dp: Add maximum width limitation for modes To: Xiangxu Yin , Dmitry Baryshkov CC: Rob Clark , Sean Paul , "Marijn Suijten" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley , "Kuogee Hsieh" , Vinod Koul , "Kishon Vijay Abraham I" , Linus Walleij , Bartosz Golaszewski , , , , , , , , , References: <20241129-add-displayport-support-for-qcs615-platform-v1-0-09a4338d93ef@quicinc.com> <20241129-add-displayport-support-for-qcs615-platform-v1-6-09a4338d93ef@quicinc.com> <95a78722-8266-4d5d-8d2f-e8efa1aa2e87@quicinc.com> <86b9a8be-8972-4c19-af0c-da6b3667cbf4@quicinc.com> <3e7660b3-934a-4b11-82a3-48137d63ea5d@quicinc.com> <5cdd9f7a-2c28-4ac2-a4da-304d25efbca3@quicinc.com> Content-Language: en-US From: Abhinav Kumar In-Reply-To: <5cdd9f7a-2c28-4ac2-a4da-304d25efbca3@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: SehKFPSmVCqQ_Px7chkZwuF6fzktwkaO X-Proofpoint-ORIG-GUID: SehKFPSmVCqQ_Px7chkZwuF6fzktwkaO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 mlxlogscore=647 priorityscore=1501 spamscore=0 impostorscore=0 adultscore=0 bulkscore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412090157 On 12/8/2024 5:57 PM, Xiangxu Yin wrote: > > > On 12/7/2024 4:13 AM, Abhinav Kumar wrote: >> >> >> On 12/3/2024 5:58 AM, Dmitry Baryshkov wrote: >>> On Tue, Dec 03, 2024 at 03:41:53PM +0800, Xiangxu Yin wrote: >>>> >>>> >>>> On 12/2/2024 5:32 PM, Dmitry Baryshkov wrote: >>>>> On Mon, 2 Dec 2024 at 11:05, Xiangxu Yin wrote: >>>>>> >>>>>> >>>>>> >>>>>> On 11/29/2024 9:52 PM, Dmitry Baryshkov wrote: >>>>>>> On Fri, 29 Nov 2024 at 09:59, Xiangxu Yin wrote: >>>>>>>> >>>>>>>> Introduce a maximum width constraint for modes during validation. This >>>>>>>> ensures that the modes are filtered based on hardware capabilities, >>>>>>>> specifically addressing the line buffer limitations of individual pipes. >>>>>>> >>>>>>> This doesn't describe, why this is necessary. What does "buffer >>>>>>> limitations of individual pipes" mean? >>>>>>> If the platforms have hw capabilities like being unable to support 8k >>>>>>> or 10k, it should go to platform data >>>>>>> >>>>>> It's SSPP line buffer limitation for this platform and only support to 2160 mode width. >>>>>> Then, shall I add max_width config to struct msm_dp_desc in next patch? for other platform will set defualt value to ‘DP_MAX_WIDTH 7680' >>>>> >>>>> SSPP line buffer limitations are to be handled in the DPU driver. The >>>>> DP driver shouldn't care about those. >>>>> >>>> Ok, Will drop this part in next patch. >>> >>> If you drop it, what will be left from the patch itself? >>> >> >> Yes agree with Dmitry, max_width is really not a DP related terminology. >> >> This patch should be dropped. >> >> So there were two issues, overall in this series causing this patch: >> >> 1) In https://patchwork.freedesktop.org/patch/625822/, instead of using VIG_SDM845_MASK, we should be using VIG_SDM845_MASK_SDMA. Without that even 2k will not work, will leave a comment there. >> >> 2) 4k will still fail. I dont think we can even support 4k on QCS615 but the modes should be filtered out because there is no 3dmux. >> >> I have submitted https://patchwork.freedesktop.org/patch/627694/ to address this. >> >> Xiangxu, please let me know if that works for you. >> >> Thanks >> >> Abhinav > Thanks for your patchsets, > After apply patch 625822 & 627694，mode filter works correctly on QCS615 platform with both 4k and 2k monitor. > work>>>>>>> Thanks. If you can give your Tested-by on https://patchwork.freedesktop.org/patch/627967/, that would be great. >>>>>>>> Signed-off-by: Xiangxu Yin >>>>>>>> --- >>>>>>>>   drivers/gpu/drm/msm/dp/dp_display.c |  3 +++ >>>>>>>>   drivers/gpu/drm/msm/dp/dp_display.h |  1 + >>>>>>>>   drivers/gpu/drm/msm/dp/dp_panel.c   | 13 +++++++++++++ >>>>>>>>   drivers/gpu/drm/msm/dp/dp_panel.h   |  1 + >>>>>>>>   4 files changed, 18 insertions(+) >>>>> >>>>> >>>> >>> >