From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AFD744D02D for ; Thu, 26 Feb 2026 19:39:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772134745; cv=none; b=gDfQ7GUMaMqRqk2jJLadEklR5lyzpgitkgW9opbaY+EdZUWpVz9uwVt0myCMsku7NLN8UM1tUVez9kwO5R7LWKrkh61APO2TnZmqP5/Bjm+yfT79oOYu9Z2210xXnqsnOmYXmSaPwR10e2b48eJlEWybTWUo1NbIMBt1t/CncBo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772134745; c=relaxed/simple; bh=6wUBVvYfGjEq9nwHz1sVebeCv/RSVhLMjEWbjPz1zmU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k6Y7Dgk+ZRz88epalOlW5ELs/p5pAWWUrVUdpQiaagF+mFWzRukEdzTR8XCAPQ2ZAbrVeXAH5ifB6QzWMkxeuTI4Wr9cgQdSt32ita0Bg87TCe2N4QIE+0CGh8E593qrX8+Qour+MVMygOCjNkV4Ew/dUYMkY6ZFzdK9nTBPGlI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HSNkyeVp; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HSNkyeVp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772134743; x=1803670743; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=6wUBVvYfGjEq9nwHz1sVebeCv/RSVhLMjEWbjPz1zmU=; b=HSNkyeVpHieOM4SuO9hPb06UCNg6YX8OCjBcdU7AGOa4h0GVVtK1hCj1 95lgeo7yvcCRbP+TU4TOgyL8Q4Kd6axZMem4SJejvOUScMCLl4NSUFZQA LVY6D3nJFB6pkGVMCN2b1mEruV525/V3tBH5DR5aFbhx4/cPwE02E+8Ku Xs8tQMsU4JxPa8fdPlPWZlAe3s228hGB0Wcy5ER6aPa/+HhTnBen1BrLC D2knnV5Hkjn6r2vGK9W8zlsx3JxTMytVxuYaOYmNj7HPyJ/tJRpQ57r1G 3e57w3jy+H1W6ioLthQGQD5y/Rl8OGoGts9aeLS6u/GVB/V0UL+pg4WYF A==; X-CSE-ConnectionGUID: EsM01vvRRGO5DBU2qBjxgQ== X-CSE-MsgGUID: 4CdOk63vSsiqObU1x8sCkg== X-IronPort-AV: E=McAfee;i="6800,10657,11713"; a="84565120" X-IronPort-AV: E=Sophos;i="6.21,312,1763452800"; d="scan'208";a="84565120" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2026 11:39:02 -0800 X-CSE-ConnectionGUID: oPzbG5MrSp+CqCHnOC1Qig== X-CSE-MsgGUID: hpH7iAPlTwymK2FefT+3wQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,312,1763452800"; d="scan'208";a="215902673" Received: from dwoodwor-mobl2.amr.corp.intel.com (HELO [10.125.111.132]) ([10.125.111.132]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2026 11:39:02 -0800 Message-ID: Date: Thu, 26 Feb 2026 11:39:02 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 09/13] x86/mm: Reset tags in a canonical address helper call To: Maciej Wieczor-Retman Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Maciej Wieczor-Retman , linux-kernel@vger.kernel.org, "Kirill A. Shutemov" , Daniel Borkmann , Alexei Starovoitov References: <8c1d34e7d8d9fdeb836230160c9207e7bc06e0ee.1770232424.git.m.wieczorretman@pm.me> Content-Language: en-US From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/24/26 00:57, Maciej Wieczor-Retman wrote: > On 2026-02-23 at 12:39:22 -0800, Dave Hansen wrote: >> On 2/4/26 11:20, Maciej Wieczor-Retman wrote: >>> - return __is_canonical_address(vaddr, boot_cpu_data.x86_virt_bits); >>> + return __is_canonical_address(__tag_reset(vaddr), boot_cpu_data.x86_virt_bits); >>> } >> I think we should just do this in __canonical_address() itself instead >> of changing its callers. There are a whole host of ways to get in there. > Cc: Sean Christopherson > > I tried doing that before and Sean said it'd be wrong from KVM perspective [1]. > Not sure if there is some other way to do it so that it makes sense in KVM? Looking at this some more, I think it's fine to leave __is_canonical_address() alone. There are several kinds of canonical checks and __is_canonical_address() should help with all of them. That said, this patch is still buggy. copy_from_kernel_nofault_allowed() does: if (is_vsyscall_vaddr(vaddr)) return false; which is a plain equality check: static inline bool is_vsyscall_vaddr(unsigned long vaddr) { return unlikely((vaddr & PAGE_MASK) == VSYSCALL_ADDR); } So a tagged 'vaddr' is not going to ever be is_vsyscall_vaddr(). The untagging needs to happen before this check. Further, I do wonder if we want checks in things like is_vsyscall_vaddr() for tagged addresses. If they get into there, it's always a bug I think. Aside: I think copy_from_kernel_nofault_allowed() is buggy. It's using 'boot_cpu_data.x86_virt_bits' which I think is the "CPU canonical" bits, not the "paging canonical" bits. So a 5-level hardware system running in 4-level mode can pass non-paging-canonical address through copy_from_kernel_nofault_allowed(). So I think the 'boot_cpu_data.x86_virt_bits' use in here became a buglet when 5-level-paging got enabled. In a perfect world, we'd stop using EX_TYPE_UACCESS for kernel accesses. But the uaccess.h macros are enough of a mess that I understand why nobody wanted to plumb a new exception type into them and wanted to reuse them as-is.