From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D964F364045 for ; Sat, 1 Aug 2026 22:01:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785621695; cv=none; b=KDg8zbLT+YDcPRJGZno/Yq0ZntHPx+94XvdVQSppYpSv55w7JcuO4VHhfvSQugbgK2TlgJNAl5qmOYXnuzY30NiEQB3/jA3x/o/8IXp10JiswezTWqTTPAEIU/Oz9OtH4k71wTSPmJbL7SPdHZbK3kQl6ZayXCN1/jypCAymukA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785621695; c=relaxed/simple; bh=k+XwpsvdR4lXnK8J7akvyHhiQeX6iOLIGH6lriW/zZA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iR6MhiAZS8q8qCmG9S6gUuHZKaYfa7TtIuYeHPrzNwmW5Gg+v1Une9s1nPH5SuTkui8zyHD44fRnelhikijCrVEayTz1zqgWa1Pt4uaSy/PModN1UXTdKRaefR5XpiMIctx6uJwS+0yn2JIpNatGfweRVnuBCTvyA40KBIA78rY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LjF6511M; arc=none smtp.client-ip=209.85.128.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LjF6511M" Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-81ed2a00f12so31638357b3.2 for ; Sat, 01 Aug 2026 15:01:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785621682; x=1786226482; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qR4j1ND7sU3DHEeB5SkE24JFiOq+gxamuNrGyu3FS3k=; b=LjF6511MD8nyx8OgsBaCVjrtAId5xfEyV9Mla+K1MgBFkCXjSOtDDh4FrzzGiIgCYG rg6ez4+UbzKcMgRNqTBV/vSr4vBOxenfTN7yvq377FOV49TEgxtoWpoyyCg6Nf9yWtOq yxhLAAE12uLnCLsNx6OFA9wIczk1fHp9PmTSOL8655l3xvJLKk9dqQO5YL9yeUGiI5r4 vFigq4zGJeymgJTrqEPeR6GUNaT8iTHSE5d7p3hBn1FCH8Fn821F4fD511QmILnQZfaR VEsI+Hjmibx7q+C6zbLrWdlm0gmRBoiz6r+K9Y8cA03955hqcrDcJJXROOFxlWZ5tpAi aNHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785621682; x=1786226482; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qR4j1ND7sU3DHEeB5SkE24JFiOq+gxamuNrGyu3FS3k=; b=PHP+zwPLYtDRUvpwvZ24At2TLPMyYiqJtFfX2RchToYs+d+ms6sArqcsHKbfHeUJE6 vHwSO1GjagxqPN8PzPSYVdC5bDSB9x6mkKiw9lBz0wyWF0UR4XgFMJVUKKCH/f+VuPj7 TNCxAjN6CSmcFjjhcPIFG8p8F4i9nqIJV6YZ1zz6eI4inq+skL2PYexW1PzxEhVNF+L0 vmBvv9UpwcJXKjMMh+TUiS8vj9tjXUPZlK/70BrdYoJX5EZ3QaRo2zkXkI1TVRYRuPM1 GkYQRXyc4pXVV5ewu0I5bic8G4Ov6nO4zqzB22JLDNfoMUHURULDzpjfWOVr7DQiyJ41 xSsw== X-Forwarded-Encrypted: i=1; AHgh+RphxRXVoV2xCPgLe+s/30zSnEW+upj06/70L83RtpjquEVwETSaDaP28g+BPSdtKR/Nk3r6234E8Nyf34A=@vger.kernel.org X-Gm-Message-State: AOJu0Yy00L0WabrQN7feGYCwzKMo9PN0Ikxd7rpqmkqNKmgFoVGKosNf wwus6fXfcJ99MM/djS7/JywlOOYIX/0v4YqDfYlQW0BZ6unoe18ku/0d X-Gm-Gg: AR+sD12I7JaahQvpXJ6AgsWMJEFrmGsXK/ubbpW2on/lTqjjT1TSil+coKnvm+eLeuG rhdt+G1lgac03MW1OKdgm/aFWrHKPcI3OdHg0p/HF6dZg8G/c9HDH+qEixi8wXU1EqyVIcDd+fw cBvVrDbV+KnLurYgcDxzMTK+2lH1MxN8KDx5/D1E/clw7CpWALU47NLyLfQxGX4KsNPzJNyKhaK Gg+5qOCz+1wttBiFqMq7rJr1hhdeAqs+Ynnale0i7Rz1JmjuCYqEAdugX9UwwzpK6JDmrgIZ//Q K6T+xtmkpkL6O7tpc3PTI//MiJSf7Maeacg8rrbJjmbkxwVj2GTqDEjvzu5JdkC661rN2N0F7U0 pPQ23IDubO9yhwgTbnVP8r/crnZaHYXopJfG28vzGszw8IU4OVw2x0678fiNXL0sVp156c/E8uL 3U2wjjMXPO1H8T+l1I8qGbClUvMKzqM/sYHbIXPpHKCvvnAyrJoYzb6jk5ODMsX22ZDEZWFeOnf hg3eS50 X-Received: by 2002:a05:690c:6d07:b0:81f:27f8:2de4 with SMTP id 00721157ae682-81fd4a04799mr74061547b3.8.1785621681823; Sat, 01 Aug 2026 15:01:21 -0700 (PDT) Received: from syssplab.cs.fiu.edu (nat1.cs.fiu.edu. [131.94.134.89]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81fcd0d6fbbsm29903767b3.25.2026.08.01.15.01.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 15:01:21 -0700 (PDT) From: Chao Shi To: Jan Kara , Christian Brauner , Alexander Viro , Matthew Wilcox , linux-fsdevel@vger.kernel.org Cc: Theodore Ts'o , Andreas Dilger , Baokun Li , Ojaswin Mujoo , Ritesh Harjani , Zhang Yi , Bob Copeland , Namjae Jeon , Sungjong Seo , Yuezhang Mo , OGAWA Hirofumi , Mark Fasheh , Joel Becker , Joseph Qi , Andreas Gruenbacher , linux-ext4@vger.kernel.org, ocfs2-devel@lists.linux.dev, gfs2@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Shi Subject: [PATCH 09/19] omfs: check for an inode write error with buffer_write_io_error() Date: Sat, 1 Aug 2026 18:00:53 -0400 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit __omfs_write_inode() spots a failed synchronous write, on both the primary block and each mirror, by testing BH_Req together with !BH_Uptodate. That relies on the write completion handler clearing BH_Uptodate on error, which this series removes: a buffer whose write failed still holds the data the filesystem asked to be written, so declaring it not up to date is wrong and makes callers re-read it. BH_Write_EIO says exactly what this code wants to know, and it implies BH_Req, so each pair collapses into one test. No behaviour change today - a failed write sets BH_Write_EIO and clears BH_Uptodate together. It stops being a no-op at the end of the series, where the new test is the one that still works. Signed-off-by: Chao Shi --- fs/omfs/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c index 1d915ef72119..bc37029a4afb 100644 --- a/fs/omfs/inode.c +++ b/fs/omfs/inode.c @@ -145,7 +145,7 @@ static int __omfs_write_inode(struct inode *inode, int wait) mark_buffer_dirty(bh); if (wait) { sync_dirty_buffer(bh); - if (buffer_req(bh) && !buffer_uptodate(bh)) + if (buffer_write_io_error(bh)) sync_failed = 1; } @@ -159,7 +159,7 @@ static int __omfs_write_inode(struct inode *inode, int wait) mark_buffer_dirty(bh2); if (wait) { sync_dirty_buffer(bh2); - if (buffer_req(bh2) && !buffer_uptodate(bh2)) + if (buffer_write_io_error(bh2)) sync_failed = 1; } brelse(bh2); -- 2.43.0