From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DED7614883F for ; Tue, 7 Jan 2025 17:48:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736272110; cv=none; b=PFaDe1I64RUsl9uUKaVWstfX6x3a8nXmSvd8O2EPe6iRJwzWKtoA+8QYyatsUIE9h+LEE+fWgJA45uFvTlJfYinIyVzMKLcd0etvFroctCHfo+F3VwDZ7F9QGw0zPrqLc1ykf3MkgfM2X8/+D/jjppUH8mKHD0mZiV4b3fYl62k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736272110; c=relaxed/simple; bh=PRdChHXTzrOIncjlNdIVWlvFB9ZCcteMmHGaQ3Bcx3M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ol+hhKhoAYig/HJanafr4uVQYoDRJnnc/9G6GVTT4xF4u2TP6wu+wBIjTudVEoQuq9eM2m5yVENA5RwNbFV99b1DVfGMHjIzDMZIPya1JU4w4askGylOk1DexiinD4ANJjHiwdz7jn7XXX/LRPrl62/rSmaPWURkC9NUaw7S/mE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=sNyu+2MQ; arc=none smtp.client-ip=209.85.210.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="sNyu+2MQ" Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-71e1d7130a5so7788884a34.0 for ; Tue, 07 Jan 2025 09:48:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1736272107; x=1736876907; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yUC4u6frWyy1b4AX7BqVShgjsSZ2S6mzSRMnQKxJJNQ=; b=sNyu+2MQNDav5LP8UkwJ8LqnDm4Pvfih2DQui+fTocCHjEmQ6ALwzr9T3QwpxPcQeX bGQwZwOkSY+7R1N38L44l7UyxuLrVkwlUIOxTcIRYqXzq1HzhKKMq6MTWbT3WWJ1chNn wsOzOx182DYqC3trvP2dx0wyaM3jOaMuHVDoYiZPZq0YWOYQFUken/SxaG8cZiV3G0rh elUokpRJSp3HwELse8RLPTHLl0281irdrG4oBfWvLV6dpFOtBzeGlnVHrTTjHGqUO6Z4 Z66BUMIiQGx4DrmzgJJ7rdV8lWhfbmgg7+5uoB1N+emHo2KGsW+d4Rq7KGKCPaz5+7hs DBNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736272107; x=1736876907; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yUC4u6frWyy1b4AX7BqVShgjsSZ2S6mzSRMnQKxJJNQ=; b=sXNWYYV+/ZY+22M2pT+tNvVyBbUi3e1A3Vc9tYfuZqIQJcYgWx/ppOduprnveBzNEk qNF0JP5p4ivG31mr6PNND6+kl94D4C6cQ0k0RvOeH/qxnzxwXVaWujjRiO7AddB278SK VnRiziwXVpBER1/hsjP0auDk25sc8B7q7n8sX5M3GvPTPVLaM1F9nUbaVRTiJiZFX0nN YZ08tGYYcTyfx07FWAp7SzUDSbvTvwOeejBqpcg379E/G0E350OdA/Dwg0g+mtW+mSLA WyAOo7zP8EwQ2iFixNrB2mQknKAbRcsyp39h17oJYV01eHMaTXuMds7A0QUklUM5ONYN qXhw== X-Forwarded-Encrypted: i=1; AJvYcCXmsQcoeeldXIJCnYW5dH+RcCRkSA9Fx4cgF8/JpHixgoNz9nGfLy0eaT5LvMzfORDVycU3b9GF7tswCQM=@vger.kernel.org X-Gm-Message-State: AOJu0YxzUbK7txhx4GdRwblDel5UcS6iKGdGNMax4sjx2vOAsxOT4l+O JvRFHjGFVcHeUMz0DOD3ePp+zfxxOA1HLT/uXXJguc9omBhZ7Gr31F1/GOgapuU= X-Gm-Gg: ASbGncvzD5DOjaBgWHvXmXkxagWguLw8KECru8TBaYgBMJSBOYQ0fMwmz4DY/X3r81u QYM4S6LyFZP8wkJNmeVQGBHzhPdWUbt3lUnUlga4kU/kjkL+Id61HKQE3rGsEDZ+3MSMJ3kym5R QpTM+fz3op5HSKUPHJw0BDqkl426iQy+f/YRhDG5ZjEnEEUXlEVbVN8tmLEji4yJWmiQJKQHV0H PgWLJEw9PInl7BNreMdHONazQDy3+YcEklvbg7f7Yls4Nq4ploSDOZ9ZxCYI9qVlP+U2PRcnF5m bOlMRNyWhnsi5zr27A== X-Google-Smtp-Source: AGHT+IG1jra2jnZ+Zh2oP6xTdVi/uAv4vxBStS/AXNs20POcFFy1D5rV0s4z/KfY+x62ku+OQtDHfg== X-Received: by 2002:a05:6830:618b:b0:71e:2310:7c7 with SMTP id 46e09a7af769-720ff999b1dmr35253663a34.29.1736272106909; Tue, 07 Jan 2025 09:48:26 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-720fe883c3csm10240493a34.25.2025.01.07.09.48.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2025 09:48:26 -0800 (PST) Message-ID: Date: Tue, 7 Jan 2025 11:48:25 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/3] Re-add filter_type/filter_mode To: Marcelo Schmitt Cc: Marcelo Schmitt , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, cosmin.tanislav@analog.com, jic23@kernel.org, lars@metafoo.de, granquet@baylibre.com, u.kleine-koenig@baylibre.com References: <8db7c0f5-449c-44ab-b92e-590dc697baf0@baylibre.com> From: David Lechner Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/7/25 11:44 AM, Marcelo Schmitt wrote: > On 01/07, David Lechner wrote: >> On 1/7/25 9:11 AM, Marcelo Schmitt wrote: >>> Better document sysfs ABI for ADC digital filter configuration. >>> >>> Change log v1 -> v2 >>> - Split into 3 patches. >>> - Re-added sysfs-bus-iio-adc-ad4130 to keep filter_mode separate from filter_type. >> >> If ad7779 is the only driver with filter_type{,available} attributes while >> ad4130 and admv8818 both have filter_mode{,available} attributes, shouldn't we >> be deprecating filter_type and promoting filter_mode? > > Oh, I had only grepped the adc dir and I didn't noticed admv8818 also had > filter_mode. > Hmm, don't know, though still biased towards filter_type. > > - The admv8818 filter_mode_available ABI exports different values (auto, > manual, bypass). Ah, I didn't look that far, so yes, I agree this is a good reason to standardize on filter_type instead. > - AD7768-1, ADAQ7768-1, AD7768/AD7768-4, AD7124-4, and AD4170 datasheets > refer to sinc filters as filter types (though not all of those designs are > supported in IIO or have filter attributes). > - The AD4130 datasheets also refers to the digital filter as filter type in > some occasions. > > But some datasheets seem to use filter mode and filter type interchangeably > so I don't know. The admv8818 use case is valid and is both low and high-pass > filtering while the ADCs sinc digital filters act like low-pass filter. > Maybe even provide a different name for ADC digital filtering? > digital_filter_type (or digital_filter_mode)?. > > Thanks for pointing that out.