From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752317AbdLEUaa (ORCPT ); Tue, 5 Dec 2017 15:30:30 -0500 Received: from mout.web.de ([212.227.15.3]:55219 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751921AbdLEUa0 (ORCPT ); Tue, 5 Dec 2017 15:30:26 -0500 Subject: [PATCH 4/4] uwb/i1480/dfu/usb: Delete two error messages for a failed memory allocation in i1480_usb_probe() From: SF Markus Elfring To: linux-usb@vger.kernel.org, Andrey Konovalov , Greg Kroah-Hartman , Johan Hovold Cc: LKML , kernel-janitors@vger.kernel.org References: <994a4a57-cfe6-91b5-5fc1-d4153cc5b0e6@users.sourceforge.net> Message-ID: Date: Tue, 5 Dec 2017 21:30:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <994a4a57-cfe6-91b5-5fc1-d4153cc5b0e6@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:Px1vmcQPSImCOUo1rxtxeOV6D4rnXU+0HFl7JvwhXb5AKnmRXoh LvX9cCSeUZhTZyuOv4wX7ihZkvvEKrnLYfGG1jCxuGzUSdydPDd9bDfh2nPXkGUw1ADxAV8 8l8lVlv89Wfyc5jQYzBVlpfHXPm/f6tjcfJRZdBK0FcBQ9LQcjznbCJnaUkSCOiPs7JMpwg na44DR2zVU9pT5bJ4f4tQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Q3lhZ+5CZEw=:72qLvbvNQeeQ68fzyolO+F jzp/KHfpnbA0j0Mdv90XIXdIUekGDdFKUFcLFtbilpK6qBxmAGaPpRZ6C2+8QNd3EHM68E6tu CrmG6T0IECE67KSN4rgG19eU/2R6Hwhzwsw594U4uSZMMXvbtgnba3puHFknYeJrwkry8TjMP IQRCar96vogLAIXHbUJhgCtPxuBaqS0/k+1QEVuFhA+LeUs3sz0spg/OA7SH/0ytwUxw48pg2 tKusaXHzVdkykpPlrPdkwOgLfPSUo/k4Kj7BmhyEUnCVaUB3FkZ/NHP8GRMj0ju0VkI9sVjCy enlgdoPWwkejCmVcUEokkuZbUS1tyTswA1kCzytI1E+qtYKkidK59/4UoaPTs2R5LpzGE6jKA avNG5eTyL8g5/jgMzDs909ULhi1CQ1WM7FaGin9LLOyRHOec3WVY/Ldaae9vuR7bVmiz1rfTI EGlHjdOp8ZipYcfoT81q9mpzol/8yZOmdG5kRmxme3wfTdsLgmZlF/YAyRm68dU0eIcROXcc5 DmNlVLcIjVnJRPJfA1u6nX6/E2YxCa7MAX5GacozcFDKOIkbD3itJURy/TEYncJcVwJrYldvn nA+58DL6B38MMRsNJkXdxLi4bu3kUyrbj1cLrln1yUpl4SM+Ub3HgDMWW9F5F5Ryy8/AT5KsV 2MbGIieddNOT922FDSnFX60wmx7ru3jvCYwOXulJVtjklmNfGki3J0bTbLF76n+EzBmH2HySK PomyOlQjwCRJMVDO5XfuvU1MvGFZiGexQQkVb6kIxtPq1h9MdbZ4Q6XYBfPJo4G5MVVii0xGY Dg3nHPoz1GDIznIiFMPYChEoAET/a1slrKo5fq+IE1sP7jRNJ8= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 5 Dec 2017 21:07:47 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/uwb/i1480/dfu/usb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/uwb/i1480/dfu/usb.c b/drivers/uwb/i1480/dfu/usb.c index a50cf45e530f..56bbdc5504d4 100644 --- a/drivers/uwb/i1480/dfu/usb.c +++ b/drivers/uwb/i1480/dfu/usb.c @@ -366,10 +366,9 @@ int i1480_usb_probe(struct usb_interface *iface, const struct usb_device_id *id) if (iface->cur_altsetting->desc.bNumEndpoints < 1) return -ENODEV; - result = -ENOMEM; i1480_usb = kzalloc(sizeof(*i1480_usb), GFP_KERNEL); if (i1480_usb == NULL) { - dev_err(dev, "Unable to allocate instance\n"); + result = -ENOMEM; goto error; } i1480_usb_init(i1480_usb); @@ -378,7 +377,6 @@ int i1480_usb_probe(struct usb_interface *iface, const struct usb_device_id *id) i1480->buf_size = 512; i1480->cmd_buf = kmalloc(2 * i1480->buf_size, GFP_KERNEL); if (i1480->cmd_buf == NULL) { - dev_err(dev, "Cannot allocate transfer buffers\n"); result = -ENOMEM; goto error_buf_alloc; } -- 2.15.1