From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 886EF33C19B for ; Fri, 21 Nov 2025 09:26:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763717213; cv=none; b=iRmqL6ScponqzdQnOEVeLS4OWoA3W8SN1Bdhx6FsUP5Z3q2NZeXC7jlGrJa8S/2v1p8fxIQSwZxpZOQM74afuStKXskdXjePmq0uc/JH+FAlK1X9P3aIalC0Q9eb1Co+65i8IXSsbJecD8KxUinEbk46f8GlEDD90u2UVhy4WYk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763717213; c=relaxed/simple; bh=L4tt6uJ4RFB+KxsL6/s8O8l15oJPsSzKKLyHBNT2Rr0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hb8uENsxyTLMCDeCEFEK4SLOiryOIfz93XPE6PFP2lLhLCbyqC3/SxVZnGr9G7/e3ffG4EcH8o/XeWKp+bW49d1n8OrR4D4RM8X+YoX9WjyAlx6GhhXNEublABxGgoO2uZL3Gf13HF/o6hFPqBBt/6yEgbDSkmN+lnbNfW2XX+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DhecCm5P; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DhecCm5P" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-477a1c28778so20409825e9.3 for ; Fri, 21 Nov 2025 01:26:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763717210; x=1764322010; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KDp2iG5BTBVt/GPrCjnqeO98ZCL9PVStlkdxlxkQjj0=; b=DhecCm5PP/0Vg0XMOkBtgxagcK232d12moPT6CHExZxe/9O1VHm9Bgiqn4hPJmX2FP OEed/EtGNHZRcy1vFtamDhAWt5EdGWD/arnaBamvTxwRMhfHbLOdUjFultaKiZidjU/a h43qbTIqLhgrosSLVOMC/0gq1V6A5/3PL7Loo46cB6JYFY9FwzZm6V0X/QZkT43lH4yk gedk47u0RsTsDYSGnI1Tg8Hg48FuzTXg56GaW4OyyfEbdipjZcJ6Jb+hHibldcyYbyrM EWYKXB1uM8imr9lKskv8mMV9fGB0npbl9tRIar3wpWTVAL7AYDJ2VLX3j1+XRAfYUcOT tD0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763717210; x=1764322010; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KDp2iG5BTBVt/GPrCjnqeO98ZCL9PVStlkdxlxkQjj0=; b=XQpRB3G8maIHLjfgIjBT6RMaMSGnfsf1W3pcXLRGIISpxB4h0JjgOGOVx0IuCsBJqy GyH3VvgjAhGmrgVJ/6LIX4Nh/5A5AQvIx37Q1+XoRpYP3HcTO2fuAowGF0blh4RYJoW9 qNMLq2Wk8xIakQWGU/9ZiXyY2lgXJW+0t5fQKXXB8O6NX4+CQ10WvzpaTGMrWntpKdKp Ea0HugdXniH/hic0KIm/NhQaxwYnRifk2y63wRsITlCwhYFNDttiSaK88DjKBrg9JJOM YEWZg604hvp2iEeF3RduJUwObDfGkGl4GIt/fI4IP29FQtceVRky1Od0RMFzN3bNHIhZ dlAA== X-Forwarded-Encrypted: i=1; AJvYcCVYkaIK6dJYfJZfa0WmEvMBNy4g28w4D7fuGsoKLcnTDtDiGQBqCuMixNkP0PleabTMWkR0ToRN/jga3G4=@vger.kernel.org X-Gm-Message-State: AOJu0Yzqmd8Hj8yPuXj0SITP8nmuQZAKYEBpsG2X42MWC7FtidXg9GKV I2SjjIW0hdu11lVr8Ny1JWkdmrDUxaF6IIWglHD1M+oSBae4U+CHBjiLNg4KnWqEksM= X-Gm-Gg: ASbGncum275/PlN3tIoRXsmx10ASEN39latvcZNU9U25aX4urQ4+o2DnDi4As8lx+1F et04Sq678m70Xm0O6K0O+Pe+iQwbWucuh/zbBLanEsjBUv5Vj77Ov5OTIRniPdvp/EMQJOnpnmf pF6oAwJaqGSPzS6Z8oMiRVB4z48yoTPhNGl9ZQlyi85gHmUC1gQ6vgeaVfOOLCW/eT/ZH/V3A5y X0gY8Mh2zoMiU5G7VcsDEztlk5bzGiJmxQoV7fb2gmjWBbEit+OJ6QhvgtyKIeUY+3WNVdsbs+z KJSQowYGWmwJncNYjatIpEDTywR/wIWKI0weYKBqBg7Fmw16e5ZpsSzxih3KP3TZEz/vVhrC4If 2xjVG4u/F2yen74NxfL3X6QcoXkSkPvlgMmUJ0UaJKVGMkKpOfSAQOuw8FRHQLCbo8mcOwiglOd oIGkr1ZaOiBUPwQ7MXSA== X-Google-Smtp-Source: AGHT+IFFoQKN4lvZpPcX6YcwQEY2oYp+D9yrpDQzITsjrjlHpyL9s6Wn+65FnIuxFxbiNVzQkT63aA== X-Received: by 2002:a05:600c:3b09:b0:46e:6d5f:f68 with SMTP id 5b1f17b1804b1-477c0185b65mr19721245e9.12.1763717209146; Fri, 21 Nov 2025 01:26:49 -0800 (PST) Received: from [192.168.0.39] ([82.76.24.202]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf3b4fafsm34690175e9.14.2025.11.21.01.26.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Nov 2025 01:26:48 -0800 (PST) Message-ID: Date: Fri, 21 Nov 2025 11:26:47 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] dmaengine: stm32-dma3: use module_platform_driver To: Amelie Delaunay , Vinod Koul , Maxime Coquelin , Alexandre Torgue Cc: dmaengine@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20251103-dma3_improv-v1-0-57f048bf2877@foss.st.com> <20251103-dma3_improv-v1-1-57f048bf2877@foss.st.com> From: Eugen Hristev Content-Language: en-US In-Reply-To: <20251103-dma3_improv-v1-1-57f048bf2877@foss.st.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/3/25 12:15, Amelie Delaunay wrote: > Without module_platform_driver(), stm32-dma3 doesn't have a > module_exit procedure. Once stm32-dma3 module is inserted, it > can't be removed, marked busy. > Use module_platform_driver() instead of subsys_initcall() to register > (insmod) and unregister (rmmod) stm32-dma3 driver. > > Signed-off-by: Amelie Delaunay Reviewed-by: Eugen Hristev > --- > drivers/dma/stm32/stm32-dma3.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/dma/stm32/stm32-dma3.c b/drivers/dma/stm32/stm32-dma3.c > index 50e7106c5cb7..9500164c8f68 100644 > --- a/drivers/dma/stm32/stm32-dma3.c > +++ b/drivers/dma/stm32/stm32-dma3.c > @@ -1914,12 +1914,7 @@ static struct platform_driver stm32_dma3_driver = { > }, > }; > > -static int __init stm32_dma3_init(void) > -{ > - return platform_driver_register(&stm32_dma3_driver); > -} > - > -subsys_initcall(stm32_dma3_init); > +module_platform_driver(stm32_dma3_driver); > > MODULE_DESCRIPTION("STM32 DMA3 controller driver"); > MODULE_AUTHOR("Amelie Delaunay "); >