From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8422714F115 for ; Thu, 28 Nov 2024 08:54:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732784053; cv=none; b=O7ABRXgQQv5ZETTmFrQoxzHJu/BYsHBVwIlzOsjpwUx8EUbqy675e2mred53L/uHvGE3MM3lWMZQ2/5UCv7f2QLCK/TBl+/U1YzLVMuVLgQjIEtKJsyTcshV273OVR4svYCdeKohMH3H9LLR0ood23UypND0zR+iRcuONJls7Mc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732784053; c=relaxed/simple; bh=hkz5SihmtOfz3xVNnJafozuWVVcp4a3ROsLM9kv99sM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UHbiKiNtqSQ0KRTylZo/a5lEAu5piadtgysGWBZDClcG+Xa7YIeUGyByETNehE0m9wNaFiq0Ez1B5DDcJMvI2eKY5omVQQB7NqjpgRaMcz8DSrk3++bJ0iEtSo91VbeZUlBvkaXG5fOms9NoKyygC23XjJodj7oQuf6Y3bQi5qM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=b3+mlO7T; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="b3+mlO7T" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-53dd58a4433so83902e87.2 for ; Thu, 28 Nov 2024 00:54:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732784050; x=1733388850; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/W+eYtBA0K7MiFNuTWTEaMbtArpeNHfybJbxvLhrBp4=; b=b3+mlO7TuPoiTq4oSFa5Uh4HRLdrhy4Ihs0nIofOEDMaQJDqSZyXow6cv34pPsEtSU enlPoae8R6WiM8aTxZtpW5mNgVAK7yPwb1Im7qiNUtEotC9KiF+eHJcQlw4rfuqJy9J2 SVTLMiaaQZoUWucwC0FsiThKxQUnFi1FTyqd96sauc2xbLZto+ai2xTPyUmxtM+3qRF6 QXTxP5EFPoFmQFt/C1nBo6sHfqMXsMF/3e6iOqEb9dtMZzCwWb4+oIohbwNilbh7tViA S9cacc0ThVBiLk1HN/r5tADZhTwhetYvxq4WZRnTPPKroZnwGeBa4KONlD76rgwY4gS7 SpUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732784050; x=1733388850; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/W+eYtBA0K7MiFNuTWTEaMbtArpeNHfybJbxvLhrBp4=; b=d2xKauNFq0fiHb0u+LVsd7fWZ7zgcUcgmu2TRelsRDp+WW02vezAknqAk2xiimhOdo Cd2ZHhJ7hwhfL46s+/0PUGAMucP6Ak2JQ6Hqf+rJY7BsLPhXLoxQZ2NRw7/BhMA7x9F6 92FdyuGvIkjgO9xsQ+/KkWiDGXcpfYMmp3vIeyMNFXpxpJCx1Io6cVqS2sWYNpe1G8B8 mB6zttcKkVnICRwSGae8AX60rLrM1mi0YvJBBvsS505VvBWAiVQTtVep+9AdtN+NwTLf vswNNKpLHMkkwfkSVv6iVLM5WliWB2p8b+4XXyFrlrtTnGhzlWftiji/Bvu2dgXu2Szr SGQQ== X-Forwarded-Encrypted: i=1; AJvYcCVmXUAFUXJXdEp1owgUqywLutb+IzA51jHDftgxYWKxDSexzpuUhcFKnuo3RrvxC50uMp6z4r7eVL/FEXU=@vger.kernel.org X-Gm-Message-State: AOJu0YxLbfsUZkMnWwBWwQkChU8qlYeYMBev5JNiY+gdQxD0BhM1NyJM FljCah9jH/xHmaWHhWrqV6iIwA9bHxofYlUA1BLOeMzSvA1dNrglo9AnWmzP5ds= X-Gm-Gg: ASbGncs0n71BzTFPa+m/qY/zH8MtDPIjjd1KY4P0XX/sPkcgeZype0E3avXywboPMoJ RJcm8XN3wgV5Y2RaMSMURDNnh1IPDXEOfnG/I54PyTaM2UuMoS7eCMTGZnweL4seGisUKdwrWj4 4OVDrWUeU6z5FvE43PEKsnAyEpyllcIWIYH83W0utXGzyUQvKwJptwe7VrLYg3KziQXQujkFCVq WBSe+AXI0JwMGDcxi72AMn3H3cWMHIKn3/SMswBfoArd3sg+qGbwutAMF2dYldSGAb86lWN43jH 79D3maNyRqnCsWnRLNaX5aKNVNdn X-Google-Smtp-Source: AGHT+IHV3a56IUZQzYTe6GHWJjVxI2dvKif7m/fkToU2b9Jrm3M3uttjabmeH44i0IqdBu6iIkTEIQ== X-Received: by 2002:a05:6512:ba8:b0:53d:ddcc:5143 with SMTP id 2adb3069b0e04-53df00ffeccmr750775e87.10.1732784049654; Thu, 28 Nov 2024 00:54:09 -0800 (PST) Received: from [192.168.1.4] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53df649671asm113813e87.191.2024.11.28.00.54.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Nov 2024 00:54:08 -0800 (PST) Message-ID: Date: Thu, 28 Nov 2024 10:54:06 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/5] media: dt-bindings: Add qcom,sc7280-camss Content-Language: en-US To: Bryan O'Donoghue , Vikram Sharma , rfoss@kernel.org, todor.too@gmail.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, akapatra@quicinc.com, hariramp@quicinc.com, andersson@kernel.org, konradybcio@kernel.org, hverkuil-cisco@xs4all.nl, cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com, will@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com References: <20241127100421.3447601-1-quic_vikramsa@quicinc.com> <20241127100421.3447601-2-quic_vikramsa@quicinc.com> <1a87e9d9-da7e-4b8b-807e-f56aa15acfc2@linaro.org> <25f89e78-faec-4eba-887b-019eed752064@linaro.org> From: Vladimir Zapolskiy In-Reply-To: <25f89e78-faec-4eba-887b-019eed752064@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Bryan, On 11/28/24 01:31, Bryan O'Donoghue wrote: > On 27/11/2024 12:57, Vladimir Zapolskiy wrote: >>> >>> + camss: camss@acaf000 { >>> + compatible = "qcom,sc7280-camss"; >>> + >>> + reg = <0x0 0x0acb3000 0x0 0x1000>, >>> + <0x0 0x0acc8000 0x0 0x1000>, >> >> Unsurprisingly above is the error, which has been already reported for >> enumerous amount of times, I wish to stop poking it eventually, please >> reference to the previously given review comments and fix all of them >> before sending a new version of the changes. > > So just to be clear what is wrong here because it may not be clear. > > 1. Sort by IP name > 2. The first address @ reg should be equal to the address @ camss > > -> Documentation/devicetree/bindings/media/qcom,msm8953-camss.yaml > > camss: camss@1b00020 { > compatible = "qcom,msm8953-camss"; > > reg = <0x1b00020 0x10>, > <0x1b30000 0x100>, > <0x1b30400 0x100>, > <0x1b30800 0x100>, > <0x1b34000 0x1000>, > <0x1b00030 0x4>, > <0x1b35000 0x1000>, > <0x1b00038 0x4>, > <0x1b36000 0x1000>, > <0x1b00040 0x4>, > <0x1b31000 0x500>, > <0x1b10000 0x1000>, > <0x1b14000 0x1000>; > reg-names = "csi_clk_mux", > "csid0", > "csid1", > "csid2", > "csiphy0", > "csiphy0_clk_mux", > "csiphy1", > "csiphy1_clk_mux", > "csiphy2", > "csiphy2_clk_mux", > "ispif", > "vfe0", > "vfe1"; > So: > > camss: camss@acaf000 { > compatible = "qcom,sc7280-camss"; > > reg = <0x0 0x0acaf000 0x0 0x4000>, > <0x0 0x0acb3000 0x0 0x1000>, > <0x0 0x0acc8000 0x0 0x1000>, > <0x0 0x0acba000 0x0 0x1000>, > <0x0 0x0accf000 0x0 0x1000>, > <0x0 0x0acc1000 0x0 0x1000>, > <0x0 0x0ace0000 0x0 0x2000>, > <0x0 0x0ace2000 0x0 0x2000>, > <0x0 0x0ace4000 0x0 0x2000>, > <0x0 0x0ace6000 0x0 0x2000>, > <0x0 0x0ace8000 0x0 0x2000>, > <0x0 0x0acc4000 0x0 0x4000>, > <0x0 0x0acb6000 0x0 0x4000>, > <0x0 0x0accb000 0x0 0x4000>, > <0x0 0x0acbd000 0x0 0x4000>; > reg-names = "vfe0", > "csid0", > "csid0_lite", > "csid1", > "csid1_lite", > "csid2", > "csiphy0", > "csiphy1", > "csiphy2", > "csiphy3", > "csiphy4", > "vfe0_lite", > "vfe1", > "vfe1_lite", > "vfe2"; So, apparently it is the third and the new proposed order of sorting. Any following scheme is worse than the previous one in my opinion, but why not. -- Best wishes, Vladimir