From: Bastien Nocera <hadess@hadess.net>
To: Luke Jones <luke@ljones.dev>
Cc: linux-kernel@vger.kernel.org, hdegoede@redhat.com,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v4 1/1] asus-wmi: Add support for custom fan curves
Date: Fri, 20 Aug 2021 12:43:17 +0200 [thread overview]
Message-ID: <e7fbcf85f61b5c727a93df07b3bfe1624547067f.camel@hadess.net> (raw)
In-Reply-To: <L0W4YQ.ZVWQDLFJE8NR2@ljones.dev>
On Fri, 2021-08-20 at 22:33 +1200, Luke Jones wrote:
> > Am I going to get bug reports from Asus users that will complain
> > that
> > power-profiles-daemon doesn't work correctly, where I will have to
> > wearily ask if they're using an Asus Rog laptop?
>
> No. Definitely not. The changes to fan curves per-profile need to be
> explicitly enabled and set. So a new user will be unaware that this
> control exists (until they look for it) and their laptop will behave
> exactly as default.
"The user will need to change the fan curves manually so will
definitely remember to mention it in bug reports" is a very different
thing to "the user can't change the fan curves to be nonsensical and
mean opposite things".
I can assure you that I will eventually get bug reports from "power
users" who break their setup and wonder why things don't work properly,
without ever mentioning the changes they made changes to the fan
curves, or anything else they might have changed.
next prev parent reply other threads:[~2021-08-20 10:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 9:57 [PATCH v4 0/1] " Luke D. Jones
2021-08-20 9:57 ` [PATCH v4 1/1] " Luke D. Jones
2021-08-20 10:18 ` Bastien Nocera
2021-08-20 10:33 ` Luke Jones
2021-08-20 10:43 ` Bastien Nocera [this message]
2021-08-20 10:51 ` Bastien Nocera
2021-08-20 11:00 ` Luke Jones
2021-08-20 11:39 ` Bastien Nocera
2021-08-20 21:30 ` Luke Jones
2021-08-23 10:28 ` Bastien Nocera
2021-08-23 11:26 ` Luke Jones
2021-08-23 11:45 ` Hans de Goede
2021-08-24 12:33 ` Bastien Nocera
2021-08-24 15:45 ` Hans de Goede
2021-08-20 10:59 ` Luke Jones
2021-08-20 10:05 ` [PATCH v4 0/1] " Hans de Goede
2021-08-20 10:08 ` Luke Jones
2021-08-26 23:09 ` Luke Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7fbcf85f61b5c727a93df07b3bfe1624547067f.camel@hadess.net \
--to=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®