From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754155AbdIYSsz (ORCPT ); Mon, 25 Sep 2017 14:48:55 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:35693 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753886AbdIYSsy (ORCPT ); Mon, 25 Sep 2017 14:48:54 -0400 X-Google-Smtp-Source: AOwi7QBurmCJZ/3JMbJksHl9jyR55ky0GzLO0QTPLO1UJoV9Cv3TyE+g7/i7IsoxFndVjn+45tmYNA== Subject: Re: [PATCH] [v2] soc: bcm: brcmstb: fix ARM build errors To: Florian Fainelli , Arnd Bergmann Cc: Brian Norris , Gregory Fong , bcm-kernel-feedback-list@broadcom.com, Justin Chen , Markus Mayer , Doug Berger , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20170911201324.3423067-1-arnd@arndb.de> <95917630-de47-cb0c-f7bf-5742927e11f1@gmail.com> From: Florian Fainelli Message-ID: Date: Mon, 25 Sep 2017 11:48:49 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <95917630-de47-cb0c-f7bf-5742927e11f1@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/12/2017 10:56 AM, Florian Fainelli wrote: > On 09/11/2017 01:13 PM, Arnd Bergmann wrote: >> When building the new PM driver on older ARM architectures, we can >> run into one of two build errors: >> >> drivers/soc/bcm/brcmstb/pm/pm-arm.c: In function 'brcmstb_do_pmsm_power_down': >> drivers/soc/bcm/brcmstb/pm/pm-arm.c:334:2: error: implicit declaration of function 'wfi' [-Werror=implicit-function-declaration] >> >> drivers/soc/bcm/brcmstb/pm/pm-arm.o: In function `brcmstb_pm_s3_finish': >> pm-arm.c:(.text+0x860): undefined reference to `cpu_resume' >> >> The first one requires at least ARMv6K, the second one requires the CPU >> suspend/resume logic which is not available on some of the older CPUs, >> and needs to be selected explicitly. >> >> This adds the extra Kconfig statements to enforce this, limiting >> compilation on ARM to the STB platform that is guaranteed to be >> ARMv7. We could enable compile-testing for other ARMv7 platforms, >> but there seems to be little value as an allmodconfig kernel >> already includes it. > > Thanks, can you pick that change directly and/or fold it in: > > 6274ca43eba1b2ebcac96f3c9b41fbc4945c0af0 ("soc: bcm: brcmstb: Add > support for S2/S3/S5 suspend states (ARM)")? Picked this up in drivers/next, and squashed this change into the original commit, this is what it looks like now: https://github.com/Broadcom/stblinux/commit/6274ca43eba1b2ebcac96f3c9b41fbc4945c0af0 Thanks Arnd! -- -- Florian