From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753267AbdC1P5O (ORCPT ); Tue, 28 Mar 2017 11:57:14 -0400 Received: from mail-cys01nam02on0085.outbound.protection.outlook.com ([104.47.37.85]:56093 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752228AbdC1P5L (ORCPT ); Tue, 28 Mar 2017 11:57:11 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH 1/2] crypto: ccp - Reduce stack frame size with KASAN To: Arnd Bergmann , "Hook, Gary" References: <20170328095814.3734615-1-arnd@arndb.de> CC: "Lendacky, Thomas" , Herbert Xu , "David S. Miller" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Gary R Hook Message-ID: Date: Tue, 28 Mar 2017 10:56:55 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR10CA0001.namprd10.prod.outlook.com (10.172.48.11) To SN1PR12MB0479.namprd12.prod.outlook.com (10.162.105.148) X-MS-Office365-Filtering-Correlation-Id: 92e35835-63c3-4651-b026-08d475f313ce X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(201703131423062)(201703031133068);SRVR:SN1PR12MB0479; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0479;3:/UfR6tMQBOgoJyJ3u+THTJUlqtfOu2CtEIvTuvFltsh6yoJgenwRI+CyUc1IrHRPbEkHAbc4eLH3BNMYN9MlnrqQzn95Jt2vvzhu0gLzeLWoxAY4Pc+tVfvnHN6WLXOiM+svVVs8Q1iMrr3hKozVUsGTgFmzu2Sy6GqUj6D2C5arsoh9QnhNT9WyvMI31dk/kV1kbmK5WwGjMLrmMcNIRA1bpqxi3XpULPcEJkSVmIHPt6ZlcHGDWKdHAUNuOXy5H0arjrytF6Ay+QJCeNVMcrfl1EWolYx235SLqTCYgltpkaTaCBx/+rFglwPG1VXuD/Q3jOH9xtZc9Ik5Cx1a3CVxPZUcwWJ1DC+cFjsfyWg=;25:o0DhV3ri+H43HG1nF2rxwNxGfR/XDezP3k/KUYO3zXaQ7fxgq0I+7MEEKu2e8nufDKWvgnVPmrhGdTVR+jLvZPUrNWmN4mYC7HgQZvGF355bm2Mx3daKJLg6UbMBfp8lamsuZQBguJpeXswaAUyxsLCBy9QN7/ns8M6uDwKgbdckX1GNFUKSz9ZIgV+8suqxb3p12Fy+pv88VBrZqIszGISjeILLmFQ6M3FvqLbtpJ/PWs6QvDk93IbEsmjL/91EAak4AQmCys1yMxYDW9nZBRFy0kE9Pp53Vhh1Ug8RppAFj7/fJOldic4mr0fMVJw8H8Omnaust1y3J2UCdQvJX90ubgfMHRobi1LtQDyUlXrSUVoZaXu6fjK0gXIy4slhe6P8eG4hdcpfaBriQ36s4Cts/TWdoZcIBmZaHeax463fX/vHQA+4h8NUw2u7rRAXdLiKQl8qVlxpSZGOyOQbTg== X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0479;31:pvaYtP742MVyheQn7XE5IafLcRzi+7Lya8UtuGsn822RsYR6xFEL23hOq6XVUQjlHKbbB8lnJZ9UQSKrhgcMrwxcZWlhN45MmAoN6BX+wSor5k4sShEVq9hQMUWvjT2F8Fmo7NsL1tZIkU2biOQaLWlkawQDh8YQcIWgst9UGqii7962ttSEAMA31o5I7CVEV2EyOu+Oeh/HAyj3AFH5d34wPSbNvoGQ9wWHqTspXTk=;20:3AYeHOPS4HmDv0R28RqYs4n80K1s+pHnl9acO+jo4SmpkloWsGteMUr0/1YcgKAbcDW7TeOECjn4UPfz52kt3pRucrrcmlHD172z2cFLSiOEUlTak6eIG3i9ZDL7ZzqtR16mTh8Zo3WKvARIy3MaYTDaQdw9TZMBE3js84ksq0ot2F5uq/twl46uCscZyamdCjvcr3gBISdeq+182NoJW1SpYJPYNYcg8muFjPXZ8HuRCVXf0/p3gm/avmJAnFo8xwBCyZOMY8zmmeZOoMuze/43fruc2laeWhYiljAo5g/88dbiMcMv4Va6SopPpbatyu7lZ5F9ringw94umJ3wpFI948LatRdYwZZi0W4YkZ53ytlamRbxnZ+ImjS6beKTMzGJfPZcLnry7FNmOB4IQ1zpHxwQm5ITjTjtOBlV8juXtW/LI/SoYFd4WgAM4DHB1eBbE/j89WtZdRmssBuQC5EWjSNveKNpNrtc3AIredj6BzDdiz70L0GniEd8aZmd X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(148322886591682)(81227570615382); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040437)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(201703131423062)(201702281528062)(201703061421062)(201703061406062)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(20161123558025)(6072148);SRVR:SN1PR12MB0479;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0479; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0479;4:LGYgQXNYzR5n2PkX2rokyvWJCaqZZe86X7Q1108JeHs7Tzxu+JYsLU+FbhMC+WDn+4YAsoy9uAS3lxKPkBcXprM+KNmJo7rOmBYPkS+OHyLXBwDkAT3r+RnnTv5uJXer4ILAM79ImWbxwOu/lci0YTTa0t3RnBo9PaOWeludHEkkgkh/nSXrqx9crh2CYKg5UJZKKK/YR9zdJoOwHF/S5iD4ytVWISx63eTbLDjHDHi0LUCtZZ+sPUp7EaWRW2SxWQSMunFayNBcY/56qzGf9ErlicO8bZgksxE2XCkQM5tXjYITHy2HZODHFQTEWn/swl88YP2c6X5/9rgh4lglQv1Em3Y+MnglaiwFPgOhIW+IEKfhrgDm4KfgRyS365qul6M+ko+6LOd43KjrihIbF6+4aM/8TxpjNXmzBYPR5r8u0/56rYlKk+9vPcXYi3+DATsQZyQE6MvEWaix6AX5pxKpCPRhh5MnfFKIMcES0WsL2J1FiK2SHCy87jGTbyet0/i2g6twlEnMvP3TgOTaWKYV8qAoGzyi3N9z21B9R8NCnqVOOOC3XL4cIqOOfiuL0edD0fIcqsU/IbcmGkD3aefqYHc7jirDI+SBdPAmQguYRRbR5Q8FPCUU9rAeBfO3I4fhlWhI7cRh6cicmXeD+6B6RXpm85Idcij/eecHEhlpenOP0tPAIy7LfUn3MzqT+KOG0bMgaCmL0FsCN3vsS2nn0WleVl3xWKmL7kr+E2nub5dgJmIJUBKE7/0LQ7lK6Mi9KuqCnQKSt01TU7Z1SO082MrCsYcsAkPMgmcs/wcyFXUB/b8xK1gt2d7elAbTguvgXeNeLp8CocaM8sUtHA== X-Forefront-PRVS: 0260457E99 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(39860400002)(39450400003)(39410400002)(39840400002)(39400400002)(39850400002)(377454003)(24454002)(2906002)(6666003)(6246003)(6486002)(90366009)(229853002)(77096006)(25786009)(6636002)(53546009)(3846002)(4326008)(31696002)(53936002)(2950100002)(23676002)(230700001)(38730400002)(54906002)(31686004)(42186005)(6116002)(5660300001)(305945005)(64126003)(36756003)(7736002)(83506001)(47776003)(33646002)(50466002)(8676002)(65826007)(81166006)(4001350100001)(66066001)(189998001)(50986999)(65806001)(65956001)(76176999)(54356999);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0479;H:[10.236.19.127];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwNDc5OzIzOkJEZGhtUmx3MHdpWVFBRmdkZGdEMlM1ck5R?= =?utf-8?B?dVIzajQ0enFxZlZrMEdXdFNkY2NoNzc0Y01OQVhlNHVERUlYeHFnUVJ0K012?= =?utf-8?B?V3I4SmdQTXpkaVhoS3o3WExQOGc5SVRqMy9zUFNxYmVuYmtqV3J3L1FPZWR6?= =?utf-8?B?RzhabW9Eemp1akloM2w0eVhpMFFOVnRlc0I3L1pDcE5OM1A1ekl0VTc2ejha?= =?utf-8?B?d0pFTi9GT3hXU2lqaVJ5UjNVTUVDdE9ZYjl1TkJ2MTg0NFM2VzgxWWxtTWJB?= =?utf-8?B?Uno3aWhpaFV2QzNUQWJNQW9rcG9PSDhrWkJTclYrOFVnMmpHUzZxbHN4VG9r?= =?utf-8?B?WUNpemh2dndTT1VhbFNEeU56U3BSbXdidW5KL084dGsvTXNmTm9wbjJVZ1VX?= =?utf-8?B?QS9DaEZFMTJEUDRabDUzd1JHeHFkREhxWXlsakR4SzZxMkhFQUc4SFJhbVhR?= =?utf-8?B?SzRxUXV4Vm1qRmV5dlRuYytUdnJqc1N4VWoyNXFiMk9lbFZTUWswTmFHSWlE?= =?utf-8?B?dmJUVFFYOHZmYWhLUGRwd0VuTnFjVmN5WDM4bFErN0svenNVS0oycVJxeVNl?= =?utf-8?B?UG1SaXRkd0ZlWFlaQUlpYlBlcGVZUjBQZkxtaEo1R29oUGNLUEdGckMrWklY?= =?utf-8?B?OFpCTi9YWTJzWVVEQzFRamQ1cmNORVlBM3c5Q0JEeDN6Vks0RHpRSWdlSllV?= =?utf-8?B?OW9zR2xYT04vZTBDQjhyMTE4dEdKQmRaa0YxSFdGNm9FVWlnclFUcVNCMklB?= =?utf-8?B?VyttOUV6eUNOV1EvcHE3NFFPMVNoa2JQOUZ6bmVRMEp2S1FpSXp3cXNLU2pY?= =?utf-8?B?MjVqTFlXNnJSSGR3T2JBUEIzVmdYbWx4QTV0dXRYYzdjVEp6T1J5YzZHaVBo?= =?utf-8?B?WGxoa1dsdUJLemM2aXM5VFNNUGZ3RmNMR3hPR3NkT2ZxN3V3SmtLTE5JM1VT?= =?utf-8?B?cUtRc2diVzVrY3llcHBuZDNNNnJuS0dKcTQ1MUhaR1NJR3Z2UWt4RmRwWElX?= =?utf-8?B?d094bGVLYmpsa0VhSUFtdjJUSXhDVGVhZUV6WWNWYU4rNytzc1YzNDNFRGpa?= =?utf-8?B?eUtPZyt4ZVNGVDEyTFZNYlZWTC9JVnBPcHBadmF1US9iUWNhZVg5TTRXOUc2?= =?utf-8?B?QU1GYklRSmhSSWxtRkNDTEg2a3pnMDY5MWpKTUlNUmc0YmlBVVU1ZnhjM0RX?= =?utf-8?B?VEZ0ei9aMVNKMjhvVlFPRVFjWE1zMWNQYmZmWExuMDMzMWtUcTA1WWZOeG1X?= =?utf-8?B?STl1cFFxdUgwbHlRUzFiUjIzTGkvL1ZTeXhBUEVMZFE3ODkwK0MwcmlqK1Vx?= =?utf-8?B?QTJOUzlWMUkycDVsTFFSYnFOY0R5bUFtTWFqT3hUK2ZpRVd0c21yeVRrM0li?= =?utf-8?B?VE14dTJUZGlYK25rdmU3eWVPRGhRNFhCdS95TVNQbk5yU0tVeG5Fc1UrMlNQ?= =?utf-8?B?K0tVNFZ2Njg0UkYwSTc3dGhIOUdJY1paSXdLWXdFV2J4ZUV2Z1FkanZPbXJx?= =?utf-8?B?ZlRvRFZMMGh3WWdGR0JNZTIvQWh2dzZNUUN5bU8yckJJcGI5Y0N5SXZjN24r?= =?utf-8?B?bDROOHFiL3BsMG5PUitJaGE4UFZDZ2xhZnJoclRQTlVMSWpsazFJVS9xdytG?= =?utf-8?B?L1NmQURxT3d5cGFRYytxcy9WSkJYV2o0ME9LcHdEMVF4UFFHbmtIMXpod1Rl?= =?utf-8?B?WXpxZzBLUWpReXBrWU80RDFDNDR3OTNmWWtuVktQUkZxNmhJTndhd1N0UEUz?= =?utf-8?Q?P9UOQ9BQu7n9Ykms1rbsnJKJkS3h6z/7uRcT0=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0479;6:UsbfnPb2JGAKKpreRJEU0aTsKKQu73yOh4uA8uTK7eUIq24F2PfmBqu9WbOntyea3FdJBxwVXHDY3FEqAosfOoyBuWomcEiBz6OtVbhnE78t4Hr1z+4IKmow6HbawAENE0b+W0XVgKk6OPg9yeH2USb9DxgESoU7gscDlTBXuxYq9lwCT+SHPI5bxqvZ43AMSG3RsyUixp37V0fN7bmxYTZEiUP6gI4zgj6RoH139ke+bur7JSscczwCLM05gY7oV+mdl71q5MwkGQfdMQPfkHJiTZaVB4daATk7F+FpmiHjgs6+wXIo570k5cz90XpUPr/wR+OnzYqzMhwf4bPf4ZadkDmHL8vHJptx0DM5PHjw2hw/DFkeDB+U8G0kSb0AUq5YiSO4ELTXOrJY3do/Eaki0wY6n5ur0FVO8B8z1sQ=;5:Cx3bvvyz4s0V+5Wk6Jjll6Af3rbgM1iKuEN5U/Yip5wXxJmQpseoXtd1r/Hr0jhGBQvqqrFFcere9y68M3H3J+4MXPf5IpsYk3OLFSYhRiq3lN/EQFRWnDZ1Cdcl/OXxD6hl5o9rdkjjvG6vL39dvg==;24:GLx4nGxFp8ptc+ANTIwAy3/dMAsWCTQytJPX3u9Y8LsUff1yXLP1siM7wZNMJ0WL/JBYR1StxnLHWYG1MKvXqgOK7uuWeYlqOB36pcyaalE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0479;7:9c9DpGRTm8g23Viwd0jfRY+ja4HSePB6X94c5MECWnaLB3bnexsUA7LwpxWCowp+gk2ypyMXMiHAoG6rWfI9ICBs0df4xo2P1b7PMUDno6YrmCiDxk0q6H4jPHTOIaXOcFWrTN+n5l1Qng0Iq0DxqZ3/es9mENnXmIKxcLf4HvD4/iIP6n1/7+8AGDAWB3Gcy3+P7FQNjJ4KjcG8iacGOwJ6JQJePWL2zbl62vYsobg5vAxRHeO7Fk9uYx6Q0nGuvbEEnN3/64lAi4c9Q3JWMKil/nFgU7u+hT2XNTNtzOGSbdBLK/lZFcVcWP0oWC0FigL2tNYosD807wx3VjIABA==;20:oBV2+ACegdoB2UZIjlQdJEELc96WDkw0MQdFoLEAXaDeU/uXl8vbOOxNDFhrwknyk/dZbBlT/QuhTgOEYR2L+cqpriVeZszzq74g4hLjtBzgSY3NuSLlMvtP4Vcd8cX+jlzN/wJdbu9NBI+8iqo27izR/Tefm3ODOHSvrS8ePGOWcrwJGG5IH604B9PBT0ixUP9Y0PrXbYIzUuab0kDfnGSc8/JWEDW2iGAbrRO6yaS/M70rzVNTx/pJVbSxob4i X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2017 15:57:02.6939 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0479 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/28/2017 10:10 AM, Arnd Bergmann wrote: >>> -}; >>> +} __packed __aligned(4); >> >> My gcc 4.8 doesn't understand __aligned(). Shouldn't we use >> #pragma(4) here? > > That is odd, the __aligned() macro gets defined for all compiler versions > in linux/compiler.h, and the aligned attribute should work for all supported > compilers (3.2 and higher), while #pragma pack() requires gcc-4.0 or > higher. > Tried again in a couple of trees. Not sure what I did wrong, but the compiler seems to be happy now. Huh. Will submit a V2. -- This is my day job. Follow me at: IG/Twitter/Facebook: @grhookphoto IG/Twitter/Facebook: @grhphotographer