From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B0C43CAA59 for ; Tue, 2 Jun 2026 14:20:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780410019; cv=none; b=Rab3maD+9eY3A5k21Q6VFevMQxFAyk5583ydqFpSa78J8+drHCjPG4ULztMOff+JiDvhFV1GuZtWm577ms0oP8nMbQogBLVtWqVpaCDd7fSKYycynoEUEs3a4jptIo+IwAya74iDB+9fQmt7aYR21b0s0eEffEiIXY24b2tNWqE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780410019; c=relaxed/simple; bh=gWZENFnUAaRVr6ZZ1tYRFlHuexmR2VG5OI/Dx4btvWg=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=h4zh++Log1o9AB/Z3GGPKM9XXEbm4R5+XCWgjreFGIJI4UET2yz0HgrPWmVxvpbajZU6gA/0gKC/bFOxgaZAu6nxYm6454B8Xj5oKB18BUcS0sBFndr60/j+lDVi8PRVzWaYsMTvFCjShFr2bBpHucK/buf1/vPZ19YWUTdtBB4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EyY4W+Ts; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=cp1jm09N; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EyY4W+Ts"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="cp1jm09N" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780410017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rSz3RdhwhpdG6SJv/JipBQkzKuAPDGbzpB4LZ5RrYSI=; b=EyY4W+Ts6HtK5tmX6rLwXiJG2lvABf092h6TdcJLxlPXIS7SWb0BVGC1MPoc0ADSkzuQ3W hjIsGj3IoSjMaA46Dx3MX4nCw5lj0xfOcmRmmjmsiL42IehLDBhz5gek9OE8uugd2jPX+K Vsv5lDcMfet+3InwMUg1WwcmBvhny7s= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-76-d0D_mf5zPn2ACNDlfzPrdw-1; Tue, 02 Jun 2026 10:20:14 -0400 X-MC-Unique: d0D_mf5zPn2ACNDlfzPrdw-1 X-Mimecast-MFC-AGG-ID: d0D_mf5zPn2ACNDlfzPrdw_1780410014 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8cce2b4c290so100380326d6.3 for ; Tue, 02 Jun 2026 07:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780410014; x=1781014814; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=rSz3RdhwhpdG6SJv/JipBQkzKuAPDGbzpB4LZ5RrYSI=; b=cp1jm09N+YLjs5X6t5tcfh7YB+2li3ld3IZVDbYWdNq/2EX+J+VgTRpSZ2gck4QvN4 fP9nh7iavMaEHpRJ8BDF6FOf4ln07/AzduhYxEIzzaR3fSuv37n4v5T6kfStC7xQDb+x h+MJn8TFH9uMHa9zdU+NHgccdaOHhTJk+FKJZijOIErEqJEVGTT46Ue+/1A5YrkR5EK4 d5quaDkFeIzoYOYwarcb4740F2l7Q2GivzVSrociKlELlV6qP314dDoyaXqFjY3bzOKh kcRquKUi/UybHQceiqzZ7PYALU5FR+0TstVdTLarZ7w/o1wGxit7Bb7jCq9JVwVnZOW7 YinA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780410014; x=1781014814; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rSz3RdhwhpdG6SJv/JipBQkzKuAPDGbzpB4LZ5RrYSI=; b=GNvHSjVVYPl3cb1fRzBWinpDgU5fhEAfwQfgGRsMOTHGkYr0QcuJUe8qDLXKD5SNhL UcYGxpwx9F4FUQQIy9hd/M4Hd0JAR44SfRATHI/J7u/Qq68+TFv40MKPaLUL3tgTWhF1 pmqx4yzEWP7OxFomNBICVEj6xy/baQeL/+KdpCKckohpM9vMzLLhFBZK8Ql/GARXwtD7 95/m4n1qj1OhIFh6fJBn+2/ouSwSM69+X0cDtN7WQRC1HzRSApCb2PtlOcnTVLho5nBW 9O5QV00vyAex64EVEDNUhfFUL8t4OJsltac4IK9clDiwv3Sr/hPhj8fIyemh+SgO9KWD lbyw== X-Forwarded-Encrypted: i=1; AFNElJ/rmkgpUqapLoCpRIVVfl89YCyi2YcPV1/0viLgClTl0A70BqmRN1UyKVPm0NPVO6cnJ6wFS46ZFOiaBRc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1qtADf4D096187gtpqMsdEi4Gr89id4VNnj/IIkQQfXQe6ENJ CDujkKgNTo4bgancpGO+/q5k3ftlqib3WJsfk1j0Tv9iT2U3fIvAgxjKBRrVzif5HdvFGKqeYDx piJ0vxSI9lo9/vWauFP/5pjwVwIfODRR79SRvDrjpf7QrfUzdX75Jc2YR2mytMdfm0w== X-Gm-Gg: Acq92OGziEmJLPAFxvUt2L1OFLlOlkTRxWEgDLXeUEk77LN/bc/JIKSDdUs3LAQ1jWx IuTSKWN43+kcyDiMv1RdgHz8afmMcDjZvDGFg0IOj1hUyEyr6pS+kGMOfNkbapy6XLsF3gpl3Ns TmqXGIHtC62v23Nh0+iZ014PWlwGt/bR65ih2ZJMaz9Acac9LxSB3EarS9BJ6uR9YVs4gOMgjZ7 adOQ5bRmiEGEL+S14udsqeS1QTQcJsQljJBhBcQ3Ep+rk1/zddfeCLFGUDnWGeQl5/6IdfUD4RT /nGZpSh82WhaEY6UUaKdmG8LJ/91Ix9DtPkB+qMBEPJ/EbDvwn00lg36gZrXqKmjfFTxg4MWB5/ m39VmpvmWShR29xCGiQpCKOjT/T56Ev58wJMuNh8= X-Received: by 2002:a05:6214:23cd:b0:8ac:bb62:fe52 with SMTP id 6a1803df08f44-8ccefd32da9mr246440196d6.4.1780410013948; Tue, 02 Jun 2026 07:20:13 -0700 (PDT) X-Received: by 2002:a05:6214:23cd:b0:8ac:bb62:fe52 with SMTP id 6a1803df08f44-8ccefd32da9mr246439746d6.4.1780410013497; Tue, 02 Jun 2026 07:20:13 -0700 (PDT) Received: from intellaptop.lan ([2607:fea8:fc01:88aa:f1de:f35:7935:804f]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ccea085db2sm120136616d6.18.2026.06.02.07.20.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 07:20:12 -0700 (PDT) Message-ID: Subject: Re: [PATCH 02/28] KVM: x86/mmu: remove SPTE_PERM_MASK From: mlevitsk@redhat.com To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: d.riley@proxmox.com, jon@nutanix.com Date: Tue, 02 Jun 2026 10:20:11 -0400 In-Reply-To: <20260505195226.563317-3-pbonzini@redhat.com> References: <20260505195226.563317-1-pbonzini@redhat.com> <20260505195226.563317-3-pbonzini@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-2.fc40) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-05-05 at 21:52 +0200, Paolo Bonzini wrote: > From: Jon Kohler >=20 > SPTE_PERM_MASK is no longer referenced by anything in the kernel. It might be worth adding a note saying that this macro has been unused for = a long time. (to help with backports)=20 The last commit that referenced it was this one, if I am not mistaken: commit 1441ca1494d74a2c9d6c9bd8dd633d9ebff1daba Author: Junaid Shahid Date: Fri Jul 22 19:43:16 2022 -0700 kvm: x86: mmu: Drop the need_remote_flush() function =20 This is only used by kvm_mmu_pte_write(), which no longer actually creates the new SPTE and instead just clears the old SPTE. So we just need to check if the old SPTE was shadow-present instead of calling need_remote_flush(). Hence we can drop this function. It was incomplete anyway as it didn't take access-tracking into account. =20 This patch should not result in any functional change. =20 Signed-off-by: Junaid Shahid Reviewed-by: David Matlack Reviewed-by: Sean Christopherson Message-Id: <20220723024316.2725328-1-junaids@google.com> Signed-off-by: Paolo Bonzini >=20 > Signed-off-by: Jon Kohler > Message-ID: <20251223054806.1611168-3-jon@nutanix.com> > Tested-by: David Riley > Signed-off-by: Paolo Bonzini > --- > =C2=A0arch/x86/kvm/mmu/spte.h | 3 --- > =C2=A01 file changed, 3 deletions(-) >=20 > diff --git a/arch/x86/kvm/mmu/spte.h b/arch/x86/kvm/mmu/spte.h > index 91ce29fd6f1b..28086fa86fe0 100644 > --- a/arch/x86/kvm/mmu/spte.h > +++ b/arch/x86/kvm/mmu/spte.h > @@ -42,9 +42,6 @@ static_assert(SPTE_TDP_AD_ENABLED =3D=3D 0); > =C2=A0#define SPTE_BASE_ADDR_MASK (((1ULL << 52) - 1) & ~(u64)(PAGE_SIZE-= 1)) > =C2=A0#endif > =C2=A0 > -#define SPTE_PERM_MASK (PT_PRESENT_MASK | PT_WRITABLE_MASK | shadow_user= _mask \ > - | shadow_x_mask | shadow_nx_mask | shadow_me_mask) > - > =C2=A0#define ACC_EXEC_MASK=C2=A0=C2=A0=C2=A0 1 > =C2=A0#define ACC_WRITE_MASK=C2=A0=C2=A0 PT_WRITABLE_MASK > =C2=A0#define ACC_USER_MASK=C2=A0=C2=A0=C2=A0 PT_USER_MASK Reviewed-by: Maxim Levitsky Best regards, Maxim Levitsky