mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Yuti Amonkar <yamonkar@cadence.com>,
	<linux-kernel@vger.kernel.org>, <mark.rutland@arm.com>,
	<maxime@cerno.tech>
Cc: <jsarha@ti.com>, <tomi.valkeinen@ti.com>, <praneeth@ti.com>,
	<mparab@cadence.com>, <sjakhade@cadence.com>
Subject: Re: [PATCH v1] phy: Add max_link_rate as a PHY attribute along with get/set APIs
Date: Mon, 27 Apr 2020 18:20:00 +0530	[thread overview]
Message-ID: <e81446f8-9ec1-01c2-b4b4-d8ff4b63338f@ti.com> (raw)
In-Reply-To: <1587789560-16440-1-git-send-email-yamonkar@cadence.com>

Hi Yuti,

On 4/25/2020 10:09 AM, Yuti Amonkar wrote:
> The patch adds a pair of APIs that allow the generic PHY subsystem to
> provide information on the maximum value of link rate supported by the
> PHY. The PHY provider driver may use phy_set_max_link_rate() to set the
> maximum link rate that the PHY supports. The controller driver may then
> use phy_get_max_link_rate() to fetch the PHY link rate in order to
> properly configure the controller.
> 
> Signed-off-by: Yuti Amonkar <yamonkar@cadence.com>

This patch should preferably be sent along with the patch that uses these
functions (unless you have some specific reason).

Thanks
Kishon

> ---
>  include/linux/phy/phy.h | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
> index bcee8eba62b3..a8b7b4a2b8de 100644
> --- a/include/linux/phy/phy.h
> +++ b/include/linux/phy/phy.h
> @@ -119,6 +119,7 @@ struct phy_ops {
>   */
>  struct phy_attrs {
>  	u32			bus_width;
> +	u32			max_link_rate;
>  	enum phy_mode		mode;
>  };
>  
> @@ -231,6 +232,16 @@ static inline void phy_set_bus_width(struct phy *phy, int bus_width)
>  {
>  	phy->attrs.bus_width = bus_width;
>  }
> +
> +static inline int phy_get_max_link_rate(struct phy *phy)
> +{
> +	return phy->attrs.max_link_rate;
> +}
> +
> +static inline void phy_set_max_link_rate(struct phy *phy, int link_rate)
> +{
> +	phy->attrs.max_link_rate = link_rate;
> +}
>  struct phy *phy_get(struct device *dev, const char *string);
>  struct phy *phy_optional_get(struct device *dev, const char *string);
>  struct phy *devm_phy_get(struct device *dev, const char *string);
> @@ -389,6 +400,16 @@ static inline void phy_set_bus_width(struct phy *phy, int bus_width)
>  	return;
>  }
>  
> +static inline int phy_get_max_link_rate(struct phy *phy)
> +{
> +	return -ENOSYS;
> +}
> +
> +static inline void phy_set_max_link_rate(struct phy *phy, int link_rate)
> +{
> +	return;
> +}
> +
>  static inline struct phy *phy_get(struct device *dev, const char *string)
>  {
>  	return ERR_PTR(-ENOSYS);
> 

      reply	other threads:[~2020-04-27 12:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-25  4:39 Yuti Amonkar
2020-04-27 12:50 ` Kishon Vijay Abraham I [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e81446f8-9ec1-01c2-b4b4-d8ff4b63338f@ti.com \
    --to=kishon@ti.com \
    --cc=jsarha@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime@cerno.tech \
    --cc=mparab@cadence.com \
    --cc=praneeth@ti.com \
    --cc=sjakhade@cadence.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=yamonkar@cadence.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®