From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96425126F1E; Tue, 27 Aug 2024 17:51:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724781116; cv=none; b=OeXpTrPepT6k0xiYmpRaE5WeIhdJHiXtbP1lb48r86o4iMllZZhwBdkzqt2QJJs/PqOwCNVYiwuKRwhIkvkVJPvlzoAC1whxyJ5T0fciUJ/8e2xNJkvgNdurhtD++z3zbERiH5CMDJBNTckBnlJ1QE+jpBGFuQEtDW5KpYVk1to= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724781116; c=relaxed/simple; bh=WYtYG9o71Hsb4E3lWlAI+SjyLQu0C+6fMS+CwtNGWl4=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=fjFpHtU6/rmJ3s2Yr4sLlE6KJGGx7y5z6zm5FOLYFo1NbCZVkFuKqyo3ECXVrXNN5/x7UkTWXPW4z6nRv7d13IEaGHwSWSKf8fgmGrLmNwDQRZTTr4hWzHobd9Hl/sb9O97LeUlBnC/UY/LIvmdyXhhs+1w24vGfiahJdn2EALw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=h8wlrkMW; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="h8wlrkMW" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 47RGWqRq002804; Tue, 27 Aug 2024 17:51:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kmAQPiK8M0fRx5xm+Hl50rN5MEsIa1ctSGh0cUkukik=; b=h8wlrkMWDWSIggh/ miO7z8Bdn51EHfrCEIQHfV4ZFlO3UZd3YK8z8lsOy4gMHUx6zCCVKZkCnieFqkM4 U2TvROhirTt6v5mh1EwLydUktsV8mP/yg48DdtanWE8URMlr5uQqqoHZbheeZC/G PcdoCa0uHhQqHVTfoL1jVzxumZRN6v2bzlIha45pUcKxCkYuHXVCPuZCkk8t0i9C GCNnCmxzFfgEqLfobg3MttMk4zxEQ/8pF0ogtHGYXJh5SNfweoxgKX/JsU+h5GwV L9vTNf7GpYEwV2f38Rh/tMz7ZXzQ7x5ZuVzurMjRxT7ta0BrbRAtZQ0vl637rAHa a48NOw== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 419aq79rax-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Aug 2024 17:51:03 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 47RHp2oN011551 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Aug 2024 17:51:02 GMT Received: from [10.134.71.247] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Tue, 27 Aug 2024 10:51:02 -0700 Message-ID: Date: Tue, 27 Aug 2024 10:50:47 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] drm/msm: fix %s null argument error To: Sherry Yang , , , , , , , CC: , , , References: <20240827165337.1075904-1-sherry.yang@oracle.com> Content-Language: en-US From: Abhinav Kumar In-Reply-To: <20240827165337.1075904-1-sherry.yang@oracle.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: RtvrCThp2LVSkESS0xIZVvJb_RG6hh9L X-Proofpoint-ORIG-GUID: RtvrCThp2LVSkESS0xIZVvJb_RG6hh9L X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-27_10,2024-08-27_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 bulkscore=0 impostorscore=0 spamscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2408270134 On 8/27/2024 9:53 AM, Sherry Yang wrote: > The following build error was triggered because of NULL string argument: > > BUILDSTDERR: drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c: In function 'mdp5_smp_dump': > BUILDSTDERR: drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c:352:51: error: '%s' directive argument is null [-Werror=format-overflow=] > BUILDSTDERR: 352 | drm_printf(p, "%s:%d\t%d\t%s\n", > BUILDSTDERR: | ^~ > BUILDSTDERR: drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c:352:51: error: '%s' directive argument is null [-Werror=format-overflow=] > > This happens from the commit a61ddb4393ad ("drm: enable (most) W=1 > warnings by default across the subsystem"). Using "(null)" instead > to fix it. > > Fixes: bc5289eed481 ("drm/msm/mdp5: add debugfs to show smp block status") > Signed-off-by: Sherry Yang > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > I am not sure how the patch got titled 1/1 and not just "PATCH". It should be just "PATCH" > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c > index 3a7f7edda96b..500b7dc895d0 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c > @@ -351,7 +351,7 @@ void mdp5_smp_dump(struct mdp5_smp *smp, struct drm_printer *p, > > drm_printf(p, "%s:%d\t%d\t%s\n", > pipe2name(pipe), j, inuse, > - plane ? plane->name : NULL); > + plane ? plane->name : "(null)"); > > total += inuse; > } Change itself looks fine to me, Reviewed-by: Abhinav Kumar