From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754760AbdBHPIN (ORCPT ); Wed, 8 Feb 2017 10:08:13 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:24113 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752923AbdBHPII (ORCPT ); Wed, 8 Feb 2017 10:08:08 -0500 Subject: Re: [PATCH] xen-netfront: Rework the fix for Rx stall during OOM and network stress To: Vineeth Remanan Pillai , jgross@suse.com, xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1486493941-15696-1-git-send-email-vineethp@amazon.com> Cc: kamatam@amazon.com, aliguori@amazon.com, guruanb@amazon.com From: Boris Ostrovsky Message-ID: Date: Wed, 8 Feb 2017 10:08:19 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1486493941-15696-1-git-send-email-vineethp@amazon.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/07/2017 01:59 PM, Vineeth Remanan Pillai wrote: > The commit 90c311b0eeea ("xen-netfront: Fix Rx stall during network > stress and OOM") caused the refill timer to be triggerred almost on > all invocations of xennet_alloc_rx_buffers for certain workloads. > This reworks the fix by reverting to the old behaviour and taking into > consideration the skb allocation failure. Refill timer is now triggered > on insufficient requests or skb allocation failure. > > Signed-off-by: Vineeth Remanan Pillai > Fixes: 90c311b0eeea (xen-netfront: Fix Rx stall during network stress and OOM) > Reported-by: Boris Ostrovsky Reviewed-by: Boris Ostrovsky