mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	Sam Ravnborg <sam@ravnborg.org>,
	Daniel Thompson <daniel.thompson@linaro.org>
Cc: linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] sh: ecovec24: Rename missed backlight field from fbdev to dev
Date: Mon, 25 Sep 2023 13:28:48 +0200	[thread overview]
Message-ID: <e81bfc6a-7d14-429a-88bc-3f53ac6a2858@suse.de> (raw)
In-Reply-To: <20230925111022.3626362-1-geert+renesas@glider.be>


[-- Attachment #1.1: Type: text/plain, Size: 1956 bytes --]

Hi

Am 25.09.23 um 13:10 schrieb Geert Uytterhoeven:
> One instance of gpio_backlight_platform_data.fbdev was renamed, but the
> second instance was forgotten, causing a build failure:
> 
>      arch/sh/boards/mach-ecovec24/setup.c: In function ‘arch_setup’:
>      arch/sh/boards/mach-ecovec24/setup.c:1223:37: error: ‘struct gpio_backlight_platform_data’ has no member named ‘fbdev’; did you mean ‘dev’?
>       1223 |                 gpio_backlight_data.fbdev = NULL;
> 	  |                                     ^~~~~
> 	  |                                     dev
> 
> Fix this by updating the second instance.
> 
> Fixes: ed369def91c1579a ("backlight/gpio_backlight: Rename field 'fbdev' to 'dev'")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202309231601.Uu6qcRnU-lkp@intel.com/
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

Sorry for missing this driver in the original patch.

Best regards
Thomas

> ---
>   arch/sh/boards/mach-ecovec24/setup.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/sh/boards/mach-ecovec24/setup.c b/arch/sh/boards/mach-ecovec24/setup.c
> index 3be293335de54512..7a788d44cc73496c 100644
> --- a/arch/sh/boards/mach-ecovec24/setup.c
> +++ b/arch/sh/boards/mach-ecovec24/setup.c
> @@ -1220,7 +1220,7 @@ static int __init arch_setup(void)
>   		lcdc_info.ch[0].num_modes		= ARRAY_SIZE(ecovec_dvi_modes);
>   
>   		/* No backlight */
> -		gpio_backlight_data.fbdev = NULL;
> +		gpio_backlight_data.dev = NULL;
>   
>   		gpio_set_value(GPIO_PTA2, 1);
>   		gpio_set_value(GPIO_PTU1, 1);

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

  reply	other threads:[~2023-09-25 11:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-25 11:10 Geert Uytterhoeven
2023-09-25 11:28 ` Thomas Zimmermann [this message]
2024-01-18 14:57 ` John Paul Adrian Glaubitz
2024-01-19  8:18 ` John Paul Adrian Glaubitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e81bfc6a-7d14-429a-88bc-3f53ac6a2858@suse.de \
    --to=tzimmermann@suse.de \
    --cc=dalias@libc.org \
    --cc=daniel.thompson@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert+renesas@glider.be \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=sam@ravnborg.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®