From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22C11C433E7 for ; Sat, 10 Oct 2020 22:55:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5D6F2075E for ; Sat, 10 Oct 2020 22:55:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389437AbgJJWzl (ORCPT ); Sat, 10 Oct 2020 18:55:41 -0400 Received: from smtprelay0086.hostedemail.com ([216.40.44.86]:52502 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731446AbgJJTXM (ORCPT ); Sat, 10 Oct 2020 15:23:12 -0400 Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave01.hostedemail.com (Postfix) with ESMTP id 852E41801669A for ; Sat, 10 Oct 2020 15:44:04 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id A22061802912A; Sat, 10 Oct 2020 15:38:56 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: join88_5a1154d271ea X-Filterd-Recvd-Size: 2124 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf13.hostedemail.com (Postfix) with ESMTPA; Sat, 10 Oct 2020 15:38:55 +0000 (UTC) Message-ID: Subject: Re: [PATCH] checkpatch: Check for .byte-spelled insn opcodes documentation on x86 From: Joe Perches To: Borislav Petkov Cc: X86 ML , Andrew Morton , Andy Whitcroft , LKML , Peter Zijlstra Date: Sat, 10 Oct 2020 08:38:54 -0700 In-Reply-To: <20201010105421.GA24674@zn.tnic> References: <20201009161423.14583-1-bp@alien8.de> <20201010105421.GA24674@zn.tnic> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2020-10-10 at 12:54 +0200, Borislav Petkov wrote: > > checkpatch uses only a single line output only before $herecurr > > Output line length doesn't matter. [] > WARNING: Please document which binutils version supports these .byte-spelled > insn opcodes by adding "binutils version " in a comment above them. > #90: FILE: arch/x86/include/asm/special_insns.h:254: > + asm volatile(".byte 0x66, 0x0f, 0x38, 0xf8, 0x02" > > > is easier readable than this: > > WARNING: Please document which binutils version supports these .byte-spelledinsn opcodes by adding "binutils version " in a comment above them. > #90: FILE: arch/x86/include/asm/special_insns.h:254: > + asm volatile(".byte 0x66, 0x0f, 0x38, 0xf8, 0x02" Readability is a consideration but it still must be a single line. using --terse requires single line error output Perhaps: if ($comment !~ /\bbinutils version [0-9.]+/ms) { WARN("MISSING_BINUTILS_VERSION", "Please add a comment for .byte-spelled insn opcodes with \"binutils version \"\n" . $herecurr);