mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: David Wu <david.wu@rock-chips.com>, netdev@vger.kernel.org
Cc: andrew+netdev@lunn.ch, Jose.Abreu@synopsys.com,
	davem@davemloft.net, rmk+kernel@armlinux.org.uk,
	lorenzo.bianconi@oss.qualcomm.com, luis.la@mail.de,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: stmmac: dwmac4: schedule RX NAPI on Receive Buffer Unavailable
Date: Thu, 19 Nov 2026 09:11:32 +0100	[thread overview]
Message-ID: <e822871e-73ec-47e7-96e5-e7885e725555@bootlin.com> (raw)
In-Reply-To: <20261117042754.96177-1-david.wu@rock-chips.com>

Hi,

You're missing some people in CC, including the network maintainers...

On 11/17/26 05:27, David Wu wrote:
> Once the RX ring is exhausted, the RX DMA enters the suspend state and
> no more Receive Interrupts can be generated: incoming frames are kept
> in the MTL RX FIFO and are dropped once it overflows. The RX DMA only
> resumes after software refills the ring and updates the RX tail
> pointer, which is done by the RX NAPI poll (stmmac_rx_refill()).
> 
> Commit 1b9707e6f1a9 ("net: stmmac: enable RPS and RBU interrupts")
> enabled the RBU interrupt for dwmac4, but the interrupt handler only
> updates the statistics counter without scheduling the RX NAPI. The RX
> NAPI is therefore never invoked, stmmac_rx_refill() never runs, and
> the RX path hangs forever once the ring has been exhausted.
> 
> Schedule the RX NAPI when the RBU interrupt is received, aligning the
> dwmac4 behaviour with XGMAC (commit 6338488356d2 ("net: stmmac: xgmac:
> Add RBU handling in DMA interrupt")).
> 
> This can be observed on a GMAC4 based platform with Split Header (SPH)
> enabled under high TCP RX pressure, where the slower RX refill path
> lets the RX ring run dry.
> 
> Tested with Split Header (SPH) enabled, running a large file download
> over TCP:
> 
> - Without this change, the RX path hangs permanently once the RX ring
>   is exhausted: the RX tail pointer is never updated again and the
>   DMA channel status register latches the RBU bit, while the TX path
>   keeps running.
> 
> - With this change, each RBU interrupt is handled and the RX path
>   recovers by itself. e.g. 3 RBU events within 6 ms during a download
>   peak, each one self-recovered (the RX tail pointer resumes advancing
>   right after), with no further RBU events afterwards.
> 
> Signed-off-by: David Wu <david.wu@rock-chips.com>

In essence this looks correct to me. This fixes some real hangs, so
I'm wondering if this shouldn't actually go to net.

Please re-send to net and with everyone in CC, you can add:

Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Maxime


  reply	other threads:[~2026-11-19  8:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  4:27 David Wu
2026-11-19  8:11 ` Maxime Chevallier [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-11-17  3:43 David Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e822871e-73ec-47e7-96e5-e7885e725555@bootlin.com \
    --to=maxime.chevallier@bootlin.com \
    --cc=Jose.Abreu@synopsys.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=david.wu@rock-chips.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=lorenzo.bianconi@oss.qualcomm.com \
    --cc=luis.la@mail.de \
    --cc=netdev@vger.kernel.org \
    --cc=rmk+kernel@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®