From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Fei Shao <fshao@chromium.org>, Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Nicolas Dufresne <nicolas.dufresne@collabora.com>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Yunfei Dong <yunfei.dong@mediatek.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 3/4] media: mediatek: vcodec: Update mtk_vcodec_mem_free() error messages
Date: Thu, 21 Dec 2023 12:43:06 +0100 [thread overview]
Message-ID: <e822fa39-ba03-4816-a58e-a8328c39e051@collabora.com> (raw)
In-Reply-To: <20231221092226.1395427-3-fshao@chromium.org>
Il 21/12/23 10:17, Fei Shao ha scritto:
> In mtk_vcodec_mem_free(), there are two cases where a NULL VA is passed:
> - mem->size == 0: we are called to free no memory. This may happen when
> we call mtk_vcodec_mem_free() twice or the memory has never been
> allocated.
> - mem->size > 0: we are called to free memory but without VA. This means
> that we failed to free the memory for real.
>
> Both cases are not expected to happen, and we want to have clearer error
> messages to describe which one we just encountered.
> Update the error messages to include more information for that purpose.
>
> Signed-off-by: Fei Shao <fshao@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2023-12-21 11:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 9:17 [PATCH v2 0/4] Improvement around mtk_vcodec_mem_free() logging and usage Fei Shao
2023-12-21 9:17 ` [PATCH v2 1/4] media: mediatek: vcodec: Replace dev_name in error string Fei Shao
2023-12-21 9:17 ` [PATCH v2 2/4] media: mediatek: vcodec: Drop unnecessary variable Fei Shao
2023-12-21 9:17 ` [PATCH v2 3/4] media: mediatek: vcodec: Update mtk_vcodec_mem_free() error messages Fei Shao
2023-12-21 11:43 ` AngeloGioacchino Del Regno [this message]
2023-12-21 9:17 ` [PATCH v2 4/4] media: mediatek: vcodec: Only free buffer VA that is not NULL Fei Shao
2023-12-21 11:43 ` AngeloGioacchino Del Regno
2024-03-27 9:18 ` [PATCH v2 0/4] Improvement around mtk_vcodec_mem_free() logging and usage Fei Shao
2024-03-27 9:57 ` Sebastian Fricke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e822fa39-ba03-4816-a58e-a8328c39e051@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=andrew-ct.chen@mediatek.com \
--cc=fshao@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=tiffany.lin@mediatek.com \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®