From: "Dragan Simic" <dsimic@manjaro.org>
To: michael.opdenacker@rootcommit.com
Cc: "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Heiko Stuebner" <heiko@sntech.de>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: rockchip: Asus Tinkerboard 3 and 3S
Date: Fri, 14 Nov 2025 03:00:54 +0100 [thread overview]
Message-ID: <e8235ec5-d857-1a0a-7108-3c2b8a5dbed9@manjaro.org> (raw)
In-Reply-To: <20251111172003.2324525-2-michael.opdenacker@rootcommit.com>
Hello Michael,
Thanks for this patch! Please, see some comments below.
On Tuesday, November 11, 2025 18:20 CET, michael.opdenacker@rootcommit.com wrote:
> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>
> Document the compatible strings for Asus Tinkerboard 3 [1] and 3S [2],
> which are SBCs based on the Rockchip 3566 SoC.
For consistency, this should be s/Tinkerboard/Tinker Board/.
> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
> and a "mask ROM" DIP switch to the "3" version.
>
> Link: https://tinker-board.asus.com/series/tinker-board-3.html [1]
> Link: https://tinker-board.asus.com/series/tinker-board-3s.html [2]
These two lines should read like this, to serve as references, with
an empty line afterwards, of course:
[1] https://tinker-board.asus.com/series/tinker-board-3.html
[2] https://tinker-board.asus.com/series/tinker-board-3s.html
> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 6aceaa8acbb2..451597a6cffb 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -86,6 +86,17 @@ properties:
> - const: asus,rk3288-tinker-s
> - const: rockchip,rk3288
>
> + - description: Asus Tinker board 3
This should be s/Tinker board/Tinker Board/, because it's actually
a proper noun/name.
> + items:
> + - const: asus,rk3566-tinker-3
> + - const: rockchip,rk3566
> +
> + - description: Asus Tinker board 3S
The same as above.
> + items:
> + - const: asus,rk3566-tinker-3s
> + - const: asus,rk3566-tinker-3
> + - const: rockchip,rk3566
> +
> - description: Beelink A1
> items:
> - const: azw,beelink-a1
next prev parent reply other threads:[~2025-11-14 2:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251111172003.2324525-1-michael.opdenacker@rootcommit.com>
2025-11-11 17:20 ` michael.opdenacker
2025-11-13 8:35 ` Krzysztof Kozlowski
2025-11-14 2:00 ` Dragan Simic [this message]
2025-11-11 17:20 ` [PATCH 2/2] arm64: dts: rockchip: add Tinkerboard 3 and 3S device tree michael.opdenacker
2025-11-13 22:35 ` Heiko Stübner
2025-11-14 14:31 ` Michael Opdenacker
2025-11-14 2:26 ` Dragan Simic
2025-11-14 13:54 ` Michael Opdenacker
2025-11-14 14:30 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8235ec5-d857-1a0a-7108-3c2b8a5dbed9@manjaro.org \
--to=dsimic@manjaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.opdenacker@rootcommit.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®