From: Mike Galbraith <efault@gmx.de>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
linux-kernel@vger.kernel.org, kprateek.nayak@amd.com,
pauld@redhat.com, luis.machado@arm.com
Subject: Re: [PATCH 0/10 v2] sched/fair: Fix statistics with delayed dequeue
Date: Mon, 02 Dec 2024 19:34:51 +0100 [thread overview]
Message-ID: <e824a692ab22423a07ca2ab91713c8340d949c99.camel@gmx.de> (raw)
In-Reply-To: <CAKfTPtDwS4+t0Fnacre6dtxKdxtrgua_2v=s7pZHqDsYoMMxFA@mail.gmail.com>
On Mon, 2024-12-02 at 10:17 +0100, Vincent Guittot wrote:
> On Sun, 1 Dec 2024 at 14:30, Mike Galbraith <efault@gmx.de> wrote:
> >
> > I took the series for a spin in tip v6.12-10334-gb1b238fba309, but
> > runnable seems to have an off-by-one issue, causing it to wander ever
> > further south.
> >
> > patches 1-3 applied.
> > .h_nr_runnable : -3046
> > .runnable_avg : 450189777126
>
> Yeah, I messed up something around finish_delayed_dequeue_entity().
> I'm' going to prepare a v3
v3 is all better with my light config. I'll plug it into an rt tree
with an enterprise config and give it some exercise.
-Mike
prev parent reply other threads:[~2024-12-02 18:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 16:17 Vincent Guittot
2024-11-29 16:17 ` [PATCH 01/10 v2] sched/eevdf: More PELT vs DELAYED_DEQUEUE Vincent Guittot
2024-11-29 16:17 ` [PATCH 02/10 v2] sched/fair: Rename h_nr_running into h_nr_queued Vincent Guittot
2024-11-29 16:17 ` [PATCH 03/10 v2] sched/fair: Add new cfs_rq.h_nr_runnable Vincent Guittot
2024-12-02 9:54 ` Peter Zijlstra
2024-12-02 9:57 ` Vincent Guittot
2024-11-29 16:17 ` [PATCH 04/10 v2] sched/fair: Removed unsued cfs_rq.h_nr_delayed Vincent Guittot
2024-11-29 16:17 ` [PATCH 05/10 v2] sched/fair: Rename cfs_rq.idle_h_nr_running into h_nr_idle Vincent Guittot
2024-11-29 16:17 ` [PATCH 06/10 v2] sched/fair: Remove unused cfs_rq.idle_nr_running Vincent Guittot
2024-11-29 16:17 ` [PATCH 07/10 v2] sched/fair: Rename cfs_rq.nr_running into nr_queued Vincent Guittot
2024-11-29 16:17 ` [PATCH 08/10 v2] sched/fair: Do not try to migrate delayed dequeue task Vincent Guittot
2024-11-29 16:17 ` [PATCH 09/10 v2] sched/fair: Fix sched_can_stop_tick() for fair tasks Vincent Guittot
2024-11-29 18:26 ` K Prateek Nayak
2024-12-02 9:18 ` Vincent Guittot
2024-11-29 16:17 ` [PATCH 10/10 v2] sched/fair: Fix variable declaration position Vincent Guittot
2024-11-29 18:30 ` K Prateek Nayak
2024-12-02 9:19 ` Vincent Guittot
2024-12-01 13:30 ` [PATCH 0/10 v2] sched/fair: Fix statistics with delayed dequeue Mike Galbraith
2024-12-02 9:17 ` Vincent Guittot
2024-12-02 9:23 ` Luis Machado
2024-12-02 9:59 ` Vincent Guittot
2024-12-02 13:52 ` Dietmar Eggemann
2024-12-02 9:58 ` K Prateek Nayak
2024-12-02 11:42 ` Vincent Guittot
2024-12-02 14:24 ` Vincent Guittot
2024-12-02 18:34 ` Mike Galbraith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e824a692ab22423a07ca2ab91713c8340d949c99.camel@gmx.de \
--to=efault@gmx.de \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luis.machado@arm.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®