From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CBB5352004 for ; Mon, 13 Jul 2026 19:47:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783972066; cv=none; b=Q+tRgl54gcDeagCrowmIDQY41k6aKaI7CDzaKcMPnYKjAjwfG0U34ZBX1BWbx5w0oGfO6uM12VL09jJRPTSrS9HMKYojQJvgfaa8vmaoe7jdXd5zjbwSGHE79tQhn0yR0BtZ6h8WmgCXArlaDKG1IMrW/WQiY4KGM/Eg1CTM6Ns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783972066; c=relaxed/simple; bh=Gyg+X4oTM68MBPwzPDsOfJPQiDrapGPHKUYm2GSqCgE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LfKHnSKilKrZB9eYW8nMzmioaz229u4BhbBHh5V1lEskd3/gu/lqSaglyvnnGR1V5R36pMpYARkYrBpDpQO8u+mI1y99hugKBVoLYc+ytR1w1Bqjy0qc56MtevKoyK/qyYCmMRwM1BXz1UVyPw3I2I3tM5etbEM1Ai8POYzVSms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=E/gg9+NM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PUROR6P/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="E/gg9+NM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PUROR6P/" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66DJ9Spd2248062 for ; Mon, 13 Jul 2026 19:47:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LsYB8yHPbPP+skFaM9JiYXJZSC7Kk8Ggqc+cNJG8mMI=; b=E/gg9+NM7cdqU6GK J1bGF6571fqlPr11tx0ljupGSTx+WHiufAYJ0CWbEGlT9oszrTgyU+z9FAknSGwy fG9jvps2RIE10yGfVj2sWn/RcY8J+JeBzsMePAQJVgF6/in5qK7E7c1fTkvv6XhF cSG2MzLBtd29VIrn8aHj7+wshe1L8u998/J6n1ewYeW/yUZ1r+nwS1ky7lk/74b+ AdR2WG4PBFDPeLq3sJYZyGo3Z+eF9xf9+oRcovn8qc+W8YqS63VQisAf4yQaoOwb 46FcO5uxfjisKfE5RqYIzistF+zZ4KclOKJJMXUzyENA2Vm344ngFQJMnXVmPosR iwBOMg== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fcwk3jd6e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Jul 2026 19:47:44 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c916d17dd43so6094095a12.3 for ; Mon, 13 Jul 2026 12:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783972064; x=1784576864; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=LsYB8yHPbPP+skFaM9JiYXJZSC7Kk8Ggqc+cNJG8mMI=; b=PUROR6P/tEuPBKETeB4ibYNkd57ZFwYcu1HJaVUJ+OJmcbOfHB3tnFZVkeHz0pDYNe 9FtXfewmjY9qrrVyI78WnEK5hML2dfXDB135D3EBVf+Eit2eui6I0fodQrNODee48xDt 43oYGMX5fnowMIk2tf+/JRntgxXCvYmQm5L9V+OcPmFwdEMIwy3Z5WG3QJjg2Sbf6O7D 01NvP7/ulDqkyk78qI35LMrnpeNU0HE7wgOqRB1koxRB8Et619VHnho17+ZqxPhHKgOQ DBsCsHpm/OxNzhrqwAjclcFnDLoTbi5ikjGWUoC4qojGha5YbnFzX0dJHO6S489zMDJZ HYwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783972064; x=1784576864; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LsYB8yHPbPP+skFaM9JiYXJZSC7Kk8Ggqc+cNJG8mMI=; b=KMu/+hQ7SQjqJIYkWDHtIXPKuiObERNJaJyKToL5OSQ9jobMIa84ldw8KJsKSiR73a I8tw1PXzkxIRMqJ6g72oJQaYxieg2zV6HIfpkCkpqXxj9qOF0sr1HcsW0OJ6EPl7B0a4 oyprEVuc4ytO4y0wlJ2Q91HP0RJ+bj7OSPq4aFsU4e9Rr7fVKNFk7P1ghKVtKcoU1UKp Mi0p6gEVGR3umzt7Dba3OLwZ/K78sKGkrbBBLL9e5QaHRZKVrl0CnL/fPoILKxV9cx4I eGeIr0iAwEFQQBCGAxKApAYiOmz8ebkh9MxZuFDLqwVjKpYMzaoJ+/mFOREUjw/5sFOs 0zxg== X-Forwarded-Encrypted: i=1; AHgh+RrNLLSko8NucvA75efwhCBuUAPocDPTqVE4zpGNVsEMXqZPbhPnZujxq45RPxY16eVgq+bXFEJUp95UmYQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxwwhYvTyR1U1fimzqtaUwjD7JGNBh1qkwBmNtR/nsmEc4ZbNUL vP+KB+Rxw9E0oAqpWSFdNnqDGxA/zJWEvpoen/SsFTZj97ysANKfxR/fQPz6rUAqJqjEn4nOFrE 67jbHW4gPabjx+KPnoiHd7AQDssXAyNNNXAl+IOfPbOMikglgp2X0LdI/mJRRA8/W90Y= X-Gm-Gg: AfdE7ckG1SrEAvR4p9APvHa4yQt5OCxlaRAOg7H32avYT10lD3JCoqopJeijqJ1Kqv0 kSnBeK9X10ME6bHDHW+nzjGiz/ZOBiBf+rmz5XBrtC5ATb403ijKlRXyRmpCrj2bLCvmB5GmxqU oJTeEquPSrBkepvnvBXZHf+2bogBJNtRdYPA/2Sqi7rfPW8vVrtEXseBnrzfCnxKnopt6bdwIsN FPhsy8oLNh04unjb/SzXD4FFtMyLYNWepzZO33SJef7DXGQF+xj6K0MZsLZS3sbkZ0SHPLSPr1A izC/N0MZF/TTs2oqCCQjrkvuapuhAoDt+W3IyLGLADx1oZXJva3a8LWre1FgFXrdjNyZNiNqpNF /J5Zk7amJuNVOTykhrHiK+Csc8q4efg9YLlo= X-Received: by 2002:a05:6a20:6a28:b0:3c0:9c19:65be with SMTP id adf61e73a8af0-3c110a74421mr10454868637.70.1783972064005; Mon, 13 Jul 2026 12:47:44 -0700 (PDT) X-Received: by 2002:a05:6a20:6a28:b0:3c0:9c19:65be with SMTP id adf61e73a8af0-3c110a74421mr10454838637.70.1783972063592; Mon, 13 Jul 2026 12:47:43 -0700 (PDT) Received: from [192.168.1.5] ([106.222.235.180]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13ba45b7049sm6823350c88.12.2026.07.13.12.47.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2026 12:47:42 -0700 (PDT) Message-ID: Date: Tue, 14 Jul 2026 01:17:32 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/8] arm64: dts: qcom: eliza: Add GPU SMMU node To: Konrad Dybcio Cc: Puranam V G Tejaswi , Abel Vesa , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Will Deacon , Robin Murphy , "Joerg Roedel (AMD)" References: <20260705-eliza-gpu-v1-0-c9f1354dbd29@oss.qualcomm.com> <20260705-eliza-gpu-v1-6-c9f1354dbd29@oss.qualcomm.com> <10b0ad51-8766-449c-a51c-979364e6c781@oss.qualcomm.com> <5fcc0bc1-7f9e-4611-be77-42860e0f4c74@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: <5fcc0bc1-7f9e-4611-be77-42860e0f4c74@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: yVVccdqhleWf_MNyum8WR4uSv_WgHNrg X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEzMDIwNCBTYWx0ZWRfX0/7AHKXvNuWh CfP+TmOQx6F3Iht9Faj3PYb5IAnXoekSLyya/A1sa8jj69COVCZa5VrJTzYMKkrPxJhwB67hGTG B8mbvUPITBuD7Qviwjy6Dbi4mc3uPSE= X-Authority-Analysis: v=2.4 cv=e6c2j6p/ c=1 sm=1 tr=0 ts=6a5540e0 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=yNfbWwvibup9Ri9izU+P7Q==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=sy2TSPCRsGNh5uQNLmIA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEzMDIwNCBTYWx0ZWRfX3zFcSVB3Oe0G nPr4LW+PnUbXRQg+Z/vAMmH8GoPY4OoSlxq4VYER7y8TZI4v2F61hBV2NO/gLQc7fJJMCZy5vJw 9DFLmtdSiq2S0z5UooZCLl33AFzyRQVFAJdif2IAGsx1tujRbQCu1EswyiXvPBxrJ73SpQ7g+Dv 5d2fwbeQPNYcwhX6feQ9b61G6clxN87gaF20B9wbiE8OV8Cte8s9v7KzpN5fZt+Y06fh1JRsNK4 Xf5655jz6GAp7OstUfVzhOTYFIs3HeyuctJuf7BvfdB41YOpPBuztHXkzJo5s7T0VXdR1SFXHN0 +4chLaju2lilQOGkbJEX9eZvpY2qfifLQNZitrfBefvoiBQJiuNI3WSbJx7NdHd50iStumpT6ge IrbLoOwMg70pvsK1vX44dRecu9GoH4qidjNxIzWxN4JT7ZQuvJiM4jHTZHhxtsqZ1Lx9lSLgzOW uODD7hF2EHRialoS1oA== X-Proofpoint-GUID: yVVccdqhleWf_MNyum8WR4uSv_WgHNrg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-13_05,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 phishscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607130204 On 7/6/2026 4:38 PM, Konrad Dybcio wrote: > On 7/6/26 1:07 PM, Konrad Dybcio wrote: >> On 7/5/26 10:14 AM, Akhil P Oommen wrote: >>> From: Abel Vesa >>> >>> Add the nodes to describe the GPU SMMU. >>> >>> Signed-off-by: Abel Vesa >>> Signed-off-by: Akhil P Oommen >>> --- >>> arch/arm64/boot/dts/qcom/eliza.dtsi | 38 +++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 38 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi >>> index c5635f22e2a7..e5b8377e6c3a 100644 >>> --- a/arch/arm64/boot/dts/qcom/eliza.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/eliza.dtsi >>> @@ -2674,6 +2674,44 @@ mdss_dp0_out: endpoint { >>> }; >>> }; >>> >>> + adreno_smmu: iommu@3da0000 { >>> + compatible = "qcom,eliza-smmu-500", "qcom,adreno-smmu", >>> + "qcom,smmu-500", "arm,mmu-500"; >>> + reg = <0x0 0x03da0000 0x0 0x40000>; >>> + #iommu-cells = <2>; >>> + #global-interrupts = <1>; >>> + interrupts = , >> >> 674 is the correct globla > > (modulo the issue i explained below) > > [...] > >> This list is not quite correct. It must be sorted by the context index, >> to which a given interrupt corresponds to - the driver relies on that >> to give you information about where a context fault happens >> >> Moreover, I see that the interrupt sheet has the bug where some >> interrupts are offset by 32 from the base vector, and others are offset >> by 31 (i.e. the SPI number doesn't equal irq vector - 32) - please find >> out which mapping is correct with the right folks I reviewed this and looks correct to me. Also, this matches the downstream configuration. Did you confuse with Dest Port vs Vector ID in the documentation? -Akhil. > > Konrad