From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755526AbdAGVnm (ORCPT ); Sat, 7 Jan 2017 16:43:42 -0500 Received: from mleia.com ([178.79.152.223]:50970 "EHLO mail.mleia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750981AbdAGVnd (ORCPT ); Sat, 7 Jan 2017 16:43:33 -0500 Subject: Re: [PATCH] i2c: print correct device invalid address To: John Garry , wsa@the-dreams.de References: <1483700577-60130-1-git-send-email-john.garry@huawei.com> Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com From: Vladimir Zapolskiy Message-ID: Date: Sat, 7 Jan 2017 23:43:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <1483700577-60130-1-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 X-CRM114-CacheID: sfid-20170107_214330_026897_91380AD5 X-CRM114-Status: GOOD ( 12.51 ) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/06/2017 01:02 PM, John Garry wrote: > In of_i2c_register_device(), when the check for > device address validity fails we print the info.addr, > which has not been assigned properly. > > Fix this by printing the actual invalid address. > > Signed-off-by: John Garry > > diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c > index cf9e396..03cfcdd 100644 > --- a/drivers/i2c/i2c-core.c > +++ b/drivers/i2c/i2c-core.c > @@ -1708,7 +1708,7 @@ static struct i2c_client *of_i2c_register_device(struct i2c_adapter *adap, > > if (i2c_check_addr_validity(addr, info.flags)) { > dev_err(&adap->dev, "of_i2c: invalid addr=%x on %s\n", > - info.addr, node->full_name); > + addr, node->full_name); > return ERR_PTR(-EINVAL); > } > > Reviewed-by: Vladimir Zapolskiy Fixes: b4e2f6ac1281 ("i2c: apply DT flags when probing") Thank you for the fix. -- With best wishes, Vladimir