From: Dan Carpenter <dan.carpenter@linaro.org>
To: Ian To <onlyian4981@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] staging: rtl8723bs: remove unnecessary parentheses
Date: Wed, 5 Feb 2025 09:00:41 +0300 [thread overview]
Message-ID: <e831420d-77cb-4ff1-9c13-1779981988f2@stanley.mountain> (raw)
In-Reply-To: <d0b70310eb6b2dfdf062ba865362cd2640cb93e0.1738720049.git.onlyian4981@gmail.com>
On Tue, Feb 04, 2025 at 05:50:16PM -0800, Ian To wrote:
> /*
> -Caller must hold pmlmepriv->lock first.
> -*/
> + *Caller must hold pmlmepriv->lock first.
> + */
This is unrelated.
> @@ -1745,24 +1746,24 @@ static int rtw_check_join_candidate(struct mlme_priv *mlme
> }
>
> /*
> -Calling context:
> -The caller of the sub-routine will be in critical section...
> -The caller must hold the following spinlock
> -pmlmepriv->lock
> -*/
> + *Calling context:
> + *The caller of the sub-routine will be in critical section...
> + *The caller must hold the following spinlock
> + *pmlmepriv->lock
> + */
>
This is unrelated too.
regards,
dan carpenter
next prev parent reply other threads:[~2025-02-05 6:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 1:50 [PATCH 0/4] Code style cleanup Ian To
2025-02-05 1:50 ` [PATCH 1/4] staging: rtl8723bs: remove unnecessary parentheses Ian To
2025-02-05 5:57 ` Dan Carpenter
2025-02-05 6:00 ` Dan Carpenter [this message]
2025-02-05 1:50 ` [PATCH 2/4] staging: rtl8723bs: break up long lines Ian To
2025-02-05 1:50 ` [PATCH 3/4] staging: rtl8723bs: fix spacing issues Ian To
2025-02-05 1:50 ` [PATCH 4/4] staging: rtl8723bs: fixed comment styling Ian To
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e831420d-77cb-4ff1-9c13-1779981988f2@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=onlyian4981@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®