From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC105C46467 for ; Tue, 10 Jan 2023 09:07:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231637AbjAJJHD (ORCPT ); Tue, 10 Jan 2023 04:07:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230406AbjAJJGa (ORCPT ); Tue, 10 Jan 2023 04:06:30 -0500 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A72D19C3E for ; Tue, 10 Jan 2023 01:06:28 -0800 (PST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20230110090624euoutp01ac3728ee2ccf2610869e4c87457a38d5~45040BxaL2198121981euoutp01V for ; Tue, 10 Jan 2023 09:06:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20230110090624euoutp01ac3728ee2ccf2610869e4c87457a38d5~45040BxaL2198121981euoutp01V DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1673341584; bh=3Cf+DCWYAmzSB65N/ulwd8ALWX5sTIUaVfbs/6Q9LCg=; h=Date:Subject:To:CC:From:In-Reply-To:References:From; b=k1RjNnZ34QJhAESzBJQbAzM61irDC4sNH8N21bvJSisYE4GpOTFXGw8FPPn1Yy6eS oZiqII7QFnA2pUELR1vmFyyzOhJZkdYUgzaWJnKgReYtVRJyro0LKVGEy7f9pG0wrD /qW75OXbUs5zZlLxKbrmIdTJ6YDQksdouzCiU7po= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20230110090624eucas1p1a99a687265afdabbd20f8c8d3e3aa446~4504neOvB2747527475eucas1p1w; Tue, 10 Jan 2023 09:06:24 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id A3.BB.43884.09A2DB36; Tue, 10 Jan 2023 09:06:24 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20230110090624eucas1p23074c6f9d41a5005e499906e01e58f3c~4504PejtP1569015690eucas1p2R; Tue, 10 Jan 2023 09:06:24 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20230110090624eusmtrp1d651397f9466392829008648dc6eae9c~4504Ou5Kq1446914469eusmtrp1Z; Tue, 10 Jan 2023 09:06:24 +0000 (GMT) X-AuditID: cbfec7f5-25bff7000000ab6c-a6-63bd2a90b6c9 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 60.77.52424.F8A2DB36; Tue, 10 Jan 2023 09:06:23 +0000 (GMT) Received: from CAMSVWEXC01.scsc.local (unknown [106.1.227.71]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20230110090623eusmtip1acb75198ba36a03190e868d77e94b077~4504Cfj-20739907399eusmtip1K; Tue, 10 Jan 2023 09:06:23 +0000 (GMT) Received: from [192.168.8.107] (106.210.248.241) by CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 10 Jan 2023 09:06:22 +0000 Message-ID: Date: Tue, 10 Jan 2023 10:06:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 6/7] dm-zone: use generic helpers to calculate offset from zone start Content-Language: en-US To: Christoph Hellwig CC: , , , , , , , , , , , Luis Chamberlain , Johannes Thumshirn From: Pankaj Raghav In-Reply-To: <20230110065738.GE10289@lst.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [106.210.248.241] X-ClientProxiedBy: CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) To CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrAKsWRmVeSWpSXmKPExsWy7djPc7oTtPYmG6y/J2ax+m4/m8W0Dz+Z LX6fPc9ssffdbFaLPYsmMVmsXH2UyeJv1z0mizMvP7NY7L2lbXF51xw2i/nLnrJb3JjwlNHi xC1pB16Py1e8PS6fLfXYtKqTzWPzknqP3Tcb2Dx2tt5n9Ti70tHj/b6rQOHT1R6fN8l5tB/o ZgrgjuKySUnNySxLLdK3S+DK6O7+z1hwl7di+ZybrA2MG7i7GDk5JARMJHrP72bqYuTiEBJY wSjx+lsrI0hCSOALo8TX30UQ9mdGiS1PuboYOcAaXl2UgKhfzijRd+84G1zNii5uiMRuRom1 G6YxgyR4Bewk3i5YwAJiswioSmxpv8oOEReUODnzCVhcVCBKounCTzBbWCBa4uG882C9zALi EreezGcCsUUElCSevjrLCLKAWaCRWeLDj/uMIBexCWhJNHaCzeQU0JH4PeUgK0SvpkTr9t/s ELa8xPa3c5ghPlaWWHzhGiOEXSux9tgZdpCZEgKXOCV27l3OBvGli8ThP+UQNcISr45vYYew ZSROT+5hgbCrJZ7e+M0M0dvCKNG/cz1Ur7VE35kcCNNRYsm2cgiTT+LGW0GIa/gkJm2bzjyB UXUWUkDMQvLwLCQPzELywAJGllWM4qmlxbnpqcXGeanlesWJucWleel6yfm5mxiBie70v+Nf dzCuePVR7xAjEwfjIUYJDmYlEd6VnHuShXhTEiurUovy44tKc1KLDzFKc7AoifPO2Do/WUgg PbEkNTs1tSC1CCbLxMEp1cC0Zronyz2ftXwzHt1oNGHrvPMtw7Zyu3HvSo2zH6o69K9wyior CFhuc6urXv406UrItAnnfjoztP/sqnH9NmvRHa4954V8P6uti/lusESLx0ppptrZ7/feSzko XlSYecpmJfeHOTFfOpXOB7OqK70zd14z+ZNb/NOjgjMebf3xnOHEnHd+y8V2cxx8yv8hsnfW ktVP3dYfOFZXI/rVV1MiU00yWm7d6p+yZywrzUxes6dH53PcVg9IOnDHcYMDT5RlpoR6+3Td /uvdNe+EWf3t/r26VmPxIOnWrmmHGxWvCP5Onj6xePfvAhOGqp5d/zLZ15toOiTvdCuuFykP r1P4lMcmEPJn4sxLqtIuukeVWIozEg21mIuKEwEC6Xp64wMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkleLIzCtJLcpLzFFi42I5/e/4Xd1+rb3JBrvWWVisvtvPZjHtw09m i99nzzNb7H03m9Viz6JJTBYrVx9lsvjbdY/J4szLzywWe29pW1zeNYfNYv6yp+wWNyY8ZbQ4 cUvagdfj8hVvj8tnSz02repk89i8pN5j980GNo+drfdZPc6udPR4v+8qUPh0tcfnTXIe7Qe6 mQK4o/RsivJLS1IVMvKLS2yVog0tjPQMLS30jEws9QyNzWOtjEyV9O1sUlJzMstSi/TtEvQy urv/Mxbc5a1YPucmawPjBu4uRg4OCQETiVcXJboYuTiEBJYyStzc8Iy1i5ETKC4j8enKR3YI W1jiz7UuNoiij4wSG5e+ZIdwdjNKPLh3FayDV8BO4u2CBSwgNouAqsSW9qvsEHFBiZMzn4DF RQWiJG6ef8gEYgsLREs87VnACGIzC4hL3HoyHywuIqAk8fTVWUaQBcwCjcwSH37cBysSErjL KPF9SRHI2WwCWhKNnWDzOQV0JH5POcgKMUdTonX7b3YIW15i+9s5zBAfKEssvnCNEcKulXh1 fzfjBEbRWUjOm4XkjFlIRs1CMmoBI8sqRpHU0uLc9NxiI73ixNzi0rx0veT83E2MwDSx7djP LTsYV776qHeIkYmD8RCjBAezkgjvSs49yUK8KYmVValF+fFFpTmpxYcYTYFhNJFZSjQ5H5io 8kriDc0MTA1NzCwNTC3NjJXEeT0LOhKFBNITS1KzU1MLUotg+pg4OKUamIqVoie/vHqSL2tD sq+w+YkKvib2B6f/hel+TGe/K/39+MPIl+cEtJTt0/rOT+FNS0nstD+9YkOH3Xt9+9nu33m3 5rL2MMW7s/VUSiu1NTXuWqyygofth8kSfmGei0f4w1Iz5zn/cHHZMG3iF2kJa8/F/mqZ5vdY smf53Gb78reuvHPCki09YaoCjH84tfMN8zPtZ/7/PCla7HDdi0mffE9eXibvKajF8Od1nUD/ akP7lOkBF9bcj+MyMBPnn84ZU7f33/ufjnFyH95P25fzndvWKDK2Y15T3JUPU+zOB9z4f31+ 04Wyn44F3Md+hb83/NnAFd6sKnTtJnvD8toHKVe3HN8TlvWGMUl8a2qxEktxRqKhFnNRcSIA 0ga3ZZwDAAA= X-CMS-MailID: 20230110090624eucas1p23074c6f9d41a5005e499906e01e58f3c X-Msg-Generator: CA X-RootMTR: 20230106083322eucas1p1ce3ca7b02ca87bb2be8543291e223338 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230106083322eucas1p1ce3ca7b02ca87bb2be8543291e223338 References: <20230106083317.93938-1-p.raghav@samsung.com> <20230106083317.93938-7-p.raghav@samsung.com> <20230110065738.GE10289@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-01-10 07:57, Christoph Hellwig wrote: > On Fri, Jan 06, 2023 at 09:33:16AM +0100, Pankaj Raghav wrote: >> Use the bdev_offset_from_zone_start() helper function to calculate >> the offset from zone start instead of open coding. >> >> Signed-off-by: Pankaj Raghav >> Reviewed-by: Luis Chamberlain >> Reviewed-by: Damien Le Moal >> Reviewed-by: Bart Van Assche >> Reviewed-by: Johannes Thumshirn >> Reviewed-by: Mike Snitzer >> --- >> drivers/md/dm-zone.c | 8 +++----- >> 1 file changed, 3 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/md/dm-zone.c b/drivers/md/dm-zone.c >> index 3dafc0e8b7a9..ac6fc1293d41 100644 >> --- a/drivers/md/dm-zone.c >> +++ b/drivers/md/dm-zone.c >> @@ -390,7 +390,8 @@ static bool dm_zone_map_bio_begin(struct mapped_device *md, >> case REQ_OP_WRITE_ZEROES: >> case REQ_OP_WRITE: >> /* Writes must be aligned to the zone write pointer */ >> - if ((clone->bi_iter.bi_sector & (zsectors - 1)) != zwp_offset) >> + if (bdev_offset_from_zone_start(md->disk->part0, >> + clone->bi_iter.bi_sector) != zwp_offset) > > I can't see how this actually cleans antyhing up, while it does add an > overly long line. > While I do agree with the overly long line comment, I feel it makes the intent more clear, as it is easy to overlook this math operation. >> if (clone->bi_status == BLK_STS_OK && >> bio_op(clone) == REQ_OP_ZONE_APPEND) { >> orig_bio->bi_iter.bi_sector += >> - clone->bi_iter.bi_sector & mask; >> + bdev_offset_from_zone_start(disk->part0, clone->bi_iter.bi_sector); > > Same here.